Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-25 08:28:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Add a datapoint to sync the Tuya MCU minimum brightness (#1347)

Browse source 
The Tuya MCU keeps its own internal minimum brightness setting.  This value may
not match the minimum brightness setting for ESPHome, leading to some issues:

1. Dimming is limited--on some devices the default minimum is as high as 10%,
meaning the dimmest ESPHome will go is still quite bright.

2. HA will allow a user to set a value below the MCU minimum, but the MCU will
reject it and keep the previous setting, so the UI is confusing.

This PR adds a setting to configure the datapoint for setting the MCU minimum
brightness.  If the setting is set, then ESPHome will synchronize the MCU's
minimum brightness with the one configured for ESPHome on startup.
This commit is contained in:
Connor Prussin 2020-11-05 15:53:25 -08:00 committed by GitHub
parent 274741a9d5
commit 051a1e4772
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
esphome/components/tuya/light/__init__.py
View file

@ -8,6 +8,7 @@ from .. import tuya_ns, CONF_TUYA_ID, Tuya
DEPENDENCIES = ['tuya'] DEPENDENCIES = ['tuya']
CONF_DIMMER_DATAPOINT = "dimmer_datapoint" CONF_DIMMER_DATAPOINT = "dimmer_datapoint"
CONF_MIN_VALUE_DATAPOINT = "min_value_datapoint"
TuyaLight = tuya_ns.class_('TuyaLight', light.LightOutput, cg.Component) TuyaLight = tuya_ns.class_('TuyaLight', light.LightOutput, cg.Component)
@ -15,6 +16,7 @@ CONFIG_SCHEMA = cv.All(light.BRIGHTNESS_ONLY_LIGHT_SCHEMA.extend({
cv.GenerateID(CONF_OUTPUT_ID): cv.declare_id(TuyaLight), cv.GenerateID(CONF_OUTPUT_ID): cv.declare_id(TuyaLight),
cv.GenerateID(CONF_TUYA_ID): cv.use_id(Tuya), cv.GenerateID(CONF_TUYA_ID): cv.use_id(Tuya),
cv.Optional(CONF_DIMMER_DATAPOINT): cv.uint8_t, cv.Optional(CONF_DIMMER_DATAPOINT): cv.uint8_t,
cv.Optional(CONF_MIN_VALUE_DATAPOINT): cv.uint8_t,
cv.Optional(CONF_SWITCH_DATAPOINT): cv.uint8_t, cv.Optional(CONF_SWITCH_DATAPOINT): cv.uint8_t,
cv.Optional(CONF_MIN_VALUE): cv.int_, cv.Optional(CONF_MIN_VALUE): cv.int_,
cv.Optional(CONF_MAX_VALUE): cv.int_, cv.Optional(CONF_MAX_VALUE): cv.int_,
@ -34,6 +36,8 @@ def to_code(config):
if CONF_DIMMER_DATAPOINT in config: if CONF_DIMMER_DATAPOINT in config:
cg.add(var.set_dimmer_id(config[CONF_DIMMER_DATAPOINT])) cg.add(var.set_dimmer_id(config[CONF_DIMMER_DATAPOINT]))
if CONF_MIN_VALUE_DATAPOINT in config:
cg.add(var.set_min_value_datapoint_id(config[CONF_MIN_VALUE_DATAPOINT]))
if CONF_SWITCH_DATAPOINT in config: if CONF_SWITCH_DATAPOINT in config:
cg.add(var.set_switch_id(config[CONF_SWITCH_DATAPOINT])) cg.add(var.set_switch_id(config[CONF_SWITCH_DATAPOINT]))
if CONF_MIN_VALUE in config: if CONF_MIN_VALUE in config:

7
esphome/components/tuya/light/tuya_light.cpp
View file

@ -21,6 +21,13 @@ void TuyaLight::setup() {
call.perform(); call.perform();
}); });
} }
if (min_value_datapoint_id_.has_value()) {
TuyaDatapoint datapoint{};
datapoint.id = *this->min_value_datapoint_id_;
datapoint.type = TuyaDatapointType::INTEGER;
datapoint.value_int = this->min_value_;
parent_->set_datapoint_value(datapoint);
}
} }
void TuyaLight::dump_config() { void TuyaLight::dump_config() {

4
esphome/components/tuya/light/tuya_light.h
View file

@ -12,6 +12,9 @@ class TuyaLight : public Component, public light::LightOutput {
void setup() override; void setup() override;
void dump_config() override; void dump_config() override;
void set_dimmer_id(uint8_t dimmer_id) { this->dimmer_id_ = dimmer_id; } void set_dimmer_id(uint8_t dimmer_id) { this->dimmer_id_ = dimmer_id; }
void set_min_value_datapoint_id(uint8_t min_value_datapoint_id) {
this->min_value_datapoint_id_ = min_value_datapoint_id;
}
void set_switch_id(uint8_t switch_id) { this->switch_id_ = switch_id; } void set_switch_id(uint8_t switch_id) { this->switch_id_ = switch_id; }
void set_tuya_parent(Tuya *parent) { this->parent_ = parent; } void set_tuya_parent(Tuya *parent) { this->parent_ = parent; }
void set_min_value(uint32_t min_value) { min_value_ = min_value; } void set_min_value(uint32_t min_value) { min_value_ = min_value; }
@ -26,6 +29,7 @@ class TuyaLight : public Component, public light::LightOutput {
Tuya *parent_; Tuya *parent_;
optional<uint8_t> dimmer_id_{}; optional<uint8_t> dimmer_id_{};
optional<uint8_t> min_value_datapoint_id_{};
optional<uint8_t> switch_id_{}; optional<uint8_t> switch_id_{};
uint32_t min_value_ = 0; uint32_t min_value_ = 0;
uint32_t max_value_ = 255; uint32_t max_value_ = 255;