Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-12-22 21:44:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fix ledc can't find bit_depth (#786)

Browse source 
Fixes https://github.com/esphome/issues/issues/759
This commit is contained in:
Otto Winter 2019-10-21 22:55:27 +02:00 committed by GitHub
parent c0adaa8de8
commit 1177b856a0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
esphome/components/ledc/ledc_output.cpp
View file

@ -42,8 +42,8 @@ float ledc_min_frequency_for_bit_depth(uint8_t bit_depth) {
} }
optional<uint8_t> ledc_bit_depth_for_frequency(float frequency) { optional<uint8_t> ledc_bit_depth_for_frequency(float frequency) {
for (int i = 20; i >= 1; i--) { for (int i = 20; i >= 1; i--) {
const float min_frequency = ledc_min_frequency_for_bit_depth(frequency); const float min_frequency = ledc_min_frequency_for_bit_depth(i);
const float max_frequency = ledc_max_frequency_for_bit_depth(frequency); const float max_frequency = ledc_max_frequency_for_bit_depth(i);
if (min_frequency <= frequency && frequency <= max_frequency) if (min_frequency <= frequency && frequency <= max_frequency)
return i; return i;
} }
@ -56,7 +56,7 @@ void LEDCOutput::apply_frequency(float frequency) {
ESP_LOGW(TAG, "Frequency %f can't be achieved with any bit depth", frequency); ESP_LOGW(TAG, "Frequency %f can't be achieved with any bit depth", frequency);
this->status_set_warning(); this->status_set_warning();
} }
this->bit_depth_ = *bit_depth_opt; this->bit_depth_ = bit_depth_opt.value_or(8);
this->frequency_ = frequency; this->frequency_ = frequency;
ledcSetup(this->channel_, frequency, this->bit_depth_); ledcSetup(this->channel_, frequency, this->bit_depth_);
// re-apply duty // re-apply duty