Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-23 23:48:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

also fix answer typos in variable names

Browse source
This commit is contained in:
Michael Doppler 2024-07-07 14:03:39 +02:00
parent 177a48de2c
commit 12a94bcd72
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
esphome/components/mcp3428/mcp3428.cpp
View file

@ -9,8 +9,8 @@ static const char *const TAG = "mcp3426/7/8";
void MCP3428Component::setup() { void MCP3428Component::setup() {
ESP_LOGCONFIG(TAG, "Setting up MCP3426/7/8..."); ESP_LOGCONFIG(TAG, "Setting up MCP3426/7/8...");
uint8_t anwser[3]; uint8_t answer[3];
if (this->read(anwser, 3) != i2c::ErrorCode::NO_ERROR) { if (this->read(answer, 3) != i2c::ErrorCode::NO_ERROR) {
this->mark_failed(); this->mark_failed();
ESP_LOGE(TAG, "Communication with MCP3426/7/8 failed while reading device register!"); ESP_LOGE(TAG, "Communication with MCP3426/7/8 failed while reading device register!");
return; return;
@ -114,15 +114,15 @@ bool MCP3428Component::request_measurement(MCP3428Multiplexer multiplexer, MCP34
} }
bool MCP3428Component::poll_result(float &voltage) { bool MCP3428Component::poll_result(float &voltage) {
uint8_t anwser[3]; uint8_t answer[3];
voltage = NAN; voltage = NAN;
if (this->read(anwser, 3) != i2c::ErrorCode::NO_ERROR) { if (this->read(answer, 3) != i2c::ErrorCode::NO_ERROR) {
this->status_set_warning("Communication error polling component"); this->status_set_warning("Communication error polling component");
return false; return false;
} }
if ((anwser[2] & 0b10000000) == 0) { if ((answer[2] & 0b10000000) == 0) {
// ready flag is 0, valid measurement received // ready flag is 0, valid measurement received
voltage = this->convert_answer_to_voltage_(anwser); voltage = this->convert_answer_to_voltage_(answer);
single_measurement_active_ = false; single_measurement_active_ = false;
this->status_clear_warning(); this->status_clear_warning();
return true; return true;
@ -160,8 +160,8 @@ float MCP3428Component::convert_answer_to_voltage_(uint8_t const *answer) {
break; break;
} }
// convert code (first 2 bytes of cleaned up anwser) into voltage ticks // convert code (first 2 bytes of cleaned up answer) into voltage ticks
int16_t ticks = anwser[0] << 8 | anwser[1]; int16_t ticks = answer[0] << 8 | answer[1];
return tick_voltage * ticks; return tick_voltage * ticks;
} }

2
esphome/components/mcp3428/mcp3428.h
View file

@ -50,7 +50,7 @@ class MCP3428Component : public Component, public i2c::I2CDevice {
void abandon_current_measurement() { single_measurement_active_ = false; } void abandon_current_measurement() { single_measurement_active_ = false; }
protected: protected:
float convert_answer_to_voltage_(uint8_t const *anwser); float convert_answer_to_voltage_(uint8_t const *answer);
uint8_t prev_config_{0}; uint8_t prev_config_{0};
uint32_t last_config_write_ms_{0}; uint32_t last_config_write_ms_{0};