Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-10 01:07:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Remove unneeded validation for esp32 gpio pins (#4394)

Browse source
This commit is contained in:
Jesse Hills 2023-02-07 12:43:30 +13:00 committed by GitHub
parent 9494c27ad8
commit 1b66fa5004
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
esphome/components/esp32/gpio.py
View file

@ -123,11 +123,8 @@ def validate_gpio_pin(value):
def validate_supports(value): def validate_supports(value):
mode = value[CONF_MODE] mode = value[CONF_MODE]
is_input = mode[CONF_INPUT]
is_output = mode[CONF_OUTPUT] is_output = mode[CONF_OUTPUT]
is_open_drain = mode[CONF_OPEN_DRAIN] is_open_drain = mode[CONF_OPEN_DRAIN]
is_pullup = mode[CONF_PULLUP]
is_pulldown = mode[CONF_PULLDOWN]
variant = CORE.data[KEY_ESP32][KEY_VARIANT] variant = CORE.data[KEY_ESP32][KEY_VARIANT]
if variant not in _esp32_validations: if variant not in _esp32_validations:
raise cv.Invalid(f"Unsupported ESP32 variant {variant}") raise cv.Invalid(f"Unsupported ESP32 variant {variant}")
@ -138,26 +135,6 @@ def validate_supports(value):
) )
value = _esp32_validations[variant].usage_validation(value) value = _esp32_validations[variant].usage_validation(value)
if CORE.using_arduino:
# (input, output, open_drain, pullup, pulldown)
supported_modes = {
# INPUT
(True, False, False, False, False),
# OUTPUT
(False, True, False, False, False),
# INPUT_PULLUP
(True, False, False, True, False),
# INPUT_PULLDOWN
(True, False, False, False, True),
# OUTPUT_OPEN_DRAIN
(False, True, True, False, False),
}
key = (is_input, is_output, is_open_drain, is_pullup, is_pulldown)
if key not in supported_modes:
raise cv.Invalid(
"This pin mode is not supported on ESP32 for arduino frameworks",
[CONF_MODE],
)
return value return value