Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-23 23:48:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

DALY Modbus BMS: add log messages for modbus response

Browse source
This commit is contained in:
patagona 2024-09-29 19:19:28 +02:00
parent d76d623033
commit 206562bebf
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
esphome/components/daly_hkms_bms/daly_hkms_bms.cpp
View file

@ -62,13 +62,17 @@ void DalyHkmsBmsComponent::update() {
void DalyHkmsBmsComponent::on_modbus_data(const std::vector<uint8_t> &data) { void DalyHkmsBmsComponent::on_modbus_data(const std::vector<uint8_t> &data) {
// Other components might be sending commands to our device. But we don't get called with enough // Other components might be sending commands to our device. But we don't get called with enough
// context to know what is what. So if we didn't do a send, we ignore the data. // context to know what is what. So if we didn't do a send, we ignore the data.
if (!this->last_send_) if (!this->last_send_) {
ESP_LOGD(TAG, "Got data without requesting it first");
return; return;
}
this->last_send_ = 0; this->last_send_ = 0;
// Also ignore the data if the message is too short. Otherwise we will publish invalid values. // Also ignore the data if the message is too short. Otherwise we will publish invalid values.
if (data.size() < DALY_MODBUS_REGISTER_COUNT * 2) if (data.size() < DALY_MODBUS_REGISTER_COUNT * 2) {
ESP_LOGD(TAG, "Not enough data in modbus response");
return; return;
}
auto get_register = [&](size_t i) -> uint16_t { auto get_register = [&](size_t i) -> uint16_t {
return encode_uint16(data[i * 2], data[i * 2 + 1]); return encode_uint16(data[i * 2], data[i * 2 + 1]);