Read string of bool env and match against well known values (#5232)

This commit is contained in:
Jesse Hills 2023-08-11 16:20:58 +12:00
parent 21ebc7f95b
commit 44a917929d
No known key found for this signature in database
GPG key ID: BEAAE804EFD8E83A
2 changed files with 12 additions and 1 deletions

View file

@ -144,7 +144,14 @@ def resolve_ip_address(host):
def get_bool_env(var, default=False): def get_bool_env(var, default=False):
return bool(os.getenv(var, default)) value = os.getenv(var, default)
if isinstance(value, str):
value = value.lower()
if value in ["1", "true"]:
return True
if value in ["0", "false"]:
return False
return bool(value)
def get_str_env(var, default=None): def get_str_env(var, default=None):

View file

@ -108,6 +108,10 @@ def test_is_ip_address__valid(value):
("FOO", None, False, False), ("FOO", None, False, False),
("FOO", None, True, True), ("FOO", None, True, True),
("FOO", "", False, False), ("FOO", "", False, False),
("FOO", "False", False, False),
("FOO", "True", False, True),
("FOO", "FALSE", True, False),
("FOO", "fAlSe", True, False),
("FOO", "Yes", False, True), ("FOO", "Yes", False, True),
("FOO", "123", False, True), ("FOO", "123", False, True),
), ),