Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-23 15:38:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

NEC IR protocol: add padding bytes

Browse source
This commit is contained in:
Adam Jones 2024-09-16 21:07:33 +01:00
parent 857a3dcf72
commit 4707e1bbc9
2 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
esphome/components/remote_base/nec_protocol.cpp
View file

@ -13,8 +13,17 @@ static const uint32_t BIT_ONE_LOW_US = 1690;
static const uint32_t BIT_ZERO_LOW_US = 560;
void NECProtocol::encode(RemoteTransmitData *dst, const NECData &data) {
ESP_LOGD(TAG, "Sending NEC: address=0x%04X, command=0x%04X command_repeats=%d", data.address, data.command,
data.command_repeats);
// If the address or command is <= 0xFF the user has only supplied one byte
// We need to generate parity bits to pad the value to 2 bytes
// The NEC protocol requires us to prepend the inverse byte, e.g. 0x21 -> 0xDE21
uint16_t address = data.address <= 0xFF
? data.address | ((uint16_t)(~data.address) << 8)
: data.address;
uint16_t command = data.command <= 0xFF
? data.command | ((uint16_t)(~data.command) << 8)
: data.command;
ESP_LOGD(TAG, "Sending NEC: address=0x%04X, command=0x%04X command_repeats=%d", address, command, data.command_repeats);
dst->reserve(2 + 32 + 32 * data.command_repeats + 2);
dst->set_carrier_frequency(38000);
@ -22,7 +31,7 @@ void NECProtocol::encode(RemoteTransmitData *dst, const NECData &data) {
dst->item(HEADER_HIGH_US, HEADER_LOW_US);
for (uint16_t mask = 1; mask; mask <<= 1) {
if (data.address & mask) {
if (address & mask) {
dst->item(BIT_HIGH_US, BIT_ONE_LOW_US);
} else {
dst->item(BIT_HIGH_US, BIT_ZERO_LOW_US);
@ -31,7 +40,7 @@ void NECProtocol::encode(RemoteTransmitData *dst, const NECData &data) {
for (uint16_t repeats = 0; repeats < data.command_repeats; repeats++) {
for (uint16_t mask = 1; mask; mask <<= 1) {
if (data.command & mask) {
if (command & mask) {
dst->item(BIT_HIGH_US, BIT_ONE_LOW_US);
} else {
dst->item(BIT_HIGH_US, BIT_ZERO_LOW_US);

6
tests/components/remote_transmitter/common-buttons.yaml
View file

@ -17,6 +17,12 @@ button:
remote_transmitter.transmit_nec:
address: 0x4242
command: 0x8484
- platform: template
name: NEC short
on_press:
remote_transmitter.transmit_nec:
address: 0x32
command: 0x02
- platform: template
name: LG
on_press: