[code-quality] Fix variable naming in base_light_effects (#7237)

This commit is contained in:
tomaszduda23 2024-08-13 21:54:37 +02:00 committed by GitHub
parent 9663b7d67c
commit 4bd7ba0d30
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -25,7 +25,7 @@ class PulseLightEffect : public LightEffect {
return; return;
} }
auto call = this->state_->turn_on(); auto call = this->state_->turn_on();
float out = this->on_ ? this->max_brightness : this->min_brightness; float out = this->on_ ? this->max_brightness_ : this->min_brightness_;
call.set_brightness_if_supported(out); call.set_brightness_if_supported(out);
call.set_transition_length_if_supported(this->on_ ? this->transition_on_length_ : this->transition_off_length_); call.set_transition_length_if_supported(this->on_ ? this->transition_on_length_ : this->transition_off_length_);
this->on_ = !this->on_; this->on_ = !this->on_;
@ -43,8 +43,8 @@ class PulseLightEffect : public LightEffect {
void set_update_interval(uint32_t update_interval) { this->update_interval_ = update_interval; } void set_update_interval(uint32_t update_interval) { this->update_interval_ = update_interval; }
void set_min_max_brightness(float min, float max) { void set_min_max_brightness(float min, float max) {
this->min_brightness = min; this->min_brightness_ = min;
this->max_brightness = max; this->max_brightness_ = max;
} }
protected: protected:
@ -53,8 +53,8 @@ class PulseLightEffect : public LightEffect {
uint32_t transition_on_length_{}; uint32_t transition_on_length_{};
uint32_t transition_off_length_{}; uint32_t transition_off_length_{};
uint32_t update_interval_{}; uint32_t update_interval_{};
float min_brightness{0.0}; float min_brightness_{0.0};
float max_brightness{1.0}; float max_brightness_{1.0};
}; };
/// Random effect. Sets random colors every 10 seconds and slowly transitions between them. /// Random effect. Sets random colors every 10 seconds and slowly transitions between them.