Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-23 15:38:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Fix MCP23x17 not disabling pullup after config change (#2855)

Browse source
This commit is contained in:
Oxan van Leeuwen 2021-12-06 07:59:50 +01:00 committed by Jesse Hills
parent 3ac720df47
commit 56870ed4a8
No known key found for this signature in database
GPG key ID: BEAAE804EFD8E83A
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
esphome/components/mcp23x17_base/mcp23x17_base.cpp
View file

@ -24,6 +24,7 @@ void MCP23X17Base::pin_mode(uint8_t pin, gpio::Flags flags) {
uint8_t gppu = pin < 8 ? mcp23x17_base::MCP23X17_GPPUA : mcp23x17_base::MCP23X17_GPPUB; uint8_t gppu = pin < 8 ? mcp23x17_base::MCP23X17_GPPUA : mcp23x17_base::MCP23X17_GPPUB;
if (flags == gpio::FLAG_INPUT) { if (flags == gpio::FLAG_INPUT) {
this->update_reg(pin, true, iodir); this->update_reg(pin, true, iodir);
this->update_reg(pin, false, gppu);
} else if (flags == (gpio::FLAG_INPUT | gpio::FLAG_PULLUP)) { } else if (flags == (gpio::FLAG_INPUT | gpio::FLAG_PULLUP)) {
this->update_reg(pin, true, iodir); this->update_reg(pin, true, iodir);
this->update_reg(pin, true, gppu); this->update_reg(pin, true, gppu);