Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-01-03 03:11:44 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

SX1509 output debounce fix (resolves esphome/issues#4402) (#4672)

Browse source
This commit is contained in:
tracestep 2023-10-25 23:36:58 -03:00 committed by GitHub
parent 8b9a7608f0
commit 6b8a75d3b8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
esphome/components/sx1509/sx1509.cpp
View file

@ -68,9 +68,18 @@ void SX1509Component::digital_write(uint8_t pin, bool bit_value) {
uint16_t temp_reg_data = 0; uint16_t temp_reg_data = 0;
this->read_byte_16(REG_DATA_B, &temp_reg_data); this->read_byte_16(REG_DATA_B, &temp_reg_data);
if (bit_value) { if (bit_value) {
temp_reg_data |= (1 << pin); output_state_ |= (1 << pin); // set bit in shadow register
} else { } else {
temp_reg_data &= ~(1 << pin); output_state_ &= ~(1 << pin); // reset bit shadow register
}
for (uint16_t b = 0x8000; b; b >>= 1) {
if ((~ddr_mask_) & b) { // transfer bits of outputs, but don't mess with inputs
if (output_state_ & b) {
temp_reg_data |= b;
} else {
temp_reg_data &= ~b;
}
}
} }
this->write_byte_16(REG_DATA_B, temp_reg_data); this->write_byte_16(REG_DATA_B, temp_reg_data);
} }
@ -134,6 +143,7 @@ void SX1509Component::setup_led_driver(uint8_t pin) {
this->read_byte_16(REG_DATA_B, &temp_word); this->read_byte_16(REG_DATA_B, &temp_word);
temp_word &= ~(1 << pin); temp_word &= ~(1 << pin);
output_state_ &= ~(1 << pin);
this->write_byte_16(REG_DATA_B, temp_word); this->write_byte_16(REG_DATA_B, temp_word);
} }

1
esphome/components/sx1509/sx1509.h
View file

@ -61,6 +61,7 @@ class SX1509Component : public Component, public i2c::I2CDevice {
uint16_t ddr_mask_ = 0x00; uint16_t ddr_mask_ = 0x00;
uint16_t input_mask_ = 0x00; uint16_t input_mask_ = 0x00;
uint16_t port_mask_ = 0x00; uint16_t port_mask_ = 0x00;
uint16_t output_state_ = 0x00;
bool has_keypad_ = false; bool has_keypad_ = false;
uint8_t rows_ = 0; uint8_t rows_ = 0;
uint8_t cols_ = 0; uint8_t cols_ = 0;