Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-28 09:44:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

code suggestions

Browse source
This commit is contained in:
Daniël Koek 2024-04-25 10:38:35 +01:00
parent eb3d5b8953
commit 6d4f491b49
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
esphome/components/ebyte_lora/ebyte_lora.cpp
View file

@ -270,7 +270,7 @@ bool EbyteLoraComponent::can_send_message_() {
} }
void EbyteLoraComponent::setup_wait_response_(uint32_t timeout) { void EbyteLoraComponent::setup_wait_response_(uint32_t timeout) {
if (this->starting_to_check_ != 0 || this->time_out_after_ != 0) { if (!(this->starting_to_check_ == 0) && !(this->time_out_after_ == 0)) {
ESP_LOGD(TAG, "Wait response already set!! %u", timeout); ESP_LOGD(TAG, "Wait response already set!! %u", timeout);
} }
ESP_LOGD(TAG, "Setting a timer for %u", timeout); ESP_LOGD(TAG, "Setting a timer for %u", timeout);
@ -312,12 +312,12 @@ void EbyteLoraComponent::loop() {
} }
// if it is only push info // if it is only push info
if (data[0] == SWITCH_PUSH) { if (data[0] == SWITCH_PUSH) {
ESP_LOGD(TAG, "GOT SWITCH PUSH ", data.size()); ESP_LOGD(TAG, "GOT SWITCH PUSH", data.size());
ESP_LOGD(TAG, "Total: %u ", data.size()); ESP_LOGD(TAG, "Total: %u", data.size());
ESP_LOGD(TAG, "Start bit: ", data[0]); ESP_LOGD(TAG, "Start bit: %u", data[0]);
ESP_LOGD(TAG, "PIN: %u ", data[1]); ESP_LOGD(TAG, "PIN: %u", data[1]);
ESP_LOGD(TAG, "VALUE: %u ", data[2]); ESP_LOGD(TAG, "VALUE: %u", data[2]);
ESP_LOGD(TAG, "RSSI: %u % ", (data[3] / 255.0) * 100); ESP_LOGD(TAG, "RSSI: %f %", (data[3] / 255.0) * 100);
if (this->rssi_sensor_ != nullptr) if (this->rssi_sensor_ != nullptr)
this->rssi_sensor_->publish_state((data[3] / 255.0) * 100); this->rssi_sensor_->publish_state((data[3] / 255.0) * 100);
@ -333,7 +333,7 @@ void EbyteLoraComponent::loop() {
if (data[0] == SWITCH_INFO) { if (data[0] == SWITCH_INFO) {
for (int i = 0; i < data.size(); i++) { for (int i = 0; i < data.size(); i++) {
if (data[i] == SWITCH_INFO) { if (data[i] == SWITCH_INFO) {
ESP_LOGD(TAG, "GOT INFO ", data.size()); ESP_LOGD(TAG, "GOT INFO", data.size());
uint8_t pin = data[i + 1]; uint8_t pin = data[i + 1];
bool value = data[i + 2]; bool value = data[i + 2];
for (auto *sensor : this->sensors_) { for (auto *sensor : this->sensors_) {
@ -344,7 +344,7 @@ void EbyteLoraComponent::loop() {
} }
} }
this->rssi_sensor_->publish_state((data[data.size() - 1] / 255.0) * 100); this->rssi_sensor_->publish_state((data[data.size() - 1] / 255.0) * 100);
ESP_LOGD(TAG, "RSSI: %u % ", (data[data.size() - 1] / 255.0) * 100); ESP_LOGD(TAG, "RSSI: %f %", (data[data.size() - 1] / 255.0) * 100);
} }
if (data[0] == PROGRAM_CONF) { if (data[0] == PROGRAM_CONF) {
ESP_LOGD(TAG, "GOT PROGRAM_CONF"); ESP_LOGD(TAG, "GOT PROGRAM_CONF");