Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-10 09:17:46 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Correct ADS1115 handling of multiple sensors in continuous mode (#2016)

Browse source 
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
This commit is contained in:
Sean Vig 2021-07-20 01:05:25 -04:00 committed by GitHub
parent 9b5a3cbcd3
commit 766866197b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
esphome/components/ads1115/ads1115.cpp
View file

@ -107,9 +107,13 @@ float ADS1115Component::request_measurement(ADS1115Sensor *sensor) {
} }
this->prev_config_ = config; this->prev_config_ = config;
// about 1.6 ms with 860 samples per second // about 1.2 ms with 860 samples per second
delay(2); delay(2);
// in continuous mode, conversion will always be running, rely on the delay
// to ensure conversion is taking place with the correct settings
// can we use the rdy pin to trigger when a conversion is done?
if (!this->continuous_mode_) {
uint32_t start = millis(); uint32_t start = millis();
while (this->read_byte_16(ADS1115_REGISTER_CONFIG, &config) && (config >> 15) == 0) { while (this->read_byte_16(ADS1115_REGISTER_CONFIG, &config) && (config >> 15) == 0) {
if (millis() - start > 100) { if (millis() - start > 100) {
@ -120,6 +124,7 @@ float ADS1115Component::request_measurement(ADS1115Sensor *sensor) {
yield(); yield();
} }
} }
}
uint16_t raw_conversion; uint16_t raw_conversion;
if (!this->read_byte_16(ADS1115_REGISTER_CONVERSION, &raw_conversion)) { if (!this->read_byte_16(ADS1115_REGISTER_CONVERSION, &raw_conversion)) {