From 79667d3c8cccee88554637c5a04d72e0765139b4 Mon Sep 17 00:00:00 2001 From: Tobias Marschall Date: Sat, 22 Jun 2024 19:38:18 +0000 Subject: [PATCH] Remove code that got introduced by https://github.com/esphome/esphome/pull/665 but actually has nothing to do with "has_built_in_endstop" and got added a second time as a duplicate with the "manual_control" configuration in https://github.com/esphome/esphome/pull/4249. --- esphome/components/time_based/time_based_cover.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/esphome/components/time_based/time_based_cover.cpp b/esphome/components/time_based/time_based_cover.cpp index e1936d5ee1..9bc85e79c4 100644 --- a/esphome/components/time_based/time_based_cover.cpp +++ b/esphome/components/time_based/time_based_cover.cpp @@ -88,12 +88,6 @@ void TimeBasedCover::control(const CoverCall &call) { this->target_position_ = pos; this->start_direction_(op); } - // for covers with built in end stop, we should send the command again - if (this->has_built_in_endstop_ && (pos == COVER_OPEN || pos == COVER_CLOSED)) { - auto op = pos == COVER_CLOSED ? COVER_OPERATION_CLOSING : COVER_OPERATION_OPENING; - this->target_position_ = pos; - this->start_direction_(op); - } } else { auto op = pos < this->position ? COVER_OPERATION_CLOSING : COVER_OPERATION_OPENING; if (this->manual_control_ && (pos == COVER_OPEN || pos == COVER_CLOSED)) {