Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-12-25 15:04:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix negative result calculation

Browse source
This commit is contained in:
Michael Doppler 2024-04-29 08:51:40 +00:00
parent 59cba62e20
commit 82c404c67b
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
esphome/components/mcp3428/mcp3428.cpp
View file

@ -101,17 +101,13 @@ float MCP3428Component::request_measurement(MCP3428Multiplexer multiplexer, MCP3
yield(); yield();
} }
// got valid measurement, clean up unused bits from the anwser code and prepare tick size // got valid measurement prepare tick size
float tick_voltage = 2.048f / 32768; // ref voltage 2.048V/non-sign bits, default 15 bits float tick_voltage = 2.048f / 32768; // ref voltage 2.048V/non-sign bits, default 15 bits
switch (resolution) { switch (resolution) {
case MCP3428Resolution::MCP3428_12_BITS: case MCP3428Resolution::MCP3428_12_BITS:
// Structure [sign][sign][sign][sign][sign][value][value][value], only keep sign at MSB for int16_t
anwser[0] &= 0b10000111;
tick_voltage *= 16; tick_voltage *= 16;
break; break;
case MCP3428Resolution::MCP3428_14_BITS: case MCP3428Resolution::MCP3428_14_BITS:
// Structure [sign][sign][sign][value][value][value][value][value]
anwser[0] &= 0b10011111;
tick_voltage *= 4; tick_voltage *= 4;
break; break;
default: // nothing to do for 16 bit default: // nothing to do for 16 bit