Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-09-21 01:51:23 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fixes compressed downloads (#5014)

Browse source 
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
This commit is contained in:
F.D.Castel 2023-06-27 20:13:14 -03:00 committed by Jesse Hills
parent 70de2f5278
commit 832ba38f1b
No known key found for this signature in database
GPG key ID: BEAAE804EFD8E83A
1 changed files with 4 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
esphome/dashboard/dashboard.py
View file

@ -546,22 +546,11 @@ class DownloadBinaryRequestHandler(BaseHandler):
return return
with open(path, "rb") as f: with open(path, "rb") as f:
while True: data = f.read()
# For a 528KB image used as benchmark:
# - using 256KB blocks resulted in the smallest file size.
# - blocks larger than 256KB didn't improve the size of compressed file.
# - blocks smaller than 256KB hindered compression, making the output file larger.
# Read file in blocks of 256KB.
data = f.read(256 * 1024)
if not data:
break
if compressed: if compressed:
data = gzip.compress(data, 9) data = gzip.compress(data, 9)
self.write(data) self.write(data)
self.finish() self.finish()