Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-27 09:18:00 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

[max6921] improve comments about LOAD pin usage

Browse source
This commit is contained in:
endym 2024-10-10 21:32:16 +02:00
parent 818527c55c
commit 86c06364b1
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
esphome/components/max6921/max6921.cpp
View file

@ -37,7 +37,7 @@ void MAX6921Component::dump_config() {
this->display_->dump_config(); this->display_->dump_config();
} }
/** /*
* @brief Clocks data into MAX6921 via SPI (MSB first). * @brief Clocks data into MAX6921 via SPI (MSB first).
* Data must contain 3 bytes with following format: * Data must contain 3 bytes with following format:
* bit | 23 | 22 | 21 | 20 | 19 | 18 | ... | 1 | 0 * bit | 23 | 22 | 21 | 20 | 19 | 18 | ... | 1 | 0
@ -49,13 +49,13 @@ void HOT MAX6921Component::write_data(uint8_t *ptr, size_t length) {
static bool first_call_logged = false; static bool first_call_logged = false;
assert(length == 3); assert(length == 3);
this->disable_load_(); // set LOAD to low
memcpy(data, ptr, sizeof(data)); // make copy of data, because transfer buffer will be overwritten with SPI answer memcpy(data, ptr, sizeof(data)); // make copy of data, because transfer buffer will be overwritten with SPI answer
if (!first_call_logged) if (!first_call_logged)
ESP_LOGVV(TAG, "SPI(%u): 0x%02x%02x%02x", length, data[0], data[1], data[2]); ESP_LOGVV(TAG, "SPI(%u): 0x%02x%02x%02x", length, data[0], data[1], data[2]);
first_call_logged = true; first_call_logged = true;
this->disable_load_(); // set LOAD to low to disable update of output latch during data transfer
this->transfer_array(data, sizeof(data)); this->transfer_array(data, sizeof(data));
this->enable_load_(); // set LOAD to high to update output latch this->enable_load_(); // set LOAD to high to update the output latch (transparent to the shift register)
} }
void MAX6921Component::update() { void MAX6921Component::update() {