Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-09-19 17:17:32 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

[st7701s] Fix initialisation race (#7462)
Some checks are pending
CI / Create common environment (push) Waiting to run
Details
CI / Check black (push) Blocked by required conditions
Details
CI / Check flake8 (push) Blocked by required conditions
Details
CI / Check pylint (push) Blocked by required conditions
Details
CI / Check pyupgrade (push) Blocked by required conditions
Details
CI / Run script/ci-custom (push) Blocked by required conditions
Details
CI / Run pytest (push) Blocked by required conditions
Details
CI / Check clang-format (push) Blocked by required conditions
Details
CI / Run script/clang-tidy for ESP32 Arduino 1/4 (push) Blocked by required conditions
Details
CI / Run script/clang-tidy for ESP32 Arduino 2/4 (push) Blocked by required conditions
Details
CI / Run script/clang-tidy for ESP32 Arduino 3/4 (push) Blocked by required conditions
Details
CI / Run script/clang-tidy for ESP32 Arduino 4/4 (push) Blocked by required conditions
Details
CI / Run script/clang-tidy for ESP32 IDF (push) Blocked by required conditions
Details
CI / Run script/clang-tidy for ESP8266 (push) Blocked by required conditions
Details
CI / list-components (push) Blocked by required conditions
Details
CI / Component test (push) Blocked by required conditions
Details
CI / Split components for testing into 20 groups maximum (push) Blocked by required conditions
Details
CI / Test split components (push) Blocked by required conditions
Details
CI / CI Status (push) Blocked by required conditions
Details
YAML lint / yamllint (push) Waiting to run
Details

Browse source
This commit is contained in:
Clyde Stubbs 2024-09-19 14:18:51 +10:00 committed by GitHub
parent fb7e7eb80b
commit 8e5d7337c8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
esphome/components/st7701s/st7701s.cpp
View file

@ -9,14 +9,6 @@ void ST7701S::setup() {
esph_log_config(TAG, "Setting up ST7701S");
this->spi_setup();
this->write_init_sequence_();
}
// called after a delay after writing the init sequence
void ST7701S::complete_setup_() {
this->write_command_(SLEEP_OUT);
this->write_command_(DISPLAY_ON);
this->spi_teardown(); // SPI not needed after this
delay(10);
esp_lcd_rgb_panel_config_t config{};
config.flags.fb_in_psram = 1;
@ -179,7 +171,12 @@ void ST7701S::write_init_sequence_() {
this->write_data_(val);
ESP_LOGD(TAG, "write MADCTL %X", val);
this->write_command_(this->invert_colors_ ? INVERT_ON : INVERT_OFF);
this->set_timeout(120, [this] { this->complete_setup_(); });
// can't avoid this inline delay due to the need to complete setup before anything else tries to draw.
delay(120); // NOLINT
this->write_command_(SLEEP_OUT);
this->write_command_(DISPLAY_ON);
this->spi_teardown(); // SPI not needed after this
delay(10);
}
void ST7701S::dump_config() {