diff --git a/esphome/components/optolink/datapoint_component.cpp b/esphome/components/optolink/datapoint_component.cpp index c059ec68a5..b228fd67c8 100644 --- a/esphome/components/optolink/datapoint_component.cpp +++ b/esphome/components/optolink/datapoint_component.cpp @@ -157,7 +157,7 @@ void DatapointComponent::datapoint_value_changed(uint32_t value) { ESP_LOGW(TAG, "unused value update by sensor %s", get_component_name().c_str()); } -void DatapointComponent::datapoint_value_changed(std::string value) { +void DatapointComponent::datapoint_value_changed(const std::string &value) { ESP_LOGW(TAG, "unused value update by sensor %s", get_component_name().c_str()); } @@ -266,7 +266,7 @@ void DatapointComponent::subscribe_hass_(const std::string &entity_id, const std return; } } - HassSubscription subscription{entity_id}; + HassSubscription subscription{entity_id, ""}; subscription.callbacks.push_back(f); hass_subscriptions_.push_back(subscription); diff --git a/esphome/components/optolink/datapoint_component.h b/esphome/components/optolink/datapoint_component.h index acc591738e..ca926a5e8d 100644 --- a/esphome/components/optolink/datapoint_component.h +++ b/esphome/components/optolink/datapoint_component.h @@ -42,7 +42,7 @@ class DatapointComponent { virtual void datapoint_value_changed(uint8_t value); virtual void datapoint_value_changed(uint16_t value); virtual void datapoint_value_changed(uint32_t value); - virtual void datapoint_value_changed(std::string value); + virtual void datapoint_value_changed(const std::string &value); virtual void datapoint_value_changed(uint8_t *value, size_t length); void write_datapoint_value_(float value); diff --git a/esphome/components/optolink/select/optolink_select.cpp b/esphome/components/optolink/select/optolink_select.cpp index 6e01decbed..66d99c0e1f 100644 --- a/esphome/components/optolink/select/optolink_select.cpp +++ b/esphome/components/optolink/select/optolink_select.cpp @@ -23,7 +23,7 @@ void OptolinkSelect::control(const std::string &value) { } }; -void OptolinkSelect::datapoint_value_changed(std::string value) { +void OptolinkSelect::datapoint_value_changed(const std::string &value) { auto pos = mapping_->find(value); if (pos == mapping_->end()) { set_optolink_state_("value %s not found in select %s", value.c_str(), get_component_name().c_str()); diff --git a/esphome/components/optolink/select/optolink_select.h b/esphome/components/optolink/select/optolink_select.h index 33d705cbe0..ec3a49daa6 100644 --- a/esphome/components/optolink/select/optolink_select.h +++ b/esphome/components/optolink/select/optolink_select.h @@ -29,7 +29,7 @@ class OptolinkSelect : public DatapointComponent, public esphome::select::Select void control(const std::string &value) override; const StringRef &get_component_name() override { return get_name(); } - void datapoint_value_changed(std::string value) override; + void datapoint_value_changed(const std::string &value) override; void datapoint_value_changed(uint8_t value) override; void datapoint_value_changed(uint16_t value) override; void datapoint_value_changed(uint32_t value) override; diff --git a/esphome/components/optolink/text_sensor/optolink_text_sensor.cpp b/esphome/components/optolink/text_sensor/optolink_text_sensor.cpp index d146871e23..07628c7493 100644 --- a/esphome/components/optolink/text_sensor/optolink_text_sensor.cpp +++ b/esphome/components/optolink/text_sensor/optolink_text_sensor.cpp @@ -34,6 +34,7 @@ uint8_t *encode_time_string(const std::string &input) { char *token = strtok(buffer, " "); while (token && time_count < 8) { Time current_time; + // NOLINTNEXTLINE if (sscanf(token, "%d:%d", ¤t_time.hours, ¤t_time.minutes) == 2) { if (check_time_values(current_time) && check_time_sequence(prev_time, current_time)) { time_values[time_count++] = current_time;