Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-25 16:38:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Fix PIDController::in_deadband() to give correct result when error is zero (#5078)

Browse source
This commit is contained in:
Lewis Baker 2023-07-13 06:27:45 +09:30 committed by GitHub
parent a539197bc4
commit 9344d85414
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
esphome/components/pid/pid_controller.cpp
View file

@ -29,7 +29,7 @@ float PIDController::update(float setpoint, float process_value) {
bool PIDController::in_deadband() { bool PIDController::in_deadband() {
// return (fabs(error) < deadband_threshold); // return (fabs(error) < deadband_threshold);
float err = -error_; float err = -error_;
return ((err > 0 && err < threshold_high_) || (err < 0 && err > threshold_low_)); return (threshold_low_ < err && err < threshold_high_);
} }
void PIDController::calculate_proportional_term_() { void PIDController::calculate_proportional_term_() {