Fix regression caused by TSL2591 auto gain (#3249)

This commit is contained in:
Nicholas Peters 2022-02-21 19:53:24 -05:00 committed by Jesse Hills
parent 3d0899aa58
commit 95acf19067
No known key found for this signature in database
GPG key ID: BEAAE804EFD8E83A

View file

@ -43,16 +43,34 @@ void TSL2591Component::disable_if_power_saving_() {
} }
void TSL2591Component::setup() { void TSL2591Component::setup() {
if (this->component_gain_ == TSL2591_CGAIN_AUTO) switch (this->component_gain_) {
case TSL2591_CGAIN_LOW:
this->gain_ = TSL2591_GAIN_LOW;
break;
case TSL2591_CGAIN_MED:
this->gain_ = TSL2591_GAIN_MED; this->gain_ = TSL2591_GAIN_MED;
break;
case TSL2591_CGAIN_HIGH:
this->gain_ = TSL2591_GAIN_HIGH;
break;
case TSL2591_CGAIN_MAX:
this->gain_ = TSL2591_GAIN_MAX;
break;
case TSL2591_CGAIN_AUTO:
this->gain_ = TSL2591_GAIN_MED;
break;
}
uint8_t address = this->address_; uint8_t address = this->address_;
ESP_LOGI(TAG, "Setting up TSL2591 sensor at I2C address 0x%02X", address); ESP_LOGI(TAG, "Setting up TSL2591 sensor at I2C address 0x%02X", address);
uint8_t id; uint8_t id;
if (!this->read_byte(TSL2591_COMMAND_BIT | TSL2591_REGISTER_DEVICE_ID, &id)) { if (!this->read_byte(TSL2591_COMMAND_BIT | TSL2591_REGISTER_DEVICE_ID, &id)) {
ESP_LOGE(TAG, "Failed I2C read during setup()"); ESP_LOGE(TAG, "Failed I2C read during setup()");
this->mark_failed(); this->mark_failed();
return; return;
} }
if (id != 0x50) { if (id != 0x50) {
ESP_LOGE(TAG, ESP_LOGE(TAG,
"Could not find the TSL2591 sensor. The ID register of the device at address 0x%02X reported 0x%02X " "Could not find the TSL2591 sensor. The ID register of the device at address 0x%02X reported 0x%02X "
@ -61,6 +79,7 @@ void TSL2591Component::setup() {
this->mark_failed(); this->mark_failed();
return; return;
} }
this->set_integration_time_and_gain(this->integration_time_, this->gain_); this->set_integration_time_and_gain(this->integration_time_, this->gain_);
this->disable_if_power_saving_(); this->disable_if_power_saving_();
} }