Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-10 01:07:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Enable readability-redundant-access-specifiers check (#3096)

Browse source 
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
This commit is contained in:
Oxan van Leeuwen 2022-01-23 08:47:22 +01:00 committed by GitHub
parent b2430097f2
commit 97681d142e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 0 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.clang-tidy
View file

@ -76,7 +76,6 @@ Checks: >-
-readability-isolate-declaration, -readability-isolate-declaration,
-readability-magic-numbers, -readability-magic-numbers,
-readability-make-member-function-const, -readability-make-member-function-const,
-readability-redundant-access-specifiers,
-readability-redundant-string-init, -readability-redundant-string-init,
-readability-uppercase-literal-suffix, -readability-uppercase-literal-suffix,
-readability-use-anyofallof, -readability-use-anyofallof,

2
esphome/components/adalight/adalight_light_effect.h
View file

@ -13,7 +13,6 @@ class AdalightLightEffect : public light::AddressableLightEffect, public uart::U
public: public:
AdalightLightEffect(const std::string &name); AdalightLightEffect(const std::string &name);
public:
void start() override; void start() override;
void stop() override; void stop() override;
void apply(light::AddressableLight &it, const Color &current_color) override; void apply(light::AddressableLight &it, const Color &current_color) override;
@ -30,7 +29,6 @@ class AdalightLightEffect : public light::AddressableLightEffect, public uart::U
void blank_all_leds_(light::AddressableLight &it); void blank_all_leds_(light::AddressableLight &it);
Frame parse_frame_(light::AddressableLight &it); Frame parse_frame_(light::AddressableLight &it);
protected:
uint32_t last_ack_{0}; uint32_t last_ack_{0};
uint32_t last_byte_{0}; uint32_t last_byte_{0};
uint32_t last_reset_{0}; uint32_t last_reset_{0};

3
esphome/components/e131/e131.h
View file

@ -33,11 +33,9 @@ class E131Component : public esphome::Component {
void loop() override; void loop() override;
float get_setup_priority() const override { return setup_priority::AFTER_WIFI; } float get_setup_priority() const override { return setup_priority::AFTER_WIFI; }
public:
void add_effect(E131AddressableLightEffect *light_effect); void add_effect(E131AddressableLightEffect *light_effect);
void remove_effect(E131AddressableLightEffect *light_effect); void remove_effect(E131AddressableLightEffect *light_effect);
public:
void set_method(E131ListenMethod listen_method) { this->listen_method_ = listen_method; } void set_method(E131ListenMethod listen_method) { this->listen_method_ = listen_method; }
protected: protected:
@ -47,7 +45,6 @@ class E131Component : public esphome::Component {
void join_(int universe); void join_(int universe);
void leave_(int universe); void leave_(int universe);
protected:
E131ListenMethod listen_method_{E131_MULTICAST}; E131ListenMethod listen_method_{E131_MULTICAST};
std::unique_ptr<UDP> udp_; std::unique_ptr<UDP> udp_;
std::set<E131AddressableLightEffect *> light_effects_; std::set<E131AddressableLightEffect *> light_effects_;

4
esphome/components/e131/e131_addressable_light_effect.h
View file

@ -17,19 +17,16 @@ class E131AddressableLightEffect : public light::AddressableLightEffect {
public: public:
E131AddressableLightEffect(const std::string &name); E131AddressableLightEffect(const std::string &name);
public:
void start() override; void start() override;
void stop() override; void stop() override;
void apply(light::AddressableLight &it, const Color &current_color) override; void apply(light::AddressableLight &it, const Color &current_color) override;
public:
int get_data_per_universe() const; int get_data_per_universe() const;
int get_lights_per_universe() const; int get_lights_per_universe() const;
int get_first_universe() const; int get_first_universe() const;
int get_last_universe() const; int get_last_universe() const;
int get_universe_count() const; int get_universe_count() const;
public:
void set_first_universe(int universe) { this->first_universe_ = universe; } void set_first_universe(int universe) { this->first_universe_ = universe; }
void set_channels(E131LightChannels channels) { this->channels_ = channels; } void set_channels(E131LightChannels channels) { this->channels_ = channels; }
void set_e131(E131Component *e131) { this->e131_ = e131; } void set_e131(E131Component *e131) { this->e131_ = e131; }
@ -37,7 +34,6 @@ class E131AddressableLightEffect : public light::AddressableLightEffect {
protected: protected:
bool process_(int universe, const E131Packet &packet); bool process_(int universe, const E131Packet &packet);
protected:
int first_universe_{0}; int first_universe_{0};
int last_universe_{0}; int last_universe_{0};
E131LightChannels channels_{E131_RGB}; E131LightChannels channels_{E131_RGB};

1
esphome/components/esp32_camera_web_server/camera_web_server.h
View file

@ -36,7 +36,6 @@ class CameraWebServer : public Component {
esp_err_t streaming_handler_(struct httpd_req *req); esp_err_t streaming_handler_(struct httpd_req *req);
esp_err_t snapshot_handler_(struct httpd_req *req); esp_err_t snapshot_handler_(struct httpd_req *req);
protected:
uint16_t port_{0}; uint16_t port_{0};
void *httpd_{nullptr}; void *httpd_{nullptr};
SemaphoreHandle_t semaphore_; SemaphoreHandle_t semaphore_;

1
esphome/components/modbus_controller/text_sensor/modbus_textsensor.h
View file

@ -35,7 +35,6 @@ class ModbusTextSensor : public Component, public text_sensor::TextSensor, publi
protected: protected:
optional<transform_func_t> transform_func_{nullopt}; optional<transform_func_t> transform_func_{nullopt};
protected:
RawEncoding encode_; RawEncoding encode_;
}; };

1
esphome/components/mqtt/mqtt_component.h
View file

@ -186,7 +186,6 @@ class MQTTComponent : public Component {
/// Generate the Home Assistant MQTT discovery object id by automatically transforming the friendly name. /// Generate the Home Assistant MQTT discovery object id by automatically transforming the friendly name.
std::string get_default_object_id_() const; std::string get_default_object_id_() const;
protected:
std::string custom_state_topic_{}; std::string custom_state_topic_{};
std::string custom_command_topic_{}; std::string custom_command_topic_{};
bool retain_{true}; bool retain_{true};

2
esphome/components/wled/wled_light_effect.h
View file

@ -17,7 +17,6 @@ class WLEDLightEffect : public light::AddressableLightEffect {
public: public:
WLEDLightEffect(const std::string &name); WLEDLightEffect(const std::string &name);
public:
void start() override; void start() override;
void stop() override; void stop() override;
void apply(light::AddressableLight &it, const Color &current_color) override; void apply(light::AddressableLight &it, const Color &current_color) override;
@ -32,7 +31,6 @@ class WLEDLightEffect : public light::AddressableLightEffect {
bool parse_drgbw_frame_(light::AddressableLight &it, const uint8_t *payload, uint16_t size); bool parse_drgbw_frame_(light::AddressableLight &it, const uint8_t *payload, uint16_t size);
bool parse_dnrgb_frame_(light::AddressableLight &it, const uint8_t *payload, uint16_t size); bool parse_dnrgb_frame_(light::AddressableLight &it, const uint8_t *payload, uint16_t size);
protected:
uint16_t port_{0}; uint16_t port_{0};
std::unique_ptr<UDP> udp_; std::unique_ptr<UDP> udp_;
uint32_t blank_at_{0}; uint32_t blank_at_{0};