Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-30 02:34:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Fix checksum calculation for sml (#5271)

Browse source
This commit is contained in:
Mat931 2023-08-17 19:57:18 +00:00 committed by Jesse Hills
parent a35122231c
commit b566c78f00
No known key found for this signature in database
GPG key ID: BEAAE804EFD8E83A
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
esphome/components/sml/sml.cpp
View file

@ -100,14 +100,14 @@ bool check_sml_data(const bytes &buffer) {
} }
uint16_t crc_received = (buffer.at(buffer.size() - 2) << 8) | buffer.at(buffer.size() - 1); uint16_t crc_received = (buffer.at(buffer.size() - 2) << 8) | buffer.at(buffer.size() - 1);
uint16_t crc_calculated = crc16(buffer.data(), buffer.size(), 0x6e23, 0x8408, true, true); uint16_t crc_calculated = crc16(buffer.data(), buffer.size() - 2, 0x6e23, 0x8408, true, true);
crc_calculated = (crc_calculated >> 8) | (crc_calculated << 8); crc_calculated = (crc_calculated >> 8) | (crc_calculated << 8);
if (crc_received == crc_calculated) { if (crc_received == crc_calculated) {
ESP_LOGV(TAG, "Checksum verification successful with CRC16/X25."); ESP_LOGV(TAG, "Checksum verification successful with CRC16/X25.");
return true; return true;
} }
crc_calculated = crc16(buffer.data(), buffer.size(), 0xed50, 0x8408); crc_calculated = crc16(buffer.data(), buffer.size() - 2, 0xed50, 0x8408);
if (crc_received == crc_calculated) { if (crc_received == crc_calculated) {
ESP_LOGV(TAG, "Checksum verification successful with CRC16/KERMIT."); ESP_LOGV(TAG, "Checksum verification successful with CRC16/KERMIT.");
return true; return true;