Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-30 10:44:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

[honeywell] use warning instead of failing (#7862)

Browse source 
Co-authored-by: Samuel Sieb <samuel@sieb.net>
This commit is contained in:
Samuel Sieb 2024-11-26 00:05:20 -10:00 committed by GitHub
parent cd1ee96606
commit be78827274
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
esphome/components/honeywellabp2_i2c/honeywellabp2.cpp
View file

@ -15,7 +15,7 @@ static const char *const TAG = "honeywellabp2";
void HONEYWELLABP2Sensor::read_sensor_data() { void HONEYWELLABP2Sensor::read_sensor_data() {
if (this->read(raw_data_, 7) != i2c::ERROR_OK) { if (this->read(raw_data_, 7) != i2c::ERROR_OK) {
ESP_LOGE(TAG, "Communication with ABP2 failed!"); ESP_LOGE(TAG, "Communication with ABP2 failed!");
this->mark_failed(); this->status_set_warning("couldn't read sensor data");
return; return;
} }
float press_counts = encode_uint24(raw_data_[1], raw_data_[2], raw_data_[3]); // calculate digital pressure counts float press_counts = encode_uint24(raw_data_[1], raw_data_[2], raw_data_[3]); // calculate digital pressure counts
@ -25,12 +25,13 @@ void HONEYWELLABP2Sensor::read_sensor_data() {
(this->max_pressure_ - this->min_pressure_)) + (this->max_pressure_ - this->min_pressure_)) +
this->min_pressure_; this->min_pressure_;
this->last_temperature_ = (temp_counts * 200 / 16777215) - 50; this->last_temperature_ = (temp_counts * 200 / 16777215) - 50;
this->status_clear_warning();
} }
void HONEYWELLABP2Sensor::start_measurement() { void HONEYWELLABP2Sensor::start_measurement() {
if (this->write(i2c_cmd_, 3) != i2c::ERROR_OK) { if (this->write(i2c_cmd_, 3) != i2c::ERROR_OK) {
ESP_LOGE(TAG, "Communication with ABP2 failed!"); ESP_LOGE(TAG, "Communication with ABP2 failed!");
this->mark_failed(); this->status_set_warning("couldn't start measurement");
return; return;
} }
this->measurement_running_ = true; this->measurement_running_ = true;
@ -39,7 +40,7 @@ void HONEYWELLABP2Sensor::start_measurement() {
bool HONEYWELLABP2Sensor::is_measurement_ready() { bool HONEYWELLABP2Sensor::is_measurement_ready() {
if (this->read(raw_data_, 1) != i2c::ERROR_OK) { if (this->read(raw_data_, 1) != i2c::ERROR_OK) {
ESP_LOGE(TAG, "Communication with ABP2 failed!"); ESP_LOGE(TAG, "Communication with ABP2 failed!");
this->mark_failed(); this->status_set_warning("couldn't check measurement");
return false; return false;
} }
if ((raw_data_[0] & (0x1 << STATUS_BIT_BUSY)) > 0) { if ((raw_data_[0] & (0x1 << STATUS_BIT_BUSY)) > 0) {
@ -52,7 +53,7 @@ bool HONEYWELLABP2Sensor::is_measurement_ready() {
void HONEYWELLABP2Sensor::measurement_timeout() { void HONEYWELLABP2Sensor::measurement_timeout() {
ESP_LOGE(TAG, "Timeout!"); ESP_LOGE(TAG, "Timeout!");
this->measurement_running_ = false; this->measurement_running_ = false;
this->mark_failed(); this->status_set_warning("measurement timed out");
} }
float HONEYWELLABP2Sensor::get_pressure() { return this->last_pressure_; } float HONEYWELLABP2Sensor::get_pressure() { return this->last_pressure_; }
@ -79,7 +80,7 @@ void HONEYWELLABP2Sensor::update() {
ESP_LOGV(TAG, "Update Honeywell ABP2 Sensor"); ESP_LOGV(TAG, "Update Honeywell ABP2 Sensor");
this->start_measurement(); this->start_measurement();
this->set_timeout("meas_timeout", 50, [this] { this->measurement_timeout(); }); this->set_timeout("meas_timeout", 100, [this] { this->measurement_timeout(); });
} }
void HONEYWELLABP2Sensor::dump_config() { void HONEYWELLABP2Sensor::dump_config() {