From cfd42ea16298f234ae68f082d8b8025d5bcdc633 Mon Sep 17 00:00:00 2001 From: Otto Winter Date: Sun, 17 Nov 2019 23:28:30 +0100 Subject: [PATCH] Revert ESP32 BLE Tracker defaults (#863) Fixes https://github.com/esphome/issues/issues/824 Fixes https://github.com/esphome/issues/issues/851 --- esphome/components/esp32_ble_tracker/__init__.py | 2 +- esphome/components/esp32_ble_tracker/esp32_ble_tracker.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/esphome/components/esp32_ble_tracker/__init__.py b/esphome/components/esp32_ble_tracker/__init__.py index 3d48eafde4..ccc15eb451 100644 --- a/esphome/components/esp32_ble_tracker/__init__.py +++ b/esphome/components/esp32_ble_tracker/__init__.py @@ -82,7 +82,7 @@ CONFIG_SCHEMA = cv.Schema({ cv.Optional(CONF_SCAN_PARAMETERS, default={}): cv.All(cv.Schema({ cv.Optional(CONF_DURATION, default='5min'): cv.positive_time_period_seconds, cv.Optional(CONF_INTERVAL, default='320ms'): cv.positive_time_period_milliseconds, - cv.Optional(CONF_WINDOW, default='200ms'): cv.positive_time_period_milliseconds, + cv.Optional(CONF_WINDOW, default='30ms'): cv.positive_time_period_milliseconds, cv.Optional(CONF_ACTIVE, default=True): cv.boolean, }), validate_scan_parameters), diff --git a/esphome/components/esp32_ble_tracker/esp32_ble_tracker.cpp b/esphome/components/esp32_ble_tracker/esp32_ble_tracker.cpp index 4b67277f16..a53d61f878 100644 --- a/esphome/components/esp32_ble_tracker/esp32_ble_tracker.cpp +++ b/esphome/components/esp32_ble_tracker/esp32_ble_tracker.cpp @@ -442,8 +442,8 @@ const optional &ESPBTDevice::get_service_data_uuid() const { return t void ESP32BLETracker::dump_config() { ESP_LOGCONFIG(TAG, "BLE Tracker:"); ESP_LOGCONFIG(TAG, " Scan Duration: %u s", this->scan_duration_); - ESP_LOGCONFIG(TAG, " Scan Interval: %u ms", this->scan_interval_); - ESP_LOGCONFIG(TAG, " Scan Window: %u ms", this->scan_window_); + ESP_LOGCONFIG(TAG, " Scan Interval: %.1f ms", this->scan_interval_ * 0.625f); + ESP_LOGCONFIG(TAG, " Scan Window: %.1f ms", this->scan_window_ * 0.625f); ESP_LOGCONFIG(TAG, " Scan Type: %s", this->scan_active_ ? "ACTIVE" : "PASSIVE"); } void ESP32BLETracker::print_bt_device_info(const ESPBTDevice &device) {