Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-12-25 06:54:52 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Correct I2C::ErrorCode interpretation at read and write

Browse source
This commit is contained in:
Michael Doppler 2024-04-28 15:15:56 +00:00
parent be8a3fb078
commit d25d0a559a
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
esphome/components/mcp3428/mcp3428.cpp
View file

@ -10,7 +10,7 @@ static const char *const TAG = "mcp3426/7/8";
void MCP3428Component::setup() { void MCP3428Component::setup() {
ESP_LOGCONFIG(TAG, "Setting up MCP3426/7/8..."); ESP_LOGCONFIG(TAG, "Setting up MCP3426/7/8...");
uint8_t anwser[3]; uint8_t anwser[3];
if (!this->read(anwser, 3)) { if (this->read(anwser, 3) != i2c::ErrorCode::NO_ERROR) {
this->mark_failed(); this->mark_failed();
return; return;
} }
@ -39,7 +39,7 @@ void MCP3428Component::setup() {
} }
// leave channel at 1, gain at 1x, and resolution at 12 bit // leave channel at 1, gain at 1x, and resolution at 12 bit
if (!this->write(&config, 1)) { if (this->write(&config, 1) != i2c::ErrorCode::NO_ERROR) {
this->mark_failed(); this->mark_failed();
return; return;
} }
@ -74,7 +74,7 @@ float MCP3428Component::request_measurement(MCP3428Multiplexer multiplexer, MCP3
// If continuous mode and config (besides ready bit) are the same there is no need to upload new config, reading the // If continuous mode and config (besides ready bit) are the same there is no need to upload new config, reading the
// result is enough // result is enough
if (!((this->prev_config_ & 0b00010000) > 0 and (this->prev_config_ & 0b01111111) == (config & 0b01111111))) { if (!((this->prev_config_ & 0b00010000) > 0 and (this->prev_config_ & 0b01111111) == (config & 0b01111111))) {
if (!this->write(&config, 1)) { if (this->write(&config, 1) != i2c::ErrorCode::NO_ERROR) {
this->status_set_warning(); this->status_set_warning();
return NAN; return NAN;
} }
@ -85,7 +85,7 @@ float MCP3428Component::request_measurement(MCP3428Multiplexer multiplexer, MCP3
uint32_t start = millis(); uint32_t start = millis();
uint8_t anwser[3]; uint8_t anwser[3];
while (true) { while (true) {
if (!this->read(anwser, 3)) { if (this->read(anwser, 3) != i2c::ErrorCode::NO_ERROR) {
this->status_set_warning(); this->status_set_warning();
return NAN; return NAN;
} }