Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-27 09:18:00 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Described logic in comments

Browse source
This commit is contained in:
Anton Sergunov 2024-08-19 11:58:32 +06:00 committed by GitHub
parent 648fdba4f1
commit d426cae2f3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
esphome/components/sntp/sntp_component.cpp
View file

@ -38,6 +38,8 @@ void SNTPComponent::setup() {
} }
} }
#ifdef USE_ESP_IDF #ifdef USE_ESP_IDF
// Stop the puller to prevent periodically update calls. IDF Handles periodic updates by itself.
// The user still able to call `update` to trigger manual update.
this->stop_poller(); this->stop_poller();
esp_sntp_set_sync_interval(this->get_update_interval()); esp_sntp_set_sync_interval(this->get_update_interval());
#endif #endif
@ -105,6 +107,11 @@ void SNTPComponent::loop() {
this->time_sync_callback_.call(); this->time_sync_callback_.call();
} }
#if defined(USE_ESP_IDF) #if defined(USE_ESP_IDF)
/**
Sets the update interval calling `sntp_set_sync_interval()`.
Calls `sntp_restart()` if update interval is less then it was before as ESP IDF according documentation. Without this cal interval will be updated only after previously scheduled update.
*/
void SNTPComponent::set_update_interval(uint32_t update_interval) { void SNTPComponent::set_update_interval(uint32_t update_interval) {
const auto previous_sync_interval = sntp_get_sync_interval(); const auto previous_sync_interval = sntp_get_sync_interval();
@ -116,6 +123,9 @@ void SNTPComponent::set_update_interval(uint32_t update_interval) {
sntp_restart(); sntp_restart();
} }
} }
/**
Redirects the call to `sntp_get_sync_interval()` so it's only one source of truth.
*/
uint32_t SNTPComponent::get_update_interval() const { return sntp_get_sync_interval(); } uint32_t SNTPComponent::get_update_interval() const { return sntp_get_sync_interval(); }
#endif // defined(USE_ESP_IDF) #endif // defined(USE_ESP_IDF)
void SNTPComponent::setup_servers_() { void SNTPComponent::setup_servers_() {