Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-25 16:38:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Fix repeat.count = 0 case (#5364)

Browse source 
* Only play first action if count is non-zero

* Add test to  yaml

* Update test5.yaml
This commit is contained in:
Péter Sárközi 2023-09-08 23:10:20 +02:00 committed by GitHub
parent 2fd6942de4
commit d9523a0cbf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
esphome/core/base_automation.h
View file

@ -249,7 +249,11 @@ template<typename... Ts> class RepeatAction : public Action<Ts...> {
void play_complex(Ts... x) override { void play_complex(Ts... x) override {
this->num_running_++; this->num_running_++;
this->var_ = std::make_tuple(x...); this->var_ = std::make_tuple(x...);
this->then_.play(0, x...); if (this->count_.value(x...) > 0) {
this->then_.play(0, x...);
} else {
this->play_next_tuple_(this->var_);
}
} }
void play(Ts... x) override { /* ignore - see play_complex */ void play(Ts... x) override { /* ignore - see play_complex */

7
tests/test5.yaml
View file

@ -563,6 +563,13 @@ script:
then: then:
- logger.log: looping! - logger.log: looping!
- id: zero_repeat_test
then:
- repeat:
count: !lambda "return 0;"
then:
- logger.log: shouldn't see mee!
switch: switch:
- platform: modbus_controller - platform: modbus_controller
modbus_controller_id: modbus_controller_test modbus_controller_id: modbus_controller_test