Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-23 15:38:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Defer the stop_pollercall from setup. Call get_update_interval from the base class.

Browse source
This commit is contained in:
Anton Sergunov 2024-08-19 06:28:46 +00:00
parent d426cae2f3
commit df801778b3
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
esphome/components/sntp/sntp_component.cpp
View file

@ -38,10 +38,13 @@ void SNTPComponent::setup() {
} }
} }
#ifdef USE_ESP_IDF #ifdef USE_ESP_IDF
// Stop the puller to prevent periodically update calls. IDF Handles periodic updates by itself. // We can't call `stop_poller` here because it will be started after `setup` call. So defer the execution.
// The user still able to call `update` to trigger manual update. this->defer([this] {
this->stop_poller(); // Stop the puller to prevent periodically update calls. IDF Handles periodic updates by itself.
esp_sntp_set_sync_interval(this->get_update_interval()); // The user still able to call `update` to trigger manual update.
this->stop_poller();
});
esp_sntp_set_sync_interval(time::RealTimeClock::get_update_interval());
#endif #endif
sntp_init(); sntp_init();
@ -110,7 +113,8 @@ void SNTPComponent::loop() {
/** /**
Sets the update interval calling `sntp_set_sync_interval()`. Sets the update interval calling `sntp_set_sync_interval()`.
Calls `sntp_restart()` if update interval is less then it was before as ESP IDF according documentation. Without this cal interval will be updated only after previously scheduled update. Calls `sntp_restart()` if update interval is less then it was before as ESP IDF according documentation. Without this
cal interval will be updated only after previously scheduled update.
*/ */
void SNTPComponent::set_update_interval(uint32_t update_interval) { void SNTPComponent::set_update_interval(uint32_t update_interval) {
const auto previous_sync_interval = sntp_get_sync_interval(); const auto previous_sync_interval = sntp_get_sync_interval();