Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-24 07:58:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

lint

Browse source
This commit is contained in:
oarcher 2024-07-17 14:41:27 +02:00
parent 671c71c406
commit eb37215e9f
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
esphome/components/modem/modem_component.cpp
View file

@ -206,7 +206,7 @@ void ModemComponent::start_connect_() {
if (!this->pin_code_.empty()) { if (!this->pin_code_.empty()) {
ESP_LOGV(TAG, "Set pin code: %s", this->pin_code_.c_str()); ESP_LOGV(TAG, "Set pin code: %s", this->pin_code_.c_str());
this->dce->set_pin(this->pin_code_); this->dce->set_pin(this->pin_code_);
delay(this->command_delay); // NOLINT delay(this->command_delay_); // NOLINT
} }
if (this->dce->read_pin(pin_ok) == command_result::OK && !pin_ok) { if (this->dce->read_pin(pin_ok) == command_result::OK && !pin_ok) {
ESP_LOGE(TAG, "Invalid PIN"); ESP_LOGE(TAG, "Invalid PIN");
@ -230,7 +230,7 @@ void ModemComponent::start_connect_() {
// send initial AT commands from yaml // send initial AT commands from yaml
for (const auto &cmd : this->init_at_commands_) { for (const auto &cmd : this->init_at_commands_) {
std::string result = this->send_at(cmd.c_str()); std::string result = this->send_at(cmd);
if (result == "ERROR") { if (result == "ERROR") {
ESP_LOGE(TAG, "Error while executing 'init_at' '%s' command", cmd.c_str()); ESP_LOGE(TAG, "Error while executing 'init_at' '%s' command", cmd.c_str());
} else { } else {
@ -342,7 +342,7 @@ std::string ModemComponent::send_at(const std::string &cmd) {
std::string result; std::string result;
bool status; bool status;
ESP_LOGV(TAG, "Sending command: %s", cmd.c_str()); ESP_LOGV(TAG, "Sending command: %s", cmd.c_str());
status = this->dce->at(cmd, result, this->command_delay) == esp_modem::command_result::OK; status = this->dce->at(cmd, result, this->command_delay_) == esp_modem::command_result::OK;
ESP_LOGV(TAG, "Result for command %s: %s (status %d)", cmd.c_str(), result.c_str(), status); ESP_LOGV(TAG, "Result for command %s: %s (status %d)", cmd.c_str(), result.c_str(), status);
if (!status) { if (!status) {
result = "ERROR"; result = "ERROR";

2
esphome/components/modem/modem_component.h
View file

@ -89,7 +89,7 @@ class ModemComponent : public Component {
static void got_ip_event_handler(void *arg, esp_event_base_t event_base, int32_t event_id, void *event_data); static void got_ip_event_handler(void *arg, esp_event_base_t event_base, int32_t event_id, void *event_data);
void dump_connect_params_(); void dump_connect_params_();
std::string use_address_; std::string use_address_;
uint32_t command_delay = 500; uint32_t command_delay_ = 500;
CallbackManager<void()> on_not_responding_callback_; CallbackManager<void()> on_not_responding_callback_;
}; };