Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-29 10:14:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Fix percentage validation for wrong data type input (#3524)

Browse source 
Co-authored-by: Maurice Makaay <mmakaay1@xs4all.net>
This commit is contained in:
Maurice Makaay 2022-06-07 13:00:27 +02:00 committed by GitHub
parent 31c4551890
commit ebca936b7e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
esphome/config_validation.py
View file

@ -1086,16 +1086,21 @@ def possibly_negative_percentage(value):
except ValueError: except ValueError:
# pylint: disable=raise-missing-from # pylint: disable=raise-missing-from
raise Invalid("invalid number") raise Invalid("invalid number")
if value > 1: try:
msg = "Percentage must not be higher than 100%." if value > 1:
if not has_percent_sign: msg = "Percentage must not be higher than 100%."
msg += " Please put a percent sign after the number!" if not has_percent_sign:
raise Invalid(msg) msg += " Please put a percent sign after the number!"
if value < -1: raise Invalid(msg)
msg = "Percentage must not be smaller than -100%." if value < -1:
if not has_percent_sign: msg = "Percentage must not be smaller than -100%."
msg += " Please put a percent sign after the number!" if not has_percent_sign:
raise Invalid(msg) msg += " Please put a percent sign after the number!"
raise Invalid(msg)
except TypeError:
raise Invalid( # pylint: disable=raise-missing-from
"Expected percentage or float between -1.0 and 1.0"
)
return negative_one_to_one_float(value) return negative_one_to_one_float(value)