Home-IoT/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-10 01:07:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Suppress first rotary encoder event (#3532)

Browse source 
Co-authored-by: Maurice Makaay <mmakaay1@xs4all.net>
This commit is contained in:
Maurice Makaay 2022-06-07 01:36:54 +02:00 committed by GitHub
parent dd24ffa24e
commit f8969605e8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
esphome/components/rotary_encoder/rotary_encoder.cpp
View file

@ -103,7 +103,7 @@ void IRAM_ATTR HOT RotaryEncoderSensorStore::gpio_intr(RotaryEncoderSensorStore
rotation_dir = -1; rotation_dir = -1;
} }
if (rotation_dir != 0) { if (rotation_dir != 0 && !arg->first_read) {
auto *first_zero = std::find(arg->rotation_events.begin(), arg->rotation_events.end(), 0); // find first zero auto *first_zero = std::find(arg->rotation_events.begin(), arg->rotation_events.end(), 0); // find first zero
if (first_zero == arg->rotation_events.begin() // are we at the start (first event this loop iteration) if (first_zero == arg->rotation_events.begin() // are we at the start (first event this loop iteration)
|| std::signbit(*std::prev(first_zero)) != || std::signbit(*std::prev(first_zero)) !=
@ -119,6 +119,7 @@ void IRAM_ATTR HOT RotaryEncoderSensorStore::gpio_intr(RotaryEncoderSensorStore
*std::prev(first_zero) += rotation_dir; // store the rotation into the previous slot *std::prev(first_zero) += rotation_dir; // store the rotation into the previous slot
} }
} }
arg->first_read = false;
arg->state = new_state; arg->state = new_state;
} }

1
esphome/components/rotary_encoder/rotary_encoder.h
View file

@ -34,6 +34,7 @@ struct RotaryEncoderSensorStore {
int32_t max_value{INT32_MAX}; int32_t max_value{INT32_MAX};
int32_t last_read{0}; int32_t last_read{0};
uint8_t state{0}; uint8_t state{0};
bool first_read{true};
std::array<int8_t, 8> rotation_events{}; std::array<int8_t, 8> rotation_events{};
bool rotation_events_overflow{false}; bool rotation_events_overflow{false};