My Home-IoT
Find a file
Andrew Zaborowski 2f07225984
Fix: Component script not stopped in certain situations (#1004)
* Move stop/is_running implementation to Action base class

Try to fix issue #1105.  Until now if an UpdateComponentAction, a
LambdaAction, or any action that can contain those inside their
"else" or "then" action lists, resulted in a call to script.stop on
the script that contains them, the script would continue running,
because they didn't implement a stop() method.  Basically only
the asynchronous ones did: DelayAction, WaitUntilAction and
ScriptWaitAction.

With this change num_running_ in Action replaces
DelayAction::num_running_ and WaitUntilAction::triggered_ to provide
the same is_running logic to other actions.

* Make some Action methods protected

Apparently play()/stop() etc. are not meant to be called directly by
users of the class and if they're called directly that would not give
the expected result for the classes that have an empty play().

Make all methods except play_complex, stop_comples and is_running
protected.  While there also make RemoteTransmitterActionBase::encode
protected.

* lint

* format

Co-authored-by: Guillermo Ruffino <glm.net@gmail.com>
2020-06-28 19:44:15 -03:00
.devcontainer Add lambda to devcontainer config (#1059) 2020-05-19 21:02:10 -03:00
.github Add stale probot 2019-11-01 11:50:36 +01:00
docker Update docker base image (#1093) 2020-06-13 19:51:43 -03:00
esphome Fix: Component script not stopped in certain situations (#1004) 2020-06-28 19:44:15 -03:00
script test disable no delay (#1026) 2020-04-30 23:00:57 -03:00
tests Vl53 long range (#1055) 2020-06-28 18:47:43 -03:00
.clang-format 🏗 Merge C++ into python codebase (#504) 2019-04-17 12:06:00 +02:00
.clang-tidy 🏗 Merge C++ into python codebase (#504) 2019-04-17 12:06:00 +02:00
.coveragerc Unittests for esphome python code (#931) 2020-03-12 14:27:22 -07:00
.dockerignore Fix docker build 2018-09-25 10:30:45 +02:00
.editorconfig Create .editorconfig (#524) 2019-05-08 15:37:18 +02:00
.gitignore Adding support for MAX31856 Thermocouple Temperature Sensor (feature #700) (#1039) 2020-05-24 19:33:59 -03:00
.gitlab-ci.yml Update docker base image (#1093) 2020-06-13 19:51:43 -03:00
.gitpod.yml extract and use current version of python 3 (#938) 2020-01-09 13:27:39 -08:00
.pre-commit-config.yaml Bugfix/normalize core comparisons (and Python 3 update fixes) (#952) 2020-01-13 14:35:55 -08:00
.travis.yml Add support for additional Xiaomi BLE sensors (#1027) (#1027) 2020-05-26 19:33:28 -03:00
CODE_OF_CONDUCT.md Add Code of Conduct (Contributor Covenant) (#168) 2018-10-12 11:26:26 +02:00
CONTRIBUTING.md Rename esphomeyaml to esphome (#426) 2019-02-13 16:54:02 +01:00
LICENSE 🏗 Merge C++ into python codebase (#504) 2019-04-17 12:06:00 +02:00
MANIFEST.in Vl53l0x (#644) 2019-10-20 17:56:57 +02:00
platformio.ini Upgrade dependencies 2020-05-23 20:33:58 -03:00
pylintrc Drop Python 2 Support (#793) 2019-12-07 18:28:55 +01:00
pytest.ini Unittests for esphome python code (#931) 2020-03-12 14:27:22 -07:00
README.md Update README.md 2019-02-14 13:49:22 +01:00
requirements.txt Upgrade dependencies 2020-05-23 20:33:58 -03:00
requirements_test.txt Upgrade dependencies 2020-05-23 20:33:58 -03:00
setup.cfg Bugfix/normalize core comparisons (and Python 3 update fixes) (#952) 2020-01-13 14:35:55 -08:00
setup.py Upgrade dependencies 2020-05-23 20:33:58 -03:00

ESPHome Build Status Discord Chat GitHub release

ESPHome Logo

Documentation: https://esphome.io/

For issues, please go to the issue tracker.

For feature requests, please see feature requests.