mirror of
https://git.notmuchmail.org/git/notmuch
synced 2024-11-30 14:44:11 +01:00
90 lines
4 KiB
Text
90 lines
4 KiB
Text
|
From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
|
||
|
|
Subject: Re: [RFC][PATCH 05/10] cifs: define superblock-level cache index
|
||
|
|
objects and register them
|
||
|
|
Date: Mon, 28 Jun 2010 18:23:13 +0530
|
||
|
|
Lines: 48
|
||
|
|
Message-ID: <4C289B39.4060901@suse.de>
|
||
|
|
References: <22746.1277470713@redhat.com> <4C24A4A0.90408@suse.de> <1277220206-3559-1-git-send-email-sjayaraman@suse.de> <yes> <9720.1277312290@redhat.com> <23204.1277472412@redhat.com>
|
||
|
|
Mime-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 7bit
|
||
|
|
Cc: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
|
||
|
|
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
|
||
|
|
To: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
|
||
|
|
X-From: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Mon Jun 28 14:53:24 2010
|
||
|
|
Return-path: <linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
|
||
|
|
Envelope-to: glkc-linux-cifs-1dZseelyfdZg9hUCZPvPmw@public.gmane.org
|
||
|
|
Received: from vger.kernel.org ([209.132.180.67])
|
||
|
|
by lo.gmane.org with esmtp (Exim 4.69)
|
||
|
|
(envelope-from <linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>)
|
||
|
|
id 1OTDq0-00054Q-At
|
||
|
|
for glkc-linux-cifs-1dZseelyfdZg9hUCZPvPmw@public.gmane.org; Mon, 28 Jun 2010 14:53:24 +0200
|
||
|
|
Received: (majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org) by vger.kernel.org via listexpand
|
||
|
|
id S1754503Ab0F1MxX (ORCPT <rfc822;glkc-linux-cifs@m.gmane.org>);
|
||
|
|
Mon, 28 Jun 2010 08:53:23 -0400
|
||
|
|
Received: from cantor2.suse.de ([195.135.220.15]:48374 "EHLO mx2.suse.de"
|
||
|
|
rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
|
||
|
|
id S1754456Ab0F1MxW (ORCPT <rfc822;linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>);
|
||
|
|
Mon, 28 Jun 2010 08:53:22 -0400
|
||
|
|
Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2])
|
||
|
|
by mx2.suse.de (Postfix) with ESMTP id 7BDC18672B;
|
||
|
|
Mon, 28 Jun 2010 14:53:21 +0200 (CEST)
|
||
|
|
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.1.1 Thunderbird/3.0
|
||
|
|
In-Reply-To: <23204.1277472412-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
|
||
|
|
Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
|
||
|
|
Precedence: bulk
|
||
|
|
List-ID: <linux-cifs.vger.kernel.org>
|
||
|
|
X-Mailing-List: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
|
||
|
|
Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1003530>
|
||
|
|
|
||
|
|
On 06/25/2010 06:56 PM, David Howells wrote:
|
||
|
|
> David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
|
||
|
|
>
|
||
|
|
>>>> validate the root directory of the share in some way?
|
||
|
|
>>>
|
||
|
|
>>> I don't know if there is a way to do this.
|
||
|
|
>>
|
||
|
|
>> Is there an inode number or something? Even the creation time might do.
|
||
|
|
>
|
||
|
|
> Looking in cifspdu.h, there are a number of things that it might be possible
|
||
|
|
> to use.
|
||
|
|
>
|
||
|
|
> (1) FILE_ALL_INFO: CreationTime, IndexNumber, IndexNumber1, FileName
|
||
|
|
> (assuming this isn't flattened to '\' or something for the root of a
|
||
|
|
> share.
|
||
|
|
>
|
||
|
|
> (2) FILE_UNIX_BASIC_INFO: DevMajor, DevMinor, UniqueId.
|
||
|
|
>
|
||
|
|
> (3) FILE_INFO_STANDARD: CreationDate, CreationTime.
|
||
|
|
>
|
||
|
|
> (4) FILE_INFO_BASIC: CreationTime.
|
||
|
|
>
|
||
|
|
> (5) FILE_DIRECTORY_INFO: FileIndex, CreationTime, FileName.
|
||
|
|
>
|
||
|
|
> (6) SEARCH_ID_FULL_DIR_INFO: FileIndex, CreationTime, UniqueId, FileName.
|
||
|
|
>
|
||
|
|
> (7) FILE_BOTH_DIRECTORY_INFO: FileIndex, CreationTime, ShortName, FileName.
|
||
|
|
>
|
||
|
|
> (8) OPEN_RSP_EXT: Fid, CreationTime, VolumeGUID, FileId.
|
||
|
|
>
|
||
|
|
> You may have to choose different sets of things, depending on what the server
|
||
|
|
> has on offer. Also, don't forget, if you can't work out whether a share is
|
||
|
|
|
||
|
|
Did you mean we need to validate differently for different servers?
|
||
|
|
|
||
|
|
I just did some testing and it looks like we could rely on CreationTime,
|
||
|
|
IndexNumber for validating with Windows servers (FileName is relative to
|
||
|
|
the mapped drive) and UniqueId for validating with Samba servers. I did
|
||
|
|
not test all possibilities (there could be more).
|
||
|
|
|
||
|
|
> coherent or not from the above, you can always use LastWriteTime, ChangeTime
|
||
|
|
> and EndOfFile and just discard the whole subtree if they differ.
|
||
|
|
>
|
||
|
|
|
||
|
|
Thanks,
|
||
|
|
|
||
|
|
--
|
||
|
|
Suresh Jayaraman
|
||
|
|
|
||
|
|
|