mirror of
https://git.notmuchmail.org/git/notmuch
synced 2024-11-27 13:17:56 +01:00
91 lines
4.1 KiB
Text
91 lines
4.1 KiB
Text
|
From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
|
||
|
|
Subject: Re: [RFC][PATCH 10/10] cifs: add mount option to enable local caching
|
||
|
|
Date: Fri, 25 Jun 2010 16:18:12 +0530
|
||
|
|
Lines: 47
|
||
|
|
Message-ID: <4C24896C.4000903@suse.de>
|
||
|
|
References: <yes> <1277220309-3757-1-git-send-email-sjayaraman@suse.de> <4C225338.9010807@gmail.com>
|
||
|
|
Mime-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 7bit
|
||
|
|
Cc: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
|
||
|
|
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
|
||
|
|
David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
|
||
|
|
To: Scott Lovenberg <scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
|
||
|
|
X-From: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Fri Jun 25 12:48:27 2010
|
||
|
|
Return-path: <linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
|
||
|
|
Envelope-to: glkc-linux-cifs-1dZseelyfdZg9hUCZPvPmw@public.gmane.org
|
||
|
|
Received: from vger.kernel.org ([209.132.180.67])
|
||
|
|
by lo.gmane.org with esmtp (Exim 4.69)
|
||
|
|
(envelope-from <linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>)
|
||
|
|
id 1OS6SO-0003QF-NW
|
||
|
|
for glkc-linux-cifs-1dZseelyfdZg9hUCZPvPmw@public.gmane.org; Fri, 25 Jun 2010 12:48:25 +0200
|
||
|
|
Received: (majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org) by vger.kernel.org via listexpand
|
||
|
|
id S1753965Ab0FYKsX (ORCPT <rfc822;glkc-linux-cifs@m.gmane.org>);
|
||
|
|
Fri, 25 Jun 2010 06:48:23 -0400
|
||
|
|
Received: from cantor.suse.de ([195.135.220.2]:46395 "EHLO mx1.suse.de"
|
||
|
|
rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
|
||
|
|
id S1752612Ab0FYKsW (ORCPT <rfc822;linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>);
|
||
|
|
Fri, 25 Jun 2010 06:48:22 -0400
|
||
|
|
Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2])
|
||
|
|
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
|
||
|
|
(No client certificate requested)
|
||
|
|
by mx1.suse.de (Postfix) with ESMTP id 60CED6CB00;
|
||
|
|
Fri, 25 Jun 2010 12:48:21 +0200 (CEST)
|
||
|
|
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.1.1 Thunderbird/3.0
|
||
|
|
In-Reply-To: <4C225338.9010807-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
|
||
|
|
Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
|
||
|
|
Precedence: bulk
|
||
|
|
List-ID: <linux-cifs.vger.kernel.org>
|
||
|
|
X-Mailing-List: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
|
||
|
|
Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1002912>
|
||
|
|
|
||
|
|
On 06/24/2010 12:02 AM, Scott Lovenberg wrote:
|
||
|
|
> On 6/22/2010 11:25 AM, Suresh Jayaraman wrote:
|
||
|
|
>> Add a mount option 'fsc' to enable local caching on CIFS.
|
||
|
|
>>
|
||
|
|
>> As the cifs-utils (userspace) changes are not done yet, this patch
|
||
|
|
>> enables
|
||
|
|
>> 'fsc' by default to assist testing.
|
||
|
|
>>
|
||
|
|
> [...]
|
||
|
|
>> @@ -1332,6 +1336,8 @@ cifs_parse_mount_options(char *options, const
|
||
|
|
>> char *devname,
|
||
|
|
>> printk(KERN_WARNING "CIFS: Mount option noac not "
|
||
|
|
>> "supported. Instead set "
|
||
|
|
>> "/proc/fs/cifs/LookupCacheEnabled to 0\n");
|
||
|
|
>> + } else if (strnicmp(data, "fsc", 3) == 0) {
|
||
|
|
>> + vol->fsc = true;
|
||
|
|
>> } else
|
||
|
|
>> printk(KERN_WARNING "CIFS: Unknown mount option %s\n",
|
||
|
|
>> data);
|
||
|
|
>> @@ -2405,6 +2411,8 @@ static void setup_cifs_sb(struct smb_vol
|
||
|
|
>> *pvolume_info,
|
||
|
|
>> cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_OVERR_GID;
|
||
|
|
>> if (pvolume_info->dynperm)
|
||
|
|
>> cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_DYNPERM;
|
||
|
|
>> + if (pvolume_info->fsc)
|
||
|
|
>> + cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_FSCACHE;
|
||
|
|
>> if (pvolume_info->direct_io) {
|
||
|
|
>> cFYI(1, "mounting share using direct i/o");
|
||
|
|
>> cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_DIRECT_IO;
|
||
|
|
>>
|
||
|
|
> I reworked the CIFS mount option parsing a while back; I'm not sure
|
||
|
|
> whether that patch was going to be in the 2.6.35 tree or not (the window
|
||
|
|
> just opened, didn't it?).
|
||
|
|
|
||
|
|
Not a problem, I could redo this patch alone when the reworked option
|
||
|
|
parsing patches get in.
|
||
|
|
|
||
|
|
> Jeff, Steve, can you confirm if that patch is going to be in 2.6.35?
|
||
|
|
>
|
||
|
|
> Patch refs: http://patchwork.ozlabs.org/patch/53059/ and
|
||
|
|
> http://patchwork.ozlabs.org/patch/53674/
|
||
|
|
>
|
||
|
|
|
||
|
|
Thanks,
|
||
|
|
|
||
|
|
--
|
||
|
|
Suresh Jayaraman
|
||
|
|
|
||
|
|
|