debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-24 20:08:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
notmuch/Makefile.local

169 lines
5.7 KiB
Text
Raw Normal View History

notmuch: Add a version (0.1 initially) with a new --version option. We're planning to do actual releases soon, so we need a version number to put into the tar file.
2010-04-02 20:55:09 +02:00
# Here's the (hopefully simple) versioning scheme.
#
# Releases of notmuch have a two-digit version (0.1, 0.2, etc.). We
# increment the second digit for each release and increment the first
# digit when we reach particularly major milestones of usability.
#
# Between releases, (such as when compiling notmuch from the git
# repository), we add a third digit, (0.1.1, 0.1.2, etc.), and
# increment it occasionally, (such as after a big batch of commits are
# merged.
NOTMUCH_VERSION=0.1
Move bulk of rules from Makefile to Makefile.local. Before it was impossible to know whether any particular setting or rule definition was in Makefile or Makefile.local. So we strip the Makefile down to little more than the list of sub-directories and the logic to include all of the sub-directories' Makefile.local fragments. Then, all of the real work can happen inside of Makefile.local.
2010-04-01 07:12:01 +02:00
# Get settings from the output of configure by running it to generate
# Makefile.config if it doesn't exist yet. And add Makefile.config to
# our global dependency list.
include Makefile.config
global_deps += Makefile.config
Makefile.config: configure
@echo ""
@echo "Note: Calling ./configure with no command-line arguments. This is often fine,"
@echo " but if you want to specify any arguments (such as an alternate prefix"
@echo " into which to install), call ./configure explicitly and then make again."
@echo " See \"./configure --help\" for more details."
@echo ""
./configure
# Sub-directory Makefile.local fragments can append to these variables
# to have directory-specific cflags as necessary.
extra_cflags :=
extra_cxxflags :=
# Smash together user's values with our extra values
notmuch: Add a version (0.1 initially) with a new --version option. We're planning to do actual releases soon, so we need a version number to put into the tar file.
2010-04-02 20:55:09 +02:00
FINAL_CFLAGS = -DNOTMUCH_VERSION=$(NOTMUCH_VERSION) $(CFLAGS) $(WARN_CFLAGS) $(CONFIGURE_CFLAGS) $(extra_cflags)
Move bulk of rules from Makefile to Makefile.local. Before it was impossible to know whether any particular setting or rule definition was in Makefile or Makefile.local. So we strip the Makefile down to little more than the list of sub-directories and the logic to include all of the sub-directories' Makefile.local fragments. Then, all of the real work can happen inside of Makefile.local.
2010-04-01 07:12:01 +02:00
FINAL_CXXFLAGS = $(CXXFLAGS) $(WARN_CXXFLAGS) $(CONFIGURE_CXXFLAGS) $(extra_cflags) $(extra_cxxflags)
FINAL_LDFLAGS = $(LDFLAGS) $(CONFIGURE_LDFLAGS)
Compile a static notmuch binary (but only install the shared version) The idea here is to allow a new user of notmuch to be able to run notmuch immediately after compiling, (without having to install the shared library first). This also ensures that the test suite tests the locally compiled library, and not whatever installled version of the library the dynamic linker happens to find.
2010-04-02 00:03:40 +02:00
all: notmuch notmuch-shared notmuch.1.gz
Move bulk of rules from Makefile to Makefile.local. Before it was impossible to know whether any particular setting or rule definition was in Makefile or Makefile.local. So we strip the Makefile down to little more than the list of sub-directories and the logic to include all of the sub-directories' Makefile.local fragments. Then, all of the real work can happen inside of Makefile.local.
2010-04-01 07:12:01 +02:00
ifeq ($(MAKECMDGOALS),)
Makefile: Only print the "make install" hint after the first build. It was getting quite annoying to see this big block of text on every little build, (but I didn't want to get rid of it for any new users). This seems to strike the right balance.
2010-04-02 23:06:32 +02:00
ifeq ($(shell cat .first-build-message),)
@NOTMUCH_FIRST_BUILD=1 $(MAKE) --no-print-directory all
Move bulk of rules from Makefile to Makefile.local. Before it was impossible to know whether any particular setting or rule definition was in Makefile or Makefile.local. So we strip the Makefile down to little more than the list of sub-directories and the logic to include all of the sub-directories' Makefile.local fragments. Then, all of the real work can happen inside of Makefile.local.
2010-04-01 07:12:01 +02:00
@echo ""
@echo "Compilation of notmuch is now complete. You can install notmuch with:"
@echo ""
@echo " make install"
@echo ""
@echo "Note that depending on the prefix to which you are installing"
@echo "you may need root permission (such as \"sudo make install\")."
@echo "See \"./configure --help\" for help on setting an alternate prefix."
Makefile: Only print the "make install" hint after the first build. It was getting quite annoying to see this big block of text on every little build, (but I didn't want to get rid of it for any new users). This seems to strike the right balance.
2010-04-02 23:06:32 +02:00
@echo Printed > .first-build-message
endif
Move bulk of rules from Makefile to Makefile.local. Before it was impossible to know whether any particular setting or rule definition was in Makefile or Makefile.local. So we strip the Makefile down to little more than the list of sub-directories and the logic to include all of the sub-directories' Makefile.local fragments. Then, all of the real work can happen inside of Makefile.local.
2010-04-01 07:12:01 +02:00
endif
# The user has not set any verbosity, default to quiet mode and inform the
# user how to enable verbose compiles.
ifeq ($(V),)
quiet_DOC := "Use \"$(MAKE) V=1\" to see the verbose compile lines.\n"
Makefiles: Align the columns of output. Much better.
2010-04-01 09:07:08 +02:00
quiet = @printf $(quiet_DOC)$(eval quiet_DOC:=)" %12s $@\n" "$1 $2"; $($1)
quiet_args = @printf $(quiet_DOC)$(eval quiet_DOC:=)" %12s$2\n" $1; $($1) $2
Move bulk of rules from Makefile to Makefile.local. Before it was impossible to know whether any particular setting or rule definition was in Makefile or Makefile.local. So we strip the Makefile down to little more than the list of sub-directories and the logic to include all of the sub-directories' Makefile.local fragments. Then, all of the real work can happen inside of Makefile.local.
2010-04-01 07:12:01 +02:00
endif
# The user has explicitly enabled quiet compilation.
ifeq ($(V),0)
Makefiles: Align the columns of output. Much better.
2010-04-01 09:07:08 +02:00
quiet = @printf " %12s $@\n" "$1 $2"; $($1)
quiet_args = @printf " %12s$2\n" $1; $($1) $2
Move bulk of rules from Makefile to Makefile.local. Before it was impossible to know whether any particular setting or rule definition was in Makefile or Makefile.local. So we strip the Makefile down to little more than the list of sub-directories and the logic to include all of the sub-directories' Makefile.local fragments. Then, all of the real work can happen inside of Makefile.local.
2010-04-01 07:12:01 +02:00
endif
# Otherwise, print the full command line.
quiet ?= $($1)
Makefiles: Make the install rules quiet like the compilation rules. The output from make is looking better all the time, (though the columns still aren't lined up).
2010-04-01 08:54:21 +02:00
quiet_args ?= $($1) $2
quiet_mkdir = $(call quiet_args,MKDIR,$1)
Makefiles: Align the columns of output. Much better.
2010-04-01 09:07:08 +02:00
quiet_install_bin = $(call quiet_args,INSTALL-BIN,$1)
quiet_install_data = $(call quiet_args,INSTALL-DATA,$1)
Makefiles: Make the install rules quiet like the compilation rules. The output from make is looking better all the time, (though the columns still aren't lined up).
2010-04-01 08:54:21 +02:00
quiet_symlink = $(call quiet_args,SYMLINK,$1)
Move bulk of rules from Makefile to Makefile.local. Before it was impossible to know whether any particular setting or rule definition was in Makefile or Makefile.local. So we strip the Makefile down to little more than the list of sub-directories and the logic to include all of the sub-directories' Makefile.local fragments. Then, all of the real work can happen inside of Makefile.local.
2010-04-01 07:12:01 +02:00
%.o: %.cc $(global_deps)
$(call quiet,CXX,$(CXXFLAGS)) -c $(FINAL_CXXFLAGS) $< -o $@
%.o: %.c $(global_deps)
$(call quiet,CC,$(CFLAGS)) -c $(FINAL_CFLAGS) $< -o $@
%.elc: %.el
Makefile: Add the emacs directory to load-path when compiling Reviewed-by: Carl Worth <cworth@cworth.org>: Presumably, this is to enable proper building in the very near-term future where the emacs implementation consists of multiple files where some will `require' functions from others.
2010-04-01 12:38:30 +02:00
$(call quiet,EMACS) --directory emacs -batch -f batch-byte-compile $<
Move bulk of rules from Makefile to Makefile.local. Before it was impossible to know whether any particular setting or rule definition was in Makefile or Makefile.local. So we strip the Makefile down to little more than the list of sub-directories and the logic to include all of the sub-directories' Makefile.local fragments. Then, all of the real work can happen inside of Makefile.local.
2010-04-01 07:12:01 +02:00
.deps/%.d: %.c $(global_deps)
@set -e; rm -f $@; mkdir -p $$(dirname $@) ; \
$(CC) -M $(CPPFLAGS) $(FINAL_CFLAGS) $< > $@.$$$$ 2>/dev/null ; \
sed 's,'$$(basename $*)'\.o[ :]*,$*.o $@ : ,g' < $@.$$$$ > $@; \
rm -f $@.$$$$
.deps/%.d: %.cc $(global_deps)
@set -e; rm -f $@; mkdir -p $$(dirname $@) ; \
$(CXX) -M $(CPPFLAGS) $(FINAL_CXXFLAGS) $< > $@.$$$$ 2>/dev/null ; \
sed 's,'$$(basename $*)'\.o[ :]*,$*.o $@ : ,g' < $@.$$$$ > $@; \
rm -f $@.$$$$
DEPS := $(SRCS:%.c=.deps/%.d)
DEPS := $(DEPS:%.cc=.deps/%.d)
-include $(DEPS)
.PHONY : clean
clean:
rm -f $(CLEAN); rm -rf .deps
notmuch: Break notmuch.c up into several smaller files. Now that the client sources are alone here in their own directory, (with all the library sources down inside the lib directory), we can break the client up into multiple files without mixing the files up. The hope is that these smaller files will be easier to manage and maintain.
2009-11-10 21:03:05 +01:00
notmuch_client_srcs = \
Makefile: Incorporate getline implementation into the build. It's unconditional for a very short time. We expect to soon be building it only if necessary.
2009-12-02 00:23:25 +01:00
$(notmuch_compat_srcs) \
notmuch-new: Only install SIGALRM if not running under gdb I felt sorry for Carl trying to step through an exception from xapian and suffering from the SIGALARMs.. We can detect if the user launched notmuch under a debugger by either checking our cmdline for the presence of the gdb string or querying if valgrind is controlling our process. For the latter we need to add a compile time check for the valgrind development library, and so add the initial support to build Makefile.config from configure. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Carl Worth <cworth@cworth.org> [ickle: And do not install the timer when under the debugger]
2009-11-22 01:44:31 +01:00
debugger.c \
gmime-filter-reply.c \
notmuch: Break notmuch.c up into several smaller files. Now that the client sources are alone here in their own directory, (with all the library sources down inside the lib directory), we can break the client up into multiple files without mixing the files up. The hope is that these smaller files will be easier to manage and maintain.
2009-11-10 21:03:05 +01:00
notmuch.c \
notmuch: Add a configuration system. This will allow for things like the database path to be specified without any cheesy NOTMUCH_BASE environment variable. It also will allow "notmuch reply" to recognize the user's email address when constructing a reply in order to do the right thing, (that is, to use the user's address to which mail was sent as From:, and not to reply to the user's own addresses). With this change, the "notmuch setup" command is now strictly for changing the configuration of notmuch. It no longer creates the database, but instead instructs the user to call "notmuch new" to do that.
2009-11-12 02:01:55 +01:00
notmuch-config.c \
Add 'notmuch count' command to show the count of matching messages Getting the count of matching threads or messages is a fairly expensive operation. Xapian provides a very efficient mechanism that returns an approximate value, so use that for this new command. This returns the number of matching messages, not threads, as that is cheap to compute. Signed-off-by: Keith Packard <keithp@keithp.com>
2009-11-21 08:15:07 +01:00
notmuch-count.c \
notmuch: Break notmuch.c up into several smaller files. Now that the client sources are alone here in their own directory, (with all the library sources down inside the lib directory), we can break the client up into multiple files without mixing the files up. The hope is that these smaller files will be easier to manage and maintain.
2009-11-10 21:03:05 +01:00
notmuch-dump.c \
notmuch-new.c \
notmuch reply: Add (incomplete) reply command Reviewed-by: Carl Worth <cworth@cworth.org> Keith wrote all the code here against notmuch before notmuch.c was split up into multiple files. So I've pushed the code around in various ways to match the new code structure, but have generally tried to avoid making any changes to the behavior of the code. I did fix one bug---a missing call to g_mime_stream_file_set_owner in show_part which would cause "notmuch show" to go off into the weeds when trying to show multiple messages, (since the first stream would fclose stdout).
2009-11-06 19:00:38 +01:00
notmuch-reply.c \
notmuch: Break notmuch.c up into several smaller files. Now that the client sources are alone here in their own directory, (with all the library sources down inside the lib directory), we can break the client up into multiple files without mixing the files up. The hope is that these smaller files will be easier to manage and maintain.
2009-11-10 21:03:05 +01:00
notmuch-restore.c \
notmuch-search.c \
notmuch: New command 'search-tags'. This is a new notmuch command that can be used to search for all tags found in the database. The resulting list is alphabetically sorted. The primary use-case for this new command is to provide the tag completion feature in Emacs (and other interfaces). Signed-off-by: Jan Janak <jan@ryngle.com>
2009-11-23 01:10:55 +01:00
notmuch-search-tags.c \
notmuch: Break notmuch.c up into several smaller files. Now that the client sources are alone here in their own directory, (with all the library sources down inside the lib directory), we can break the client up into multiple files without mixing the files up. The hope is that these smaller files will be easier to manage and maintain.
2009-11-10 21:03:05 +01:00
notmuch-setup.c \
notmuch-show.c \
notmuch-tag.c \
notmuch-time.c \
notmuch reply: Add (incomplete) reply command Reviewed-by: Carl Worth <cworth@cworth.org> Keith wrote all the code here against notmuch before notmuch.c was split up into multiple files. So I've pushed the code around in various ways to match the new code structure, but have generally tried to avoid making any changes to the behavior of the code. I did fix one bug---a missing call to g_mime_stream_file_set_owner in show_part which would cause "notmuch show" to go off into the weeds when trying to show multiple messages, (since the first stream would fclose stdout).
2009-11-06 19:00:38 +01:00
query-string.c \
Add an "--format=(json|text)" command-line option to both notmuch-search and notmuch-show. In the case of notmuch-show, "--format=json" also implies "--entire-thread" as the thread structure is implicit in the emitted document tree. As a coincidence to the implementation, multipart message ID numbers are now incremented with each part printed. This changes the previous semantics, which were unclear and not necessary related to the actual ordering of the message parts.
2009-12-31 16:17:40 +01:00
show-message.c \
json.c
notmuch: Break notmuch.c up into several smaller files. Now that the client sources are alone here in their own directory, (with all the library sources down inside the lib directory), we can break the client up into multiple files without mixing the files up. The hope is that these smaller files will be easier to manage and maintain.
2009-11-10 21:03:05 +01:00
notmuch_client_modules = $(notmuch_client_srcs:.c=.o)
Compile a static notmuch binary (but only install the shared version) The idea here is to allow a new user of notmuch to be able to run notmuch immediately after compiling, (without having to install the shared library first). This also ensures that the test suite tests the locally compiled library, and not whatever installled version of the library the dynamic linker happens to find.
2010-04-02 00:03:40 +02:00
notmuch: $(notmuch_client_modules) lib/libnotmuch.a
$(call quiet,CC,$(LDFLAGS)) $^ $(FINAL_LDFLAGS) -o $@
notmuch-shared: $(notmuch_client_modules) lib/libnotmuch.so
lib: Switch to a 3-part version number for the library interface. With a carefully documented description of how to increment the various version components.
2010-04-01 09:41:25 +02:00
$(call quiet,CC,$(LDFLAGS)) -Llib -lnotmuch $(notmuch_client_modules) $(FINAL_LDFLAGS) -o $@
Implement a non-recursive make. The idea here is that every Makefile at each lower level will be an identical, tiny file that simply defers to a top-level make. Meanwhile, the Makefile.local file at each level is a Makefile snippet to be included at the top-level into a large, flat Makefile. As such, it needs to define its rules with the entire relative directory to each file, (typically in $(dir)). The local files can also append to variables such as SRCS and CLEAN for files to be analyzed for dependencies and to be cleaned.
2009-11-10 16:14:49 +01:00
Makefile: Fix missing dependency for notmuch.1 manual page. The Makefile was failing to regnerate the notmuch.1.gz file when notmuch.1 was updated, (so stale documentation could potentially be installed).
2009-11-18 06:04:31 +01:00
notmuch.1.gz: notmuch.1
Makefile: Fix to work even with GZIP environment variable set. The rule here was written to assume that if the GZIP environment variable was set that it would be the gzip binary to execute, (similar to the CC and CXX variables). But GZIP is actually used to pass arguments to gzip, so we have to use a different name.
2009-11-22 04:45:16 +01:00
$(call quiet,gzip) --stdout $^ > $@
Implement a non-recursive make. The idea here is that every Makefile at each lower level will be an identical, tiny file that simply defers to a top-level make. Meanwhile, the Makefile.local file at each level is a Makefile snippet to be included at the top-level into a large, flat Makefile. As such, it needs to define its rules with the entire relative directory to each file, (typically in $(dir)). The local files can also append to variables such as SRCS and CLEAN for files to be analyzed for dependencies and to be cleaned.
2009-11-10 16:14:49 +01:00
Makefile: Simplify the conditional message of the all target. We wamt a simple "make" to call the 'all' target and then print a message when done, but we don't want "make install" which depends on that same 'all' target to print the message. We previously did this with a separate 'all-without-message' target, which was inelegant because it caused all users of the target to carefully depend on 'all-without-message' rather than 'all'. Instead, we now use a single 'all' target but with a Makefile conditional that examines the MAKECMDGOALS variable to determine whether to print the message.
2010-03-10 19:44:44 +01:00
install: all notmuch.1.gz
Makefiles: Make the install rules quiet like the compilation rules. The output from make is looking better all the time, (though the columns still aren't lined up).
2010-04-01 08:54:21 +02:00
$(call quiet_mkdir, $(DESTDIR)$(prefix)/bin/)
$(call quiet_mkdir, $(DESTDIR)$(libdir)/)
$(call quiet_mkdir, $(DESTDIR)$(prefix)/include/)
$(call quiet_mkdir, $(DESTDIR)$(prefix)/share/man/man1)
Compile a static notmuch binary (but only install the shared version) The idea here is to allow a new user of notmuch to be able to run notmuch immediately after compiling, (without having to install the shared library first). This also ensures that the test suite tests the locally compiled library, and not whatever installled version of the library the dynamic linker happens to find.
2010-04-02 00:03:40 +02:00
$(call quiet_install_bin, notmuch-shared $(DESTDIR)$(prefix)/bin/notmuch)
Makefiles: Make the install rules quiet like the compilation rules. The output from make is looking better all the time, (though the columns still aren't lined up).
2010-04-01 08:54:21 +02:00
$(call quiet_install_data, notmuch.1.gz $(DESTDIR)$(prefix)/share/man/man1/)
Makefile: Conditionalize the "make install" message. This is the same approach as with the 'all' target previously.
2010-03-10 19:48:47 +01:00
ifeq ($(MAKECMDGOALS), install)
Makefile: Add message to make install listing the other install targets. Otherwise, it's hard for the user to know that things like install-emacs, install-bash, and install-zsh even exist.
2010-03-10 19:07:34 +01:00
@echo ""
@echo "Notmuch is now installed."
@echo ""
@echo "You may now want to install additional components to support using notmuch"
@echo "together with other software packages:"
@echo ""
@echo " make install-emacs"
@echo " make install-bash"
@echo " make install-zsh"
Makefile: Conditionalize the "make install" message. This is the same approach as with the 'all' target previously.
2010-03-10 19:48:47 +01:00
@echo ""
endif
Implement a non-recursive make. The idea here is that every Makefile at each lower level will be an identical, tiny file that simply defers to a top-level make. Meanwhile, the Makefile.local file at each level is a Makefile snippet to be included at the top-level into a large, flat Makefile. As such, it needs to define its rules with the entire relative directory to each file, (typically in $(dir)). The local files can also append to variables such as SRCS and CLEAN for files to be analyzed for dependencies and to be cleaned.
2009-11-10 16:14:49 +01:00
Add install target for notmuch.desktop file. Add an install target that uses desktop-file-install to install the desktop file in the appropriate location. The location of the install can be modified by changing the desktop_dir variable. Signed-off-by: Jeffrey C. Ollie <jeff@ocjtech.us>
2009-11-22 22:17:11 +01:00
install-desktop:
Makefiles: Make the install rules quiet like the compilation rules. The output from make is looking better all the time, (though the columns still aren't lined up).
2010-04-01 08:54:21 +02:00
$(call quiet,MKDIR) $(DESTDIR)$(desktop_dir)
Add install target for notmuch.desktop file. Add an install target that uses desktop-file-install to install the desktop file in the appropriate location. The location of the install can be modified by changing the desktop_dir variable. Signed-off-by: Jeffrey C. Ollie <jeff@ocjtech.us>
2009-11-22 22:17:11 +01:00
desktop-file-install --mode 0644 --dir $(DESTDIR)$(desktop_dir) notmuch.desktop
Makefile: Add new "install-bash" target for bash completion support It was problematic to have this in "make install" since it would unconditionally try to install to /etc, (even if a non-privileged user was attempting an install to a prefix in the user's home directory, for example).
2009-12-01 19:14:00 +01:00
install-bash:
Makefiles: Make the install rules quiet like the compilation rules. The output from make is looking better all the time, (though the columns still aren't lined up).
2010-04-01 08:54:21 +02:00
$(call quiet-mkdir, $(DESTDIR)$(bash_completion_dir))
$(call quiet_install_data, contrib/notmuch-completion.bash $(DESTDIR)$(bash_completion_dir)/notmuch)
Makefile: Add new "install-bash" target for bash completion support It was problematic to have this in "make install" since it would unconditionally try to install to /etc, (even if a non-privileged user was attempting an install to a prefix in the user's home directory, for example).
2009-12-01 19:14:00 +01:00
Install zsh completion file According to the Debian zsh maintainer Clint Adams, this is the first time that a package installs its own completer into zsh. Part of the reason this is not usually done is because zsh does not provide a stable API. We agreed to try it, given that notmuch is expected to change quite a bit initially. If there are problems or the completer goes stable, we'll move it into the upstream zsh repository. Signed-off-by: martin f. krafft <madduck@debian.org>
2010-01-08 23:49:34 +01:00
install-zsh:
Makefiles: Make the install rules quiet like the compilation rules. The output from make is looking better all the time, (though the columns still aren't lined up).
2010-04-01 08:54:21 +02:00
$(call quiet_mkdir, $(DESTDIR)$(zsh_completion_dir))
$(call quiet_install_data, contrib/notmuch-completion.zsh $(DESTDIR)$(zsh_completion_dir)/notmuch)
Install zsh completion file According to the Debian zsh maintainer Clint Adams, this is the first time that a package installs its own completer into zsh. Part of the reason this is not usually done is because zsh does not provide a stable API. We agreed to try it, given that notmuch is expected to change quite a bit initially. If there are problems or the completer goes stable, we'll move it into the upstream zsh repository. Signed-off-by: martin f. krafft <madduck@debian.org>
2010-01-08 23:49:34 +01:00
notmuch: Break notmuch.c up into several smaller files. Now that the client sources are alone here in their own directory, (with all the library sources down inside the lib directory), we can break the client up into multiple files without mixing the files up. The hope is that these smaller files will be easier to manage and maintain.
2009-11-10 21:03:05 +01:00
SRCS := $(SRCS) $(notmuch_client_srcs)
Compile a static notmuch binary (but only install the shared version) The idea here is to allow a new user of notmuch to be able to run notmuch immediately after compiling, (without having to install the shared library first). This also ensures that the test suite tests the locally compiled library, and not whatever installled version of the library the dynamic linker happens to find.
2010-04-02 00:03:40 +02:00
CLEAN := $(CLEAN) notmuch notmuch-shared $(notmuch_client_modules) notmuch.elc notmuch.1.gz
Reference in a new issue Copy permalink