mirror of
https://git.notmuchmail.org/git/notmuch
synced 2024-12-12 04:24:51 +01:00
101 lines
4.6 KiB
Text
101 lines
4.6 KiB
Text
|
From: Scott Lovenberg <scott.lovenberg@gmail.com>
|
||
|
|
Subject: Re: [RFC][PATCH 10/10] cifs: add mount option to enable local caching
|
||
|
|
Date: Wed, 23 Jun 2010 14:32:24 -0400
|
||
|
|
Lines: 37
|
||
|
|
Message-ID: <4C225338.9010807@gmail.com>
|
||
|
|
References: <yes> <1277220309-3757-1-git-send-email-sjayaraman@suse.de>
|
||
|
|
Mime-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
|
||
|
|
Content-Transfer-Encoding: 7bit
|
||
|
|
Cc: Steve French <smfrench@gmail.com>, linux-cifs@vger.kernel.org,
|
||
|
|
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
|
||
|
|
David Howells <dhowells@redhat.com>
|
||
|
|
To: Suresh Jayaraman <sjayaraman@suse.de>
|
||
|
|
X-From: linux-kernel-owner@vger.kernel.org Wed Jun 23 20:32:44 2010
|
||
|
|
Return-path: <linux-kernel-owner@vger.kernel.org>
|
||
|
|
Envelope-to: glk-linux-kernel-3@lo.gmane.org
|
||
|
|
Received: from vger.kernel.org ([209.132.180.67])
|
||
|
|
by lo.gmane.org with esmtp (Exim 4.69)
|
||
|
|
(envelope-from <linux-kernel-owner@vger.kernel.org>)
|
||
|
|
id 1ORUke-00020X-7B
|
||
|
|
for glk-linux-kernel-3@lo.gmane.org; Wed, 23 Jun 2010 20:32:44 +0200
|
||
|
|
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
|
||
|
|
id S1753205Ab0FWScd (ORCPT <rfc822;glk-linux-kernel-3@m.gmane.org>);
|
||
|
|
Wed, 23 Jun 2010 14:32:33 -0400
|
||
|
|
Received: from mail-gx0-f174.google.com ([209.85.161.174]:50118 "EHLO
|
||
|
|
mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
|
||
|
|
with ESMTP id S1752380Ab0FWScb (ORCPT
|
||
|
|
<rfc822;linux-kernel@vger.kernel.org>);
|
||
|
|
Wed, 23 Jun 2010 14:32:31 -0400
|
||
|
|
Received: by gxk28 with SMTP id 28so317656gxk.19
|
||
|
|
for <multiple recipients>; Wed, 23 Jun 2010 11:32:31 -0700 (PDT)
|
||
|
|
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
|
||
|
|
d=gmail.com; s=gamma;
|
||
|
|
h=domainkey-signature:received:received:message-id:date:from
|
||
|
|
:user-agent:mime-version:to:cc:subject:references:in-reply-to
|
||
|
|
:content-type:content-transfer-encoding;
|
||
|
|
bh=iTBSrajJefJVTimpUcvJQmptYefXJDrz9ZyZgxnMvzA=;
|
||
|
|
b=DOZLux9YGwNIWknqofz5rMltvopOT+kRgPsHIYw8Z7Uhh9gR5YAD4V6kKmv1SIaWoo
|
||
|
|
uXjNwY+IPIiD4f4OwwlpwJTd4B7PkBCDIlOkwVcvvS3F6qr6WbXBd0nRuRiFGMwONU3E
|
||
|
|
MqTAWDDwIXLVURr1t+n3MFrKwKj5b7pZT5fHw=
|
||
|
|
DomainKey-Signature: a=rsa-sha1; c=nofws;
|
||
|
|
d=gmail.com; s=gamma;
|
||
|
|
h=message-id:date:from:user-agent:mime-version:to:cc:subject
|
||
|
|
:references:in-reply-to:content-type:content-transfer-encoding;
|
||
|
|
b=pTsfPMlTDpE3Oi2w9V3eE2ohOeBEloXhgElmCwGEenBegF7ZhIyoga6tyRJqQ922ws
|
||
|
|
oyxLXSORpOuPJRoIBRXfzae3KXkgKT0eLDjxQNTdS7Jbe+vcJ604sANFcnxBsJ51fThT
|
||
|
|
R/wXt7LiG/T6H4DUpcN7aUjtzlq9JgC2JQ/ws=
|
||
|
|
Received: by 10.224.43.197 with SMTP id x5mr5243425qae.127.1277317950764;
|
||
|
|
Wed, 23 Jun 2010 11:32:30 -0700 (PDT)
|
||
|
|
Received: from [192.168.0.2] ([64.9.41.61])
|
||
|
|
by mx.google.com with ESMTPS id 15sm3010007qcg.2.2010.06.23.11.32.25
|
||
|
|
(version=TLSv1/SSLv3 cipher=RC4-MD5);
|
||
|
|
Wed, 23 Jun 2010 11:32:26 -0700 (PDT)
|
||
|
|
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.10) Gecko/20100512 Lightning/1.0b1 Thunderbird/3.0.5 ThunderBrowse/3.2.8.1
|
||
|
|
In-Reply-To: <1277220309-3757-1-git-send-email-sjayaraman@suse.de>
|
||
|
|
Sender: linux-kernel-owner@vger.kernel.org
|
||
|
|
Precedence: bulk
|
||
|
|
List-ID: <linux-kernel.vger.kernel.org>
|
||
|
|
X-Mailing-List: linux-kernel@vger.kernel.org
|
||
|
|
Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1002258>
|
||
|
|
|
||
|
|
On 6/22/2010 11:25 AM, Suresh Jayaraman wrote:
|
||
|
|
> Add a mount option 'fsc' to enable local caching on CIFS.
|
||
|
|
>
|
||
|
|
> As the cifs-utils (userspace) changes are not done yet, this patch enables
|
||
|
|
> 'fsc' by default to assist testing.
|
||
|
|
>
|
||
|
|
[...]
|
||
|
|
> @@ -1332,6 +1336,8 @@ cifs_parse_mount_options(char *options, const char *devname,
|
||
|
|
> printk(KERN_WARNING "CIFS: Mount option noac not "
|
||
|
|
> "supported. Instead set "
|
||
|
|
> "/proc/fs/cifs/LookupCacheEnabled to 0\n");
|
||
|
|
> + } else if (strnicmp(data, "fsc", 3) == 0) {
|
||
|
|
> + vol->fsc = true;
|
||
|
|
> } else
|
||
|
|
> printk(KERN_WARNING "CIFS: Unknown mount option %s\n",
|
||
|
|
> data);
|
||
|
|
> @@ -2405,6 +2411,8 @@ static void setup_cifs_sb(struct smb_vol *pvolume_info,
|
||
|
|
> cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_OVERR_GID;
|
||
|
|
> if (pvolume_info->dynperm)
|
||
|
|
> cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_DYNPERM;
|
||
|
|
> + if (pvolume_info->fsc)
|
||
|
|
> + cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_FSCACHE;
|
||
|
|
> if (pvolume_info->direct_io) {
|
||
|
|
> cFYI(1, "mounting share using direct i/o");
|
||
|
|
> cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_DIRECT_IO;
|
||
|
|
>
|
||
|
|
I reworked the CIFS mount option parsing a while back; I'm not sure
|
||
|
|
whether that patch was going to be in the 2.6.35 tree or not (the window
|
||
|
|
just opened, didn't it?).
|
||
|
|
|
||
|
|
Jeff, Steve, can you confirm if that patch is going to be in 2.6.35?
|
||
|
|
|
||
|
|
Patch refs: http://patchwork.ozlabs.org/patch/53059/ and
|
||
|
|
http://patchwork.ozlabs.org/patch/53674/
|
||
|
|
|
||
|
|
|
||
|
|
|
||
|
|
|
||
|
|
|