2011-12-01 01:27:26 +01:00
|
|
|
#include <assert.h>
|
|
|
|
#include <string.h>
|
|
|
|
#include <stdio.h>
|
|
|
|
#include "error_util.h"
|
|
|
|
#include "command-line-arguments.h"
|
|
|
|
|
|
|
|
/*
|
|
|
|
Search the array of keywords for a given argument, assigning the
|
|
|
|
output variable to the corresponding value. Return FALSE if nothing
|
|
|
|
matches.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static notmuch_bool_t
|
2012-06-16 12:21:42 +02:00
|
|
|
_process_keyword_arg (const notmuch_opt_desc_t *arg_desc, char next, const char *arg_str) {
|
2011-12-01 01:27:26 +01:00
|
|
|
|
2011-12-13 04:54:24 +01:00
|
|
|
const notmuch_keyword_t *keywords = arg_desc->keywords;
|
2011-12-01 01:27:26 +01:00
|
|
|
|
2012-06-05 16:36:36 +02:00
|
|
|
if (next == '\0') {
|
2012-06-16 12:21:42 +02:00
|
|
|
/* No keyword given */
|
|
|
|
arg_str = "";
|
|
|
|
}
|
|
|
|
|
2011-12-01 01:27:26 +01:00
|
|
|
while (keywords->name) {
|
|
|
|
if (strcmp (arg_str, keywords->name) == 0) {
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
if (arg_desc->opt_flags)
|
|
|
|
*arg_desc->opt_flags |= keywords->value;
|
|
|
|
else
|
|
|
|
*arg_desc->opt_keyword = keywords->value;
|
2011-12-01 01:27:26 +01:00
|
|
|
return TRUE;
|
|
|
|
}
|
|
|
|
keywords++;
|
|
|
|
}
|
2012-06-05 16:36:36 +02:00
|
|
|
if (next != '\0')
|
|
|
|
fprintf (stderr, "Unknown keyword argument \"%s\" for option \"%s\".\n", arg_str, arg_desc->name);
|
2012-06-16 12:21:42 +02:00
|
|
|
else
|
2012-06-05 16:36:36 +02:00
|
|
|
fprintf (stderr, "Option \"%s\" needs a keyword argument.\n", arg_desc->name);
|
2011-12-01 01:27:26 +01:00
|
|
|
return FALSE;
|
|
|
|
}
|
|
|
|
|
2012-03-10 12:05:32 +01:00
|
|
|
static notmuch_bool_t
|
|
|
|
_process_boolean_arg (const notmuch_opt_desc_t *arg_desc, char next, const char *arg_str) {
|
|
|
|
|
2012-06-05 16:36:36 +02:00
|
|
|
if (next == '\0') {
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
*arg_desc->opt_bool = TRUE;
|
2012-03-10 12:05:32 +01:00
|
|
|
return TRUE;
|
|
|
|
}
|
|
|
|
if (strcmp (arg_str, "false") == 0) {
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
*arg_desc->opt_bool = FALSE;
|
2012-03-10 12:05:32 +01:00
|
|
|
return TRUE;
|
|
|
|
}
|
|
|
|
if (strcmp (arg_str, "true") == 0) {
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
*arg_desc->opt_bool = TRUE;
|
2012-03-10 12:05:32 +01:00
|
|
|
return TRUE;
|
|
|
|
}
|
2012-06-05 16:36:36 +02:00
|
|
|
fprintf (stderr, "Unknown argument \"%s\" for (boolean) option \"%s\".\n", arg_str, arg_desc->name);
|
2012-03-10 12:05:32 +01:00
|
|
|
return FALSE;
|
|
|
|
}
|
|
|
|
|
2012-06-05 16:36:36 +02:00
|
|
|
static notmuch_bool_t
|
|
|
|
_process_int_arg (const notmuch_opt_desc_t *arg_desc, char next, const char *arg_str) {
|
|
|
|
|
|
|
|
char *endptr;
|
|
|
|
if (next == '\0' || arg_str[0] == '\0') {
|
|
|
|
fprintf (stderr, "Option \"%s\" needs an integer argument.\n", arg_desc->name);
|
|
|
|
return FALSE;
|
|
|
|
}
|
|
|
|
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
*arg_desc->opt_int = strtol (arg_str, &endptr, 10);
|
2012-06-05 16:36:36 +02:00
|
|
|
if (*endptr == '\0')
|
|
|
|
return TRUE;
|
|
|
|
|
|
|
|
fprintf (stderr, "Unable to parse argument \"%s\" for option \"%s\" as an integer.\n",
|
|
|
|
arg_str, arg_desc->name);
|
|
|
|
return FALSE;
|
|
|
|
}
|
|
|
|
|
|
|
|
static notmuch_bool_t
|
|
|
|
_process_string_arg (const notmuch_opt_desc_t *arg_desc, char next, const char *arg_str) {
|
|
|
|
|
|
|
|
if (next == '\0') {
|
|
|
|
fprintf (stderr, "Option \"%s\" needs a string argument.\n", arg_desc->name);
|
|
|
|
return FALSE;
|
|
|
|
}
|
|
|
|
if (arg_str[0] == '\0') {
|
|
|
|
fprintf (stderr, "String argument for option \"%s\" must be non-empty.\n", arg_desc->name);
|
|
|
|
return FALSE;
|
|
|
|
}
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
*arg_desc->opt_string = arg_str;
|
2012-06-05 16:36:36 +02:00
|
|
|
return TRUE;
|
|
|
|
}
|
|
|
|
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
/* Return number of non-NULL opt_* fields in opt_desc. */
|
|
|
|
static int _opt_set_count (const notmuch_opt_desc_t *opt_desc)
|
|
|
|
{
|
|
|
|
return
|
|
|
|
!!opt_desc->opt_inherit +
|
|
|
|
!!opt_desc->opt_bool +
|
|
|
|
!!opt_desc->opt_int +
|
|
|
|
!!opt_desc->opt_keyword +
|
|
|
|
!!opt_desc->opt_flags +
|
|
|
|
!!opt_desc->opt_string +
|
|
|
|
!!opt_desc->opt_position;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Return TRUE if opt_desc is valid. */
|
|
|
|
static notmuch_bool_t _opt_valid (const notmuch_opt_desc_t *opt_desc)
|
|
|
|
{
|
|
|
|
int n = _opt_set_count (opt_desc);
|
|
|
|
|
|
|
|
if (n > 1)
|
|
|
|
INTERNAL_ERROR ("more than one non-NULL opt_* field for argument \"%s\"",
|
|
|
|
opt_desc->name);
|
|
|
|
|
|
|
|
return n > 0;
|
|
|
|
}
|
|
|
|
|
2011-12-01 01:27:26 +01:00
|
|
|
/*
|
|
|
|
Search for the {pos_arg_index}th position argument, return FALSE if
|
|
|
|
that does not exist.
|
|
|
|
*/
|
|
|
|
|
|
|
|
notmuch_bool_t
|
|
|
|
parse_position_arg (const char *arg_str, int pos_arg_index,
|
|
|
|
const notmuch_opt_desc_t *arg_desc) {
|
|
|
|
|
|
|
|
int pos_arg_counter = 0;
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
while (_opt_valid (arg_desc)) {
|
|
|
|
if (arg_desc->opt_position) {
|
2011-12-01 01:27:26 +01:00
|
|
|
if (pos_arg_counter == pos_arg_index) {
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
*arg_desc->opt_position = arg_str;
|
2017-10-01 22:53:14 +02:00
|
|
|
if (arg_desc->present)
|
|
|
|
*arg_desc->present = TRUE;
|
2011-12-01 01:27:26 +01:00
|
|
|
return TRUE;
|
|
|
|
}
|
|
|
|
pos_arg_counter++;
|
|
|
|
}
|
|
|
|
arg_desc++;
|
|
|
|
}
|
|
|
|
return FALSE;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Search for a non-positional (i.e. starting with --) argument matching arg,
|
|
|
|
* parse a possible value, and assign to *output_var
|
|
|
|
*/
|
|
|
|
|
2017-07-01 17:18:44 +02:00
|
|
|
int
|
|
|
|
parse_option (int argc, char **argv, const notmuch_opt_desc_t *options, int opt_index)
|
2014-11-05 01:25:54 +01:00
|
|
|
{
|
2017-07-01 17:18:44 +02:00
|
|
|
assert(argv);
|
|
|
|
|
|
|
|
const char *_arg = argv[opt_index];
|
|
|
|
|
2014-11-05 01:25:54 +01:00
|
|
|
assert(_arg);
|
2011-12-01 01:27:26 +01:00
|
|
|
assert(options);
|
|
|
|
|
2014-11-05 01:25:54 +01:00
|
|
|
const char *arg = _arg + 2; /* _arg starts with -- */
|
2012-06-05 16:36:36 +02:00
|
|
|
const notmuch_opt_desc_t *try;
|
2017-07-01 17:18:45 +02:00
|
|
|
|
|
|
|
const char *next_arg = NULL;
|
|
|
|
if (opt_index < argc - 1 && strncmp (argv[opt_index + 1], "--", 2) != 0)
|
|
|
|
next_arg = argv[opt_index + 1];
|
|
|
|
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
for (try = options; _opt_valid (try); try++) {
|
|
|
|
if (try->opt_inherit) {
|
|
|
|
int new_index = parse_option (argc, argv, try->opt_inherit, opt_index);
|
2017-07-01 17:18:44 +02:00
|
|
|
if (new_index >= 0)
|
|
|
|
return new_index;
|
|
|
|
}
|
2014-11-05 01:25:54 +01:00
|
|
|
|
2014-02-24 22:36:58 +01:00
|
|
|
if (! try->name)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (strncmp (arg, try->name, strlen (try->name)) != 0)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
char next = arg[strlen (try->name)];
|
|
|
|
const char *value = arg + strlen(try->name) + 1;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If we have not reached the end of the argument (i.e. the
|
|
|
|
* next character is not a space or delimiter) then the
|
|
|
|
* argument could still match a longer option name later in
|
|
|
|
* the option table.
|
|
|
|
*/
|
|
|
|
if (next != '=' && next != ':' && next != '\0')
|
|
|
|
continue;
|
|
|
|
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
if (next == '\0' && next_arg != NULL && ! try->opt_bool) {
|
2017-07-01 17:18:45 +02:00
|
|
|
next = ' ';
|
|
|
|
value = next_arg;
|
|
|
|
opt_index ++;
|
|
|
|
}
|
|
|
|
|
2017-07-01 17:18:44 +02:00
|
|
|
notmuch_bool_t opt_status = FALSE;
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
if (try->opt_keyword || try->opt_flags)
|
2017-07-01 17:18:44 +02:00
|
|
|
opt_status = _process_keyword_arg (try, next, value);
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
else if (try->opt_bool)
|
2017-07-01 17:18:44 +02:00
|
|
|
opt_status = _process_boolean_arg (try, next, value);
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
else if (try->opt_int)
|
2017-07-01 17:18:44 +02:00
|
|
|
opt_status = _process_int_arg (try, next, value);
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
else if (try->opt_string)
|
2017-07-01 17:18:44 +02:00
|
|
|
opt_status = _process_string_arg (try, next, value);
|
cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-01 22:53:11 +02:00
|
|
|
else
|
|
|
|
INTERNAL_ERROR ("unknown or unhandled option \"%s\"", try->name);
|
|
|
|
|
2017-10-01 22:53:14 +02:00
|
|
|
if (! opt_status)
|
2017-07-01 17:18:44 +02:00
|
|
|
return -1;
|
2017-10-01 22:53:14 +02:00
|
|
|
|
|
|
|
if (try->present)
|
|
|
|
*try->present = TRUE;
|
|
|
|
|
|
|
|
return opt_index+1;
|
2011-12-01 01:27:26 +01:00
|
|
|
}
|
2017-07-01 17:18:44 +02:00
|
|
|
return -1;
|
2011-12-01 01:27:26 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/* See command-line-arguments.h for description */
|
|
|
|
int
|
|
|
|
parse_arguments (int argc, char **argv,
|
|
|
|
const notmuch_opt_desc_t *options, int opt_index) {
|
|
|
|
|
|
|
|
int pos_arg_index = 0;
|
|
|
|
notmuch_bool_t more_args = TRUE;
|
|
|
|
|
|
|
|
while (more_args && opt_index < argc) {
|
|
|
|
if (strncmp (argv[opt_index],"--",2) != 0) {
|
|
|
|
|
|
|
|
more_args = parse_position_arg (argv[opt_index], pos_arg_index, options);
|
|
|
|
|
|
|
|
if (more_args) {
|
|
|
|
pos_arg_index++;
|
|
|
|
opt_index++;
|
|
|
|
}
|
|
|
|
|
|
|
|
} else {
|
2017-07-01 17:18:44 +02:00
|
|
|
int prev_opt_index = opt_index;
|
2011-12-01 01:27:26 +01:00
|
|
|
|
|
|
|
if (strlen (argv[opt_index]) == 2)
|
|
|
|
return opt_index+1;
|
|
|
|
|
2017-07-01 17:18:44 +02:00
|
|
|
opt_index = parse_option (argc, argv, options, opt_index);
|
|
|
|
if (opt_index < 0) {
|
|
|
|
fprintf (stderr, "Unrecognized option: %s\n", argv[prev_opt_index]);
|
|
|
|
more_args = FALSE;
|
2011-12-01 01:27:26 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return opt_index;
|
|
|
|
}
|