mirror of
https://git.notmuchmail.org/git/notmuch
synced 2024-12-27 03:41:41 +01:00
94 lines
3.1 KiB
Text
94 lines
3.1 KiB
Text
|
From: Ingo Molnar <mingo@elte.hu>
|
||
|
|
Subject: Re: [PATCH 1/6] x86: move ioapic_irq_destination_types
|
||
|
|
Date: Mon, 14 Feb 2011 12:05:28 +0100
|
||
|
|
Lines: 40
|
||
|
|
Message-ID: <20110214110528.GD7140@elte.hu>
|
||
|
|
References: <1297677612-12405-1-git-send-email-henne@nachtwindheim.de>
|
||
|
|
Mime-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=us-ascii
|
||
|
|
Cc: mingo@readhat.com, tglx@linutronix.de, hpa@zytor.com,
|
||
|
|
x86@kernel.org, tj@kernel.org, yinghai@kernel.org,
|
||
|
|
ak@linux.intel.com, robert.richter@amd.com,
|
||
|
|
linux-kernel@vger.kernel.org
|
||
|
|
To: Henrik Kretzschmar <henne@nachtwindheim.de>
|
||
|
|
X-From: linux-kernel-owner@vger.kernel.org Mon Feb 14 12:06:00 2011
|
||
|
|
Return-path: <linux-kernel-owner@vger.kernel.org>
|
||
|
|
Envelope-to: glk-linux-kernel-3@lo.gmane.org
|
||
|
|
Received: from vger.kernel.org ([209.132.180.67])
|
||
|
|
by lo.gmane.org with esmtp (Exim 4.69)
|
||
|
|
(envelope-from <linux-kernel-owner@vger.kernel.org>)
|
||
|
|
id 1PowFj-0003bW-W9
|
||
|
|
for glk-linux-kernel-3@lo.gmane.org; Mon, 14 Feb 2011 12:06:00 +0100
|
||
|
|
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
|
||
|
|
id S1753317Ab1BNLFq (ORCPT <rfc822;glk-linux-kernel-3@m.gmane.org>);
|
||
|
|
Mon, 14 Feb 2011 06:05:46 -0500
|
||
|
|
Received: from mx3.mail.elte.hu ([157.181.1.138]:46158 "EHLO mx3.mail.elte.hu"
|
||
|
|
rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
|
||
|
|
id S1752958Ab1BNLFn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
|
||
|
|
Mon, 14 Feb 2011 06:05:43 -0500
|
||
|
|
Received: from elvis.elte.hu ([157.181.1.14])
|
||
|
|
by mx3.mail.elte.hu with esmtp (Exim)
|
||
|
|
id 1PowFH-0003wc-2d
|
||
|
|
from <mingo@elte.hu>; Mon, 14 Feb 2011 12:05:36 +0100
|
||
|
|
Received: by elvis.elte.hu (Postfix, from userid 1004)
|
||
|
|
id 30C323E2369; Mon, 14 Feb 2011 12:05:27 +0100 (CET)
|
||
|
|
Content-Disposition: inline
|
||
|
|
In-Reply-To: <1297677612-12405-1-git-send-email-henne@nachtwindheim.de>
|
||
|
|
User-Agent: Mutt/1.5.20 (2009-08-17)
|
||
|
|
Received-SPF: neutral (mx3: 157.181.1.14 is neither permitted nor denied by domain of elte.hu) client-ip=157.181.1.14; envelope-from=mingo@elte.hu; helo=elvis.elte.hu;
|
||
|
|
X-ELTE-SpamScore: -2.0
|
||
|
|
X-ELTE-SpamLevel:
|
||
|
|
X-ELTE-SpamCheck: no
|
||
|
|
X-ELTE-SpamVersion: ELTE 2.0
|
||
|
|
X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5
|
||
|
|
-2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1%
|
||
|
|
[score: 0.0000]
|
||
|
|
Sender: linux-kernel-owner@vger.kernel.org
|
||
|
|
Precedence: bulk
|
||
|
|
List-ID: <linux-kernel.vger.kernel.org>
|
||
|
|
X-Mailing-List: linux-kernel@vger.kernel.org
|
||
|
|
Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1099674>
|
||
|
|
|
||
|
|
|
||
|
|
* Henrik Kretzschmar <henne@nachtwindheim.de> wrote:
|
||
|
|
|
||
|
|
> +++ b/arch/x86/include/asm/apicdef.h
|
||
|
|
> @@ -426,4 +426,16 @@ struct local_apic {
|
||
|
|
> #else
|
||
|
|
> #define BAD_APICID 0xFFFFu
|
||
|
|
> #endif
|
||
|
|
> +
|
||
|
|
> +enum ioapic_irq_destination_types {
|
||
|
|
> + dest_Fixed = 0,
|
||
|
|
> + dest_LowestPrio = 1,
|
||
|
|
> + dest_SMI = 2,
|
||
|
|
> + dest__reserved_1 = 3,
|
||
|
|
> + dest_NMI = 4,
|
||
|
|
> + dest_INIT = 5,
|
||
|
|
> + dest__reserved_2 = 6,
|
||
|
|
> + dest_ExtINT = 7
|
||
|
|
> +};
|
||
|
|
|
||
|
|
one very small request, while we are moving it could you please align the value
|
||
|
|
enumeration vertically? Something like:
|
||
|
|
|
||
|
|
enum ioapic_irq_destination_types {
|
||
|
|
|
||
|
|
dest_Fixed = 0,
|
||
|
|
dest_LowestPrio = 1,
|
||
|
|
dest_SMI = 2,
|
||
|
|
dest__reserved_1 = 3,
|
||
|
|
dest_NMI = 4,
|
||
|
|
dest_INIT = 5,
|
||
|
|
dest__reserved_2 = 6,
|
||
|
|
dest_ExtINT = 7
|
||
|
|
};
|
||
|
|
|
||
|
|
... would be much more readable, right?
|
||
|
|
|
||
|
|
Thanks,
|
||
|
|
|
||
|
|
Ingo
|
||
|
|
|
||
|
|
|