notmuch/test/T360-symbol-hiding.sh

#!/usr/bin/env bash
#
# Copyright (c) 2011 David Bremner
#

# This test tests whether hiding Xapian::Error symbols in libnotmuch
# also hides them for other users of libxapian. This is motivated by
# the discussion in http://gcc.gnu.org/wiki/Visibility'

test_description='exception symbol hiding'

. ./test-lib.sh

test_begin_subtest 'running test' run_test
mkdir -p ${PWD}/fakedb/.notmuch
( LD_LIBRARY_PATH="$TEST_DIRECTORY/../lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}" \
		 $TEST_DIRECTORY/symbol-test ${PWD}/fakedb ${PWD}/nonexistent \
		 2>&1 | sed "s,${PWD},CWD,g") > OUTPUT

cat <<EOF > EXPECTED
A Xapian exception occurred opening database: Couldn't stat 'CWD/fakedb/.notmuch/xapian'
caught No chert database found at path \`CWD/nonexistent'
EOF
test_expect_equal_file EXPECTED OUTPUT

test_begin_subtest 'checking output'
test_expect_equal "$result" "$output"

test_begin_subtest 'comparing existing to exported symbols'
nm -P $TEST_DIRECTORY/../lib/libnotmuch.so | awk '$2 == "T" && $1 ~ "^notmuch" {print $1}' | sort | uniq > ACTUAL
sed -n 's/[[:blank:]]*\(notmuch_[^;]*\);/\1/p' $TEST_DIRECTORY/../notmuch.sym | sort | uniq > EXPORTED
test_expect_equal_file EXPORTED ACTUAL

test_done
tests: add a test for symbol hiding side effects The worry here is that a binary linking with libnotmuch might lose access to Xapian::Error symbols because libnotmuch hides them. We are careful here to create ./fakedb/.notmuch in order to trigger a Xapian exception, and not just a missing file check. Thanks to jrollins and amddragon for suggestions. (cherry picked from commit 66f37f5f6864a988f94ddb893e3a176af57f6c8e) 2011-06-22 13:58:01 +02:00			`#!/usr/bin/env bash`
			`#`
			`# Copyright (c) 2011 David Bremner`
			`#`

			`# This test tests whether hiding Xapian::Error symbols in libnotmuch`
			`# also hides them for other users of libxapian. This is motivated by`
			`# the discussion in http://gcc.gnu.org/wiki/Visibility'`

			`test_description='exception symbol hiding'`

			`. ./test-lib.sh`

lib: reject relative paths in n_d_{create,open}_verbose There are many places in the notmuch code where the path is assumed to be absolute. If someone (TM) wants a project, one could remove these assumptions. In the mean time, prevent users from shooting themselves in the foot. Update test suite mark tests for this error as no longer broken, and also convert some tests that used relative paths for nonexistent directories. 2015-06-08 08:02:22 +02:00			`test_begin_subtest 'running test' run_test`
			`mkdir -p ${PWD}/fakedb/.notmuch`
			`( LD_LIBRARY_PATH="$TEST_DIRECTORY/../lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}" \`
			`$TEST_DIRECTORY/symbol-test ${PWD}/fakedb ${PWD}/nonexistent \`
			`2>&1 \| sed "s,${PWD},CWD,g") > OUTPUT`

			`cat <<EOF > EXPECTED`
			`A Xapian exception occurred opening database: Couldn't stat 'CWD/fakedb/.notmuch/xapian'`
			caught No chert database found at path \`CWD/nonexistent'
			`EOF`
			`test_expect_equal_file EXPECTED OUTPUT`
test/symbol-hiding: add some whitespace between tests This is in preparation for adding a third test to this file 2011-11-29 07:51:15 +01:00
tests: add a test for symbol hiding side effects The worry here is that a binary linking with libnotmuch might lose access to Xapian::Error symbols because libnotmuch hides them. We are careful here to create ./fakedb/.notmuch in order to trigger a Xapian exception, and not just a missing file check. Thanks to jrollins and amddragon for suggestions. (cherry picked from commit 66f37f5f6864a988f94ddb893e3a176af57f6c8e) 2011-06-22 13:58:01 +02:00			`test_begin_subtest 'checking output'`
test: whitespace-cleanup for most test/* files Used emacs (whitespace-cleanup) function to "cleanup blank problems" in test files where that could be done without breaking tests; test/emacs was partially, and test/multipart was fully reverted. 2012-01-11 17:53:59 +01:00			`test_expect_equal "$result" "$output"`
test/symbol-hiding: compare exported symbols with existing one We assume that any symbol starting with notmuch_ in lib/*.o should be exported, and that only those symbols should be exported. 2011-11-29 07:51:16 +01:00
			`test_begin_subtest 'comparing existing to exported symbols'`
test: simplify T360-symbol-hiding, use nm instead of objdump After yet another variation in objdump output caused this test to fail (on a Debian port, no less), I decided whatever putative benefit we get from looking at the object files instead of the library isn't worth the maintenence headache. This version uses nm -P. nm -P should be portable, and fixed format. It purposely doesn't use the -D argument, since that is non-POSIX and nm on GNU/Linux seems do the right thing without it. It still won't work out of the box on e.g. Mac OS/X. I think the right thing to do there is to move some more configuration information into sh.config. 2014-09-10 08:41:11 +02:00			`nm -P $TEST_DIRECTORY/../lib/libnotmuch.so \| awk '$2 == "T" && $1 ~ "^notmuch" {print $1}' \| sort \| uniq > ACTUAL`
test/symbol-hiding: compare exported symbols with existing one We assume that any symbol starting with notmuch_ in lib/*.o should be exported, and that only those symbols should be exported. 2011-11-29 07:51:16 +01:00			`sed -n 's/[[:blank:]]\(notmuch_[^;]\);/\1/p' $TEST_DIRECTORY/../notmuch.sym \| sort \| uniq > EXPORTED`
			`test_expect_equal_file EXPORTED ACTUAL`

tests: add a test for symbol hiding side effects The worry here is that a binary linking with libnotmuch might lose access to Xapian::Error symbols because libnotmuch hides them. We are careful here to create ./fakedb/.notmuch in order to trigger a Xapian exception, and not just a missing file check. Thanks to jrollins and amddragon for suggestions. (cherry picked from commit 66f37f5f6864a988f94ddb893e3a176af57f6c8e) 2011-06-22 13:58:01 +02:00			`test_done`