debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-21 18:38:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
notmuch/test/T310-emacs.sh

1002 lines
38 KiB
Bash
Raw Normal View History

test: change "#!/bin/bash" to "#!/usr/bin/env bash" enhances portability Change #!/bin/bash at start of tests to "#!/usr/bin/env bash". That way systems running on bash < 4 can prepend bash >= 4 to path before running the tests.
2010-12-01 21:27:52 +01:00
#!/usr/bin/env bash
test: set variables using `let' instead of `setq' in Emacs tests Using `setq' for setting variables in Emacs tests affect other tests that may run in the same Emacs environment. Currently it works because each test is run in a separate Emacs instance. But in the future multiple tests will run in a single Emacs instance. The patch changes all variables to use `let', so the scope of the change is limited to a single test.
2011-06-28 06:45:09 +02:00
test: Add the most rudimentary testing of the emacs interface. So far, this is doing nothing more than adding a corpus of email and ensuring that the `notmuch-hello' function produces the desired output.
2010-10-22 21:10:15 +02:00
test_description="emacs interface"
test: make script exit (1) if it "fails" to source (.) a file The files (test) scripts source (with builtin command `.`) provides information which the scripts depend, and without the `source` to succeed allowing script to continue may lead to dangerous situations (e.g. rm -rf "${undefined_variable}"/*). At the end of all source (.) lines construct ' || exit 1' was added; In our case the script script will exit if it cannot find (or read) the file to be sourced. Additionally script would also exits if the last command of the sourced file exited nonzero.
2015-08-06 11:13:36 +02:00
. ./test-lib.sh || exit 1
test: Add the most rudimentary testing of the emacs interface. So far, this is doing nothing more than adding a corpus of email and ensuring that the `notmuch-hello' function produces the desired output.
2010-10-22 21:10:15 +02:00
test:Improve test behaviors when --root is used Change add_email_corpus, emacs_deliver_message and tests to use $TEST_DIRECTORY instead of '..'. This improves the behavior of the usage of --root=<dir>, as the assumption of what '..' means will usually be incorrect. Document -root option in README and update valgrind to work with -root.
2011-06-29 00:11:32 +02:00
EXPECTED=$TEST_DIRECTORY/emacs.expected-output
test: Add tests for emacs notmuch-search and notmuch-show functions. Moving the expected output into individual files (rather than inline) to keep the test script much easier to read.
2010-10-23 01:32:38 +02:00
test: Add the most rudimentary testing of the emacs interface. So far, this is doing nothing more than adding a corpus of email and ensuring that the `notmuch-hello' function produces the desired output.
2010-10-22 21:10:15 +02:00
add_email_corpus
test: add test for syntax of emacs test library If there is a syntax error in the emacs test library, it causes other tests to hang or crash without a useful error message. This test could be eliminated if the error reporting for emacs tests was somehow improved.
2014-01-12 01:10:21 +01:00
# syntax errors in test-lib.el cause mysterious failures
test_expect_success 'Syntax of emacs test library' \
"${TEST_EMACS} -Q --batch --load $TEST_DIRECTORY/test-lib.el"
test: Add tests for emacs notmuch-search and notmuch-show functions. Moving the expected output into individual files (rather than inline) to keep the test script much easier to read.
2010-10-23 01:32:38 +02:00
test_begin_subtest "Basic notmuch-hello view in emacs"
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
test_emacs '(notmuch-hello)
test: save buffer content to file instead of printing it in Emacs tests Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
2011-06-28 06:45:06 +02:00
(test-output)'
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
test_expect_equal_file OUTPUT $EXPECTED/notmuch-hello
test: Add tests for emacs notmuch-search and notmuch-show functions. Moving the expected output into individual files (rather than inline) to keep the test script much easier to read.
2010-10-23 01:32:38 +02:00
test: Test emacs notmuch-hello when displaying a saved search with 0 results. This test verifies that the bug fix in the previous commit is working.
2010-10-30 00:49:59 +02:00
test_begin_subtest "Saved search with 0 results"
test: set variables using `let' instead of `setq' in Emacs tests Using `setq' for setting variables in Emacs tests affect other tests that may run in the same Emacs environment. Currently it works because each test is run in a separate Emacs instance. But in the future multiple tests will run in a single Emacs instance. The patch changes all variables to use `let', so the scope of the change is limited to a single test.
2011-06-28 06:45:09 +02:00
test_emacs '(let ((notmuch-show-empty-saved-searches t)
(notmuch-saved-searches
'\''(("inbox" . "tag:inbox")
("unread" . "tag:unread")
("empty" . "tag:doesnotexist"))))
(notmuch-hello)
(test-output))'
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
test_expect_equal_file OUTPUT $EXPECTED/notmuch-hello-with-empty
test: Test emacs notmuch-hello when displaying a saved search with 0 results. This test verifies that the bug fix in the previous commit is working.
2010-10-30 00:49:59 +02:00
test: Test emacs notmuch-hello with no saved searches to display. Haippily, this works just fine, but we might as well test that.
2010-10-30 00:53:34 +02:00
test_begin_subtest "No saved searches displayed (all with 0 results)"
test: set variables using `let' instead of `setq' in Emacs tests Using `setq' for setting variables in Emacs tests affect other tests that may run in the same Emacs environment. Currently it works because each test is run in a separate Emacs instance. But in the future multiple tests will run in a single Emacs instance. The patch changes all variables to use `let', so the scope of the change is limited to a single test.
2011-06-28 06:45:09 +02:00
test_emacs '(let ((notmuch-saved-searches
'\''(("empty" . "tag:doesnotexist"))))
(notmuch-hello)
(test-output))'
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
test_expect_equal_file OUTPUT $EXPECTED/notmuch-hello-no-saved-searches
test: Test emacs notmuch-hello with no saved searches to display. Haippily, this works just fine, but we might as well test that.
2010-10-30 00:53:34 +02:00
test: Add tests for emacs notmuch-search and notmuch-show functions. Moving the expected output into individual files (rather than inline) to keep the test script much easier to read.
2010-10-23 01:32:38 +02:00
test_begin_subtest "Basic notmuch-search view in emacs"
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
test_emacs '(notmuch-search "tag:inbox")
(notmuch-test-wait)
test: save buffer content to file instead of printing it in Emacs tests Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
2011-06-28 06:45:06 +02:00
(test-output)'
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
test_expect_equal_file OUTPUT $EXPECTED/notmuch-search-tag-inbox
test: Add tests for emacs notmuch-search and notmuch-show functions. Moving the expected output into individual files (rather than inline) to keep the test script much easier to read.
2010-10-23 01:32:38 +02:00
test: New test for incremental search output parsing This advises the search process filter to make it process one character at a time in order to test the pessimal case for incremental search output parsing. The text parser fails this test because it gets tricked into thinking a parenthetical remark in a subject is the tag list.
2012-07-09 23:42:39 +02:00
test_begin_subtest "Incremental parsing of search results"
test_emacs "(ad-enable-advice 'notmuch-search-process-filter 'around 'pessimal)
(ad-activate 'notmuch-search-process-filter)
(notmuch-search \"tag:inbox\")
(notmuch-test-wait)
(ad-disable-advice 'notmuch-search-process-filter 'around 'pessimal)
(ad-activate 'notmuch-search-process-filter)
(test-output)"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-search-tag-inbox
test: Clear the "BROKEN" flag on an existing emacs test I still don't know everything about how I want search order to be customizable, but I do like the current defaults, (namely, performing a new search gives results newest first, but performing a saved search like "tag:inbox" gives results as oldest first). Until we come up with a better plan for people to select what *they* want, (rather than just getting what I want), let's codify the current results in the test suite.
2010-11-05 21:59:45 +01:00
test_begin_subtest "Navigation of notmuch-hello to search results"
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
test_emacs '(notmuch-hello)
(goto-char (point-min))
(re-search-forward "inbox")
emacs: get rid of trailing spaces in notmuch-hello view This patch removes trailing spaces in notmuch-hello view. A side effect of this change is that tag/query buttons no longer include a space at the end. This means that pressing RET when the point is at the first character after the tag/query button no longer works (note that this is the standard behavior for buttons). We may change this behavior in the future (without adding trailing spaces back) if people would find this change inconvenient.
2012-03-10 04:54:15 +01:00
(widget-button-press (1- (point)))
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
(notmuch-test-wait)
test: save buffer content to file instead of printing it in Emacs tests Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
2011-06-28 06:45:06 +02:00
(test-output)'
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
test_expect_equal_file OUTPUT $EXPECTED/notmuch-hello-view-inbox
test: Add simple tests for navigating notmuch-hello and notmuch-search views We simulate the act of selecting the "inbox" saved search from notmuch-hello and the act of selecting a desired thread from the notmuch-search results. The test for the navigation of notmuch-hello is currently marked as BROKEN since its output is in the opposite order compared to the '(notmuch-search "tag:inbox")' test. This question of ordering is a currently open issue on the notmuch mailing list, so we'll let the test suite reflect that for now. Finally, this commit also abstracts some common emacs lisp code, (waiting for the current buffer's process to complete), into a new notmuch-test-wait function that is made available to anything calling test_emacs.
2010-10-23 02:02:07 +02:00
test: Add tests for emacs notmuch-search and notmuch-show functions. Moving the expected output into individual files (rather than inline) to keep the test script much easier to read.
2010-10-23 01:32:38 +02:00
test_begin_subtest "Basic notmuch-show view in emacs"
test: Avoid using unreliable, hard-coded thread ID values in test suite. Some recently-added tests used hard-coded thread ID values in search specifications. This is unreliable since the thread IDs depend on the order in which "notmuch new" encounters new files, (which in turn can depend on inode ordering within the filesystem). Fix these by using the new "notmuch search --output=threads" to find the correct thread IDs given a hard-coded (but reliable) message ID.
2010-10-28 20:45:50 +02:00
maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
test_emacs "(notmuch-show \"$maildir_storage_thread\")
test: save buffer content to file instead of printing it in Emacs tests Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
2011-06-28 06:45:06 +02:00
(test-output)"
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
test: Add the most rudimentary testing of the emacs interface. So far, this is doing nothing more than adding a corpus of email and ensuring that the `notmuch-hello' function produces the desired output.
2010-10-22 21:10:15 +02:00
emacs: test notmuch-indent-messages-width default Previous behaviour was to indent messages in a thread according to depth by one space per level. This is still the case with notmuch-indent-messages-width default value `1'. This test succeeds if output with default value is same as in "Basic notmuch-show view in emacs".
2011-11-24 23:03:22 +01:00
test_begin_subtest "Basic notmuch-show view in emacs default indentation"
maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
emacs: fix notmuch-show-indent-messages-width customization variable name The name was originally notmuch-indent-messages-width, which is inconsistent with our variable naming convention.
2012-01-02 23:23:02 +01:00
test_emacs "(let ((notmuch-show-indent-messages-width 1))
emacs: test notmuch-indent-messages-width default Previous behaviour was to indent messages in a thread according to depth by one space per level. This is still the case with notmuch-indent-messages-width default value `1'. This test succeeds if output with default value is same as in "Basic notmuch-show view in emacs".
2011-11-24 23:03:22 +01:00
(notmuch-show \"$maildir_storage_thread\")
(test-output))"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
emacs: test: notmuch show without indentation Previous behaviour was to indent messages in a thread according to depth by one space per level. In id:1311028119-50637-1-git-send-email-fgeller@gmail.com Felix Geller proposed a patch in order to turn indentation off. This commit tests if instead setting notmuch-indent-messages-width to `0' does turn off indentation.
2011-11-24 23:03:23 +01:00
test_begin_subtest "Basic notmuch-show view in emacs without indentation"
maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
emacs: fix notmuch-show-indent-messages-width customization variable name The name was originally notmuch-indent-messages-width, which is inconsistent with our variable naming convention.
2012-01-02 23:23:02 +01:00
test_emacs "(let ((notmuch-show-indent-messages-width 0))
emacs: test: notmuch show without indentation Previous behaviour was to indent messages in a thread according to depth by one space per level. In id:1311028119-50637-1-git-send-email-fgeller@gmail.com Felix Geller proposed a patch in order to turn indentation off. This commit tests if instead setting notmuch-indent-messages-width to `0' does turn off indentation.
2011-11-24 23:03:23 +01:00
(notmuch-show \"$maildir_storage_thread\")
(test-output))"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage-without-indentation
emacs: test notmuch show with fourfold message indentation Previous behaviour was to indent messages in a thread according to depth by one space per level. This commit tests if setting notmuch-indent-messages-width to `4' provides a message thread with four spaces of indentation thread depth.
2011-11-24 23:03:24 +01:00
test_begin_subtest "Basic notmuch-show view in emacs with fourfold indentation"
maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
emacs: fix notmuch-show-indent-messages-width customization variable name The name was originally notmuch-indent-messages-width, which is inconsistent with our variable naming convention.
2012-01-02 23:23:02 +01:00
test_emacs "(let ((notmuch-show-indent-messages-width 4))
emacs: test notmuch show with fourfold message indentation Previous behaviour was to indent messages in a thread according to depth by one space per level. This commit tests if setting notmuch-indent-messages-width to `4' provides a message thread with four spaces of indentation thread depth.
2011-11-24 23:03:24 +01:00
(notmuch-show \"$maildir_storage_thread\")
(test-output))"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage-with-fourfold-indentation
test: add "notmuch-show for message with invalid From" test
2011-05-12 15:56:26 +02:00
test_begin_subtest "notmuch-show for message with invalid From"
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
add_message "[subject]=\"message-with-invalid-from\"" \
"[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
test: add "notmuch-show for message with invalid From" test
2011-05-12 15:56:26 +02:00
thread=$(notmuch search --output=threads subject:message-with-invalid-from)
test: save buffer content to file instead of printing it in Emacs tests Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
2011-06-28 06:45:06 +02:00
test_emacs "(notmuch-show \"$thread\")
test: sanitize dates in emacs, raw, and text output add a new function notmuch_date_sanitize for rfc822-ish things. Add date sanitization to notmuch_show_sanitize_all and use it more places. This is all in aid of a transition to unique timestamps on messages.
2013-12-08 15:52:41 +01:00
(test-output \"OUTPUT.raw\")"
test: save buffer content to file instead of printing it in Emacs tests Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
2011-06-28 06:45:06 +02:00
cat <<EOF >EXPECTED
show: Unify JSON header output for messages and message parts This has three ramifications: - Blank To and Cc headers are no longer output for messages. - Dates are now canonicalized for messages, which means they always have a day of the week and GMT is printed +0000 (never -0000) - Invalid From message headers are handled slightly differently, since they get parsed by GMime now instead of notmuch.
2012-02-20 01:26:26 +01:00
"Invalid " (2001-01-05) (inbox)
test: add "notmuch-show for message with invalid From" test
2011-05-12 15:56:26 +02:00
Subject: message-with-invalid-from
To: Notmuch Test Suite <test_suite@notmuchmail.org>
test: sanitize dates in emacs, raw, and text output add a new function notmuch_date_sanitize for rfc822-ish things. Add date sanitization to notmuch_show_sanitize_all and use it more places. This is all in aid of a transition to unique timestamps on messages.
2013-12-08 15:52:41 +01:00
Date: GENERATED_DATE
test: add "notmuch-show for message with invalid From" test
2011-05-12 15:56:26 +02:00
test: save buffer content to file instead of printing it in Emacs tests Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
2011-06-28 06:45:06 +02:00
This is just a test message (#1)
EOF
test: sanitize dates in emacs, raw, and text output add a new function notmuch_date_sanitize for rfc822-ish things. Add date sanitization to notmuch_show_sanitize_all and use it more places. This is all in aid of a transition to unique timestamps on messages.
2013-12-08 15:52:41 +01:00
notmuch_date_sanitize < OUTPUT.raw > OUTPUT
test: save buffer content to file instead of printing it in Emacs tests Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
2011-06-28 06:45:06 +02:00
test_expect_equal_file OUTPUT EXPECTED
test: add "notmuch-show for message with invalid From" test
2011-05-12 15:56:26 +02:00
test: Add simple tests for navigating notmuch-hello and notmuch-search views We simulate the act of selecting the "inbox" saved search from notmuch-hello and the act of selecting a desired thread from the notmuch-search results. The test for the navigation of notmuch-hello is currently marked as BROKEN since its output is in the opposite order compared to the '(notmuch-search "tag:inbox")' test. This question of ordering is a currently open issue on the notmuch mailing list, so we'll let the test suite reflect that for now. Finally, this commit also abstracts some common emacs lisp code, (waiting for the current buffer's process to complete), into a new notmuch-test-wait function that is made available to anything calling test_emacs.
2010-10-23 02:02:07 +02:00
test_begin_subtest "Navigation of notmuch-search to thread view"
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
test_emacs '(notmuch-search "tag:inbox")
(notmuch-test-wait)
(goto-char (point-min))
(re-search-forward "Working with Maildir")
(notmuch-search-show-thread)
(notmuch-test-wait)
test: save buffer content to file instead of printing it in Emacs tests Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
2011-06-28 06:45:06 +02:00
(test-output)'
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
test: Add simple tests for navigating notmuch-hello and notmuch-search views We simulate the act of selecting the "inbox" saved search from notmuch-hello and the act of selecting a desired thread from the notmuch-search results. The test for the navigation of notmuch-hello is currently marked as BROKEN since its output is in the opposite order compared to the '(notmuch-search "tag:inbox")' test. This question of ordering is a currently open issue on the notmuch mailing list, so we'll let the test suite reflect that for now. Finally, this commit also abstracts some common emacs lisp code, (waiting for the current buffer's process to complete), into a new notmuch-test-wait function that is made available to anything calling test_emacs.
2010-10-23 02:02:07 +02:00
test: Add tests for adding/removing tags within emacs interface Exercising both the notmuch-search and notmuch-show views.
2010-10-23 02:17:00 +02:00
test_begin_subtest "Add tag from search view"
test: Avoid using unreliable, hard-coded thread ID values in test suite. Some recently-added tests used hard-coded thread ID values in search specifications. This is unreliable since the thread IDs depend on the order in which "notmuch new" encounters new files, (which in turn can depend on inode ordering within the filesystem). Fix these by using the new "notmuch search --output=threads" to find the correct thread IDs given a hard-coded (but reliable) message ID.
2010-10-28 20:45:50 +02:00
os_x_darwin_thread=$(notmuch search --output=threads id:ddd65cda0911171950o4eea4389v86de9525e46052d3@mail.gmail.com)
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
test_emacs "(notmuch-search \"$os_x_darwin_thread\")
(notmuch-test-wait)
test: fix emacs tests after tagging operations changes After the recent tagging operations changes, functions bound to "+" and "-" in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly.
2012-02-05 08:13:46 +01:00
(execute-kbd-macro \"+tag-from-search-view\")"
test: Avoid using unreliable, hard-coded thread ID values in test suite. Some recently-added tests used hard-coded thread ID values in search specifications. This is unreliable since the thread IDs depend on the order in which "notmuch new" encounters new files, (which in turn can depend on inode ordering within the filesystem). Fix these by using the new "notmuch search --output=threads" to find the correct thread IDs given a hard-coded (but reliable) message ID.
2010-10-28 20:45:50 +02:00
output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)
test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox tag-from-search-view unread)"
test: Add tests for adding/removing tags within emacs interface Exercising both the notmuch-search and notmuch-show views.
2010-10-23 02:17:00 +02:00
test_begin_subtest "Remove tag from search view"
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
test_emacs "(notmuch-search \"$os_x_darwin_thread\")
(notmuch-test-wait)
test: fix emacs tests after tagging operations changes After the recent tagging operations changes, functions bound to "+" and "-" in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly.
2012-02-05 08:13:46 +01:00
(execute-kbd-macro \"-tag-from-search-view\")"
test: Avoid using unreliable, hard-coded thread ID values in test suite. Some recently-added tests used hard-coded thread ID values in search specifications. This is unreliable since the thread IDs depend on the order in which "notmuch new" encounters new files, (which in turn can depend on inode ordering within the filesystem). Fix these by using the new "notmuch search --output=threads" to find the correct thread IDs given a hard-coded (but reliable) message ID.
2010-10-28 20:45:50 +02:00
output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)
test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"
test: Add tests for adding/removing tags within emacs interface Exercising both the notmuch-search and notmuch-show views.
2010-10-23 02:17:00 +02:00
emacs: Use notmuch tag --batch for large tag queries (Unfortunately, it's difficult to first demonstrate this problem with a known-broken test because modern Linux kernels have argument length limits in the megabytes, which makes Emacs really slow!)
2013-10-24 17:19:07 +02:00
test_begin_subtest "Add tag (large query)"
# We use a long query to force us into batch mode and use a funny tag
# that requires escaping for batch tagging.
test: replace single giant term with large phrase We only need a long string, not a single long term to trigger batch mode. The giant term triggers a bug/incompatibility in Xapian 1.3.4 that throws an exception because it is longer than the Xapian term size limit.
2016-01-29 12:53:11 +01:00
test_emacs "(notmuch-tag (concat \"$os_x_darwin_thread\" \" or \" (mapconcat #'identity (make-list notmuch-tag-argument-limit \"x\") \"-\")) (list \"+tag-from-%-large-query\"))"
emacs: Use notmuch tag --batch for large tag queries (Unfortunately, it's difficult to first demonstrate this problem with a known-broken test because modern Linux kernels have argument length limits in the megabytes, which makes Emacs really slow!)
2013-10-24 17:19:07 +02:00
output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)
test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox tag-from-%-large-query unread)"
notmuch tag -tag-from-%-large-query $os_x_darwin_thread
test: emacs: new tests "notmuch-show: {add,remove} multiple tags {to,from} single message" * test/emacs: - Rename subtests "{Add,Remove} tag from notmuch-show view" to "notmuch-show: {add,remove} single tag {to,from} single message" to be consistent with the following tests. - New subtest "notmuch-show: add multiple tags to single message": `notmuch-show-add-tag' ("+") can add multiple tags to a message. - New subtest "notmuch-show: remove multiple tags from single message": `notmuch-show-remove-tag' ("-") can remove multiple tags from a message.
2012-02-24 23:30:35 +01:00
test_begin_subtest "notmuch-show: add single tag to single message"
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
test_emacs "(notmuch-show \"$os_x_darwin_thread\")
test: fix emacs tests after tagging operations changes After the recent tagging operations changes, functions bound to "+" and "-" in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly.
2012-02-05 08:13:46 +01:00
(execute-kbd-macro \"+tag-from-show-view\")"
test: Avoid using unreliable, hard-coded thread ID values in test suite. Some recently-added tests used hard-coded thread ID values in search specifications. This is unreliable since the thread IDs depend on the order in which "notmuch new" encounters new files, (which in turn can depend on inode ordering within the filesystem). Fix these by using the new "notmuch search --output=threads" to find the correct thread IDs given a hard-coded (but reliable) message ID.
2010-10-28 20:45:50 +02:00
output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)
test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox tag-from-show-view unread)"
test: Add tests for adding/removing tags within emacs interface Exercising both the notmuch-search and notmuch-show views.
2010-10-23 02:17:00 +02:00
test: emacs: new tests "notmuch-show: {add,remove} multiple tags {to,from} single message" * test/emacs: - Rename subtests "{Add,Remove} tag from notmuch-show view" to "notmuch-show: {add,remove} single tag {to,from} single message" to be consistent with the following tests. - New subtest "notmuch-show: add multiple tags to single message": `notmuch-show-add-tag' ("+") can add multiple tags to a message. - New subtest "notmuch-show: remove multiple tags from single message": `notmuch-show-remove-tag' ("-") can remove multiple tags from a message.
2012-02-24 23:30:35 +01:00
test_begin_subtest "notmuch-show: remove single tag from single message"
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
test_emacs "(notmuch-show \"$os_x_darwin_thread\")
test: fix emacs tests after tagging operations changes After the recent tagging operations changes, functions bound to "+" and "-" in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly.
2012-02-05 08:13:46 +01:00
(execute-kbd-macro \"-tag-from-show-view\")"
test: Avoid using unreliable, hard-coded thread ID values in test suite. Some recently-added tests used hard-coded thread ID values in search specifications. This is unreliable since the thread IDs depend on the order in which "notmuch new" encounters new files, (which in turn can depend on inode ordering within the filesystem). Fix these by using the new "notmuch search --output=threads" to find the correct thread IDs given a hard-coded (but reliable) message ID.
2010-10-28 20:45:50 +02:00
output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)
test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"
test: Add tests for adding/removing tags within emacs interface Exercising both the notmuch-search and notmuch-show views.
2010-10-23 02:17:00 +02:00
test: emacs: new tests "notmuch-show: {add,remove} multiple tags {to,from} single message" * test/emacs: - Rename subtests "{Add,Remove} tag from notmuch-show view" to "notmuch-show: {add,remove} single tag {to,from} single message" to be consistent with the following tests. - New subtest "notmuch-show: add multiple tags to single message": `notmuch-show-add-tag' ("+") can add multiple tags to a message. - New subtest "notmuch-show: remove multiple tags from single message": `notmuch-show-remove-tag' ("-") can remove multiple tags from a message.
2012-02-24 23:30:35 +01:00
test_begin_subtest "notmuch-show: add multiple tags to single message"
test_emacs "(notmuch-show \"$os_x_darwin_thread\")
(execute-kbd-macro \"+tag1-from-show-view +tag2-from-show-view\")"
output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)
test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox tag1-from-show-view tag2-from-show-view unread)"
test_begin_subtest "notmuch-show: remove multiple tags from single message"
test_emacs "(notmuch-show \"$os_x_darwin_thread\")
(execute-kbd-macro \"-tag1-from-show-view -tag2-from-show-view\")"
output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)
test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"
emacs: Fix quoting of Message-Id to fix test case of Id containing ".." If Xapian sees unquoted ".." as in id:123..456 then it thinks that's a range specification. We avoid this problem by instead passing id:"123..456" to Xapian.
2010-10-23 02:41:40 +02:00
test_begin_subtest "Message with .. in Message-Id:"
test: Add test demonstrating failure in emacs interface when Message-Id has .. Thanks to Jameson Rollins for pointing out this bug (id:87y6g7zr6q.fsf@servo.finestructure.net).
2010-10-23 02:28:14 +02:00
add_message [id]=123..456@example '[subject]="Message with .. in Message-Id"'
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
test_emacs '(notmuch-search "id:\"123..456@example\"")
(notmuch-test-wait)
test: fix emacs tests after tagging operations changes After the recent tagging operations changes, functions bound to "+" and "-" in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly.
2012-02-05 08:13:46 +01:00
(execute-kbd-macro "+search-add")
(execute-kbd-macro "+search-remove")
(execute-kbd-macro "-search-remove")
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
(notmuch-show "id:\"123..456@example\"")
(notmuch-test-wait)
test: fix emacs tests after tagging operations changes After the recent tagging operations changes, functions bound to "+" and "-" in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly.
2012-02-05 08:13:46 +01:00
(execute-kbd-macro "+show-add")
(execute-kbd-macro "+show-remove")
(execute-kbd-macro "-show-remove")'
test: Add test demonstrating failure in emacs interface when Message-Id has .. Thanks to Jameson Rollins for pointing out this bug (id:87y6g7zr6q.fsf@servo.finestructure.net).
2010-10-23 02:28:14 +02:00
output=$(notmuch search 'id:"123..456@example"' | notmuch_search_sanitize)
emacs: Fix quoting of Message-Id to fix test case of Id containing ".." If Xapian sees unquoted ".." as in id:123..456 then it thinks that's a range specification. We avoid this problem by instead passing id:"123..456" to Xapian.
2010-10-23 02:41:40 +02:00
test_expect_equal "$output" "thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Message with .. in Message-Id (inbox search-add show-add)"
test: Add test demonstrating failure in emacs interface when Message-Id has .. Thanks to Jameson Rollins for pointing out this bug (id:87y6g7zr6q.fsf@servo.finestructure.net).
2010-10-23 02:28:14 +02:00
test: Add Emacs test for messages with quotes in their message ID Currently this is broken because Emacs doesn't properly escape double quotes in message IDs.
2012-03-27 03:37:15 +02:00
test_begin_subtest "Message with quote in Message-Id:"
add_message '[id]="\"quote\"@example"' '[subject]="Message with quote in Message-Id"'
test_emacs '(notmuch-search "subject:\"Message with quote\"")
(notmuch-test-wait)
(execute-kbd-macro "+search-add")
(notmuch-search-show-thread)
(notmuch-test-wait)
(execute-kbd-macro "+show-add")'
output=$(notmuch search 'id:"""quote""@example"' | notmuch_search_sanitize)
test_expect_equal "$output" "thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Message with quote in Message-Id (inbox search-add show-add)"
test: revert non-intentional changes introduced in eb4cf465 eb4cf465 introduces changes which weren't part of the submitted patch (id:"87liwlip2j.fsf@gmail.com"), presumably made during resolving merge conflicts. The first one causes the title of a test to be printed a second time, in place of the correct title: PASS Message with .. in Message-Id: PASS Message with .. in Message-Id: instead of: PASS Message with .. in Message-Id: PASS Sending a message via (fake) SMTP The second one is simply the insertion of a line break, so no harm there. This commit reverts both changes, as they were clearly accidental. Signed-off-by: Pieter Praet <pieter@praet.org>
2011-06-29 22:23:47 +02:00
test_begin_subtest "Sending a message via (fake) SMTP"
test: use emacs_deliver_message in Emacs SMTP send test Minor changes to expected results of other Emacs tests were needed because the message Date header changed.
2011-06-28 06:45:08 +02:00
emacs_deliver_message \
'Testing message sent via SMTP' \
'This is a test that messages are sent via SMTP' \
'(message-goto-to)
(kill-whole-line)
(insert "To: user@example.com\n")'
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
sed \
test: Add test that emacs interface actually sends mail. Rather than *reall* sending mail here, we instead have a new test program, smtp-dummy which implements (a small piece of) the server-side SMTP protocol and saves a mail message to the filename provided. This gives us reasonable test coverage of a large chunk of the notmuch+emacs code base (down to talking to an SMTP server with the final mail contents).
2010-10-27 19:42:46 +02:00
-e s',^User-Agent: Notmuch/.* Emacs/.*,User-Agent: Notmuch/XXX Emacs/XXX,' \
test: canonicalize content-type in "Sending a message via (fake) SMTP" The version of message.el in emacs24 omits the charset=us-ascii, causing the current version of this test to fail. With this patch, we accept either option. According to RFC 2046, they are semantically equivalent.
2012-08-30 03:09:54 +02:00
-e s',^Message-ID: <.*>$,Message-ID: <XXX>,' \
-e s',^\(Content-Type: text/plain\); charset=us-ascii$,\1,' < sent_message >OUTPUT
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
cat <<EOF >EXPECTED
From: Notmuch Test Suite <test_suite@notmuchmail.org>
test: Add test that emacs interface actually sends mail. Rather than *reall* sending mail here, we instead have a new test program, smtp-dummy which implements (a small piece of) the server-side SMTP protocol and saves a mail message to the filename provided. This gives us reasonable test coverage of a large chunk of the notmuch+emacs code base (down to talking to an SMTP server with the final mail contents).
2010-10-27 19:42:46 +02:00
To: user@example.com
Subject: Testing message sent via SMTP
test: use emacs_deliver_message in Emacs SMTP send test Minor changes to expected results of other Emacs tests were needed because the message Date header changed.
2011-06-28 06:45:08 +02:00
Date: 01 Jan 2000 12:00:00 -0000
test: Add test that emacs interface actually sends mail. Rather than *reall* sending mail here, we instead have a new test program, smtp-dummy which implements (a small piece of) the server-side SMTP protocol and saves a mail message to the filename provided. This gives us reasonable test coverage of a large chunk of the notmuch+emacs code base (down to talking to an SMTP server with the final mail contents).
2010-10-27 19:42:46 +02:00
User-Agent: Notmuch/XXX Emacs/XXX
Message-ID: <XXX>
MIME-Version: 1.0
test: canonicalize content-type in "Sending a message via (fake) SMTP" The version of message.el in emacs24 omits the charset=us-ascii, causing the current version of this test to fail. With this patch, we accept either option. According to RFC 2046, they are semantically equivalent.
2012-08-30 03:09:54 +02:00
Content-Type: text/plain
test: Add test that emacs interface actually sends mail. Rather than *reall* sending mail here, we instead have a new test program, smtp-dummy which implements (a small piece of) the server-side SMTP protocol and saves a mail message to the filename provided. This gives us reasonable test coverage of a large chunk of the notmuch+emacs code base (down to talking to an SMTP server with the final mail contents).
2010-10-27 19:42:46 +02:00
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
This is a test that messages are sent via SMTP
EOF
test_expect_equal_file OUTPUT EXPECTED
test: Add test that emacs interface actually sends mail. Rather than *reall* sending mail here, we instead have a new test program, smtp-dummy which implements (a small piece of) the server-side SMTP protocol and saves a mail message to the filename provided. This gives us reasonable test coverage of a large chunk of the notmuch+emacs code base (down to talking to an SMTP server with the final mail contents).
2010-10-27 19:42:46 +02:00
test: Add test for fully-roundtripped FCC We test that the message we sent via (fake) SMTP is included in the mail index after a "notmuch new". This verifies that the FCC setting indeed successfully saved the sent message within the notmuch mail store.
2010-10-28 02:08:09 +02:00
test_begin_subtest "Verify that sent messages are saved/searchable (via FCC)"
notmuch new > /dev/null
output=$(notmuch search 'subject:"testing message sent via SMTP"' | notmuch_search_sanitize)
test: use emacs_deliver_message in Emacs SMTP send test Minor changes to expected results of other Emacs tests were needed because the message Date header changed.
2011-06-28 06:45:08 +02:00
test_expect_equal "$output" "thread:XXX 2000-01-01 [1/1] Notmuch Test Suite; Testing message sent via SMTP (inbox)"
test: Add test for fully-roundtripped FCC We test that the message we sent via (fake) SMTP is included in the mail index after a "notmuch new". This verifies that the FCC setting indeed successfully saved the sent message within the notmuch mail store.
2010-10-28 02:08:09 +02:00
test: Test emacs message composing with various values for notmuch-fcc-dirs We exercise each of the documented values (nil, a string, and a list). For the list, we test matching a specific entry, matching a catch-all regular expression, and no match at all (in which case there is no FCC set).
2011-06-24 00:10:31 +02:00
test_begin_subtest "notmuch-fcc-dirs set to nil"
test: set variables using `let' instead of `setq' in Emacs tests Using `setq' for setting variables in Emacs tests affect other tests that may run in the same Emacs environment. Currently it works because each test is run in a separate Emacs instance. But in the future multiple tests will run in a single Emacs instance. The patch changes all variables to use `let', so the scope of the change is limited to a single test.
2011-06-28 06:45:09 +02:00
test_emacs "(let ((notmuch-fcc-dirs nil))
(notmuch-mua-mail)
(test-output))"
test: Test emacs message composing with various values for notmuch-fcc-dirs We exercise each of the documented values (nil, a string, and a list). For the list, we test matching a specific entry, matching a catch-all regular expression, and no match at all (in which case there is no FCC set).
2011-06-24 00:10:31 +02:00
cat <<EOF >EXPECTED
From: Notmuch Test Suite <test_suite@notmuchmail.org>
To:
Subject:
--text follows this line--
EOF
test_expect_equal_file OUTPUT EXPECTED
# Make another FCC maildir specific for the next test
mkdir -p mail/sent-string/cur
mkdir -p mail/sent-string/new
mkdir -p mail/sent-string/tmp
test_begin_subtest "notmuch-fcc-dirs set to a string"
test: set variables using `let' instead of `setq' in Emacs tests Using `setq' for setting variables in Emacs tests affect other tests that may run in the same Emacs environment. Currently it works because each test is run in a separate Emacs instance. But in the future multiple tests will run in a single Emacs instance. The patch changes all variables to use `let', so the scope of the change is limited to a single test.
2011-06-28 06:45:09 +02:00
test_emacs "(let ((notmuch-fcc-dirs \"sent-string\"))
(notmuch-mua-mail)
(test-output))"
test: Test emacs message composing with various values for notmuch-fcc-dirs We exercise each of the documented values (nil, a string, and a list). For the list, we test matching a specific entry, matching a catch-all regular expression, and no match at all (in which case there is no FCC set).
2011-06-24 00:10:31 +02:00
cat <<EOF >EXPECTED
From: Notmuch Test Suite <test_suite@notmuchmail.org>
To:
Subject:
Fcc: ${MAIL_DIR}/sent-string
--text follows this line--
EOF
test_expect_equal_file OUTPUT EXPECTED
# Make more FCC maildirs specific for the next test
mkdir -p mail/sent-list-match/cur
mkdir -p mail/sent-list-match/new
mkdir -p mail/sent-list-match/tmp
mkdir -p mail/failure/cur
mkdir -p mail/failure/new
mkdir -p mail/failure/tmp
test_begin_subtest "notmuch-fcc-dirs set to a list (with match)"
test: set variables using `let' instead of `setq' in Emacs tests Using `setq' for setting variables in Emacs tests affect other tests that may run in the same Emacs environment. Currently it works because each test is run in a separate Emacs instance. But in the future multiple tests will run in a single Emacs instance. The patch changes all variables to use `let', so the scope of the change is limited to a single test.
2011-06-28 06:45:09 +02:00
test_emacs "(let ((notmuch-fcc-dirs
'((\"notmuchmail.org\" . \"sent-list-match\")
(\".*\" . \"failure\"))))
(notmuch-mua-mail)
(test-output))"
test: Test emacs message composing with various values for notmuch-fcc-dirs We exercise each of the documented values (nil, a string, and a list). For the list, we test matching a specific entry, matching a catch-all regular expression, and no match at all (in which case there is no FCC set).
2011-06-24 00:10:31 +02:00
cat <<EOF >EXPECTED
From: Notmuch Test Suite <test_suite@notmuchmail.org>
To:
Subject:
Fcc: ${MAIL_DIR}/sent-list-match
--text follows this line--
EOF
test_expect_equal_file OUTPUT EXPECTED
# Make another FCC maildir specific for the next test
mkdir -p mail/sent-list-catch-all/cur
mkdir -p mail/sent-list-catch-all/new
mkdir -p mail/sent-list-catch-all/tmp
test: whitespace-cleanup for most test/* files Used emacs (whitespace-cleanup) function to "cleanup blank problems" in test files where that could be done without breaking tests; test/emacs was partially, and test/multipart was fully reverted.
2012-01-11 17:53:59 +01:00
test: Test emacs message composing with various values for notmuch-fcc-dirs We exercise each of the documented values (nil, a string, and a list). For the list, we test matching a specific entry, matching a catch-all regular expression, and no match at all (in which case there is no FCC set).
2011-06-24 00:10:31 +02:00
test_begin_subtest "notmuch-fcc-dirs set to a list (catch-all)"
test: set variables using `let' instead of `setq' in Emacs tests Using `setq' for setting variables in Emacs tests affect other tests that may run in the same Emacs environment. Currently it works because each test is run in a separate Emacs instance. But in the future multiple tests will run in a single Emacs instance. The patch changes all variables to use `let', so the scope of the change is limited to a single test.
2011-06-28 06:45:09 +02:00
test_emacs "(let ((notmuch-fcc-dirs
'((\"example.com\" . \"failure\")
(\".*\" . \"sent-list-catch-all\"))))
(notmuch-mua-mail)
(test-output))"
test: Test emacs message composing with various values for notmuch-fcc-dirs We exercise each of the documented values (nil, a string, and a list). For the list, we test matching a specific entry, matching a catch-all regular expression, and no match at all (in which case there is no FCC set).
2011-06-24 00:10:31 +02:00
cat <<EOF >EXPECTED
From: Notmuch Test Suite <test_suite@notmuchmail.org>
To:
Subject:
Fcc: ${MAIL_DIR}/sent-list-catch-all
--text follows this line--
EOF
test_expect_equal_file OUTPUT EXPECTED
test_begin_subtest "notmuch-fcc-dirs set to a list (no match)"
test: set variables using `let' instead of `setq' in Emacs tests Using `setq' for setting variables in Emacs tests affect other tests that may run in the same Emacs environment. Currently it works because each test is run in a separate Emacs instance. But in the future multiple tests will run in a single Emacs instance. The patch changes all variables to use `let', so the scope of the change is limited to a single test.
2011-06-28 06:45:09 +02:00
test_emacs "(let ((notmuch-fcc-dirs
'((\"example.com\" . \"failure\")
(\"nomatchhere.net\" . \"failure\"))))
(notmuch-mua-mail)
(test-output))"
test: Test emacs message composing with various values for notmuch-fcc-dirs We exercise each of the documented values (nil, a string, and a list). For the list, we test matching a specific entry, matching a catch-all regular expression, and no match at all (in which case there is no FCC set).
2011-06-24 00:10:31 +02:00
cat <<EOF >EXPECTED
From: Notmuch Test Suite <test_suite@notmuchmail.org>
To:
Subject:
--text follows this line--
EOF
test_expect_equal_file OUTPUT EXPECTED
test: Add test for reply functionality within emacs. The reply is primarily taken care of by "notmuch reply" which is already thoroughly tested. But a recent bug is inserting a duplicate From header in the emacs-based reply. So exercise that bug here.
2010-10-28 03:43:09 +02:00
test_begin_subtest "Reply within emacs"
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
test_emacs '(let ((message-hidden-headers ''()))
(notmuch-search "subject:\"testing message sent via SMTP\"")
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
(notmuch-test-wait)
(notmuch-search-reply-to-thread)
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
(test-output))'
test: save buffer content to file instead of printing it in Emacs tests Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
2011-06-28 06:45:06 +02:00
sed -i -e 's/^In-Reply-To: <.*>$/In-Reply-To: <XXX>/' OUTPUT
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
sed -i -e 's/^References: <.*>$/References: <XXX>/' OUTPUT
sed -i -e 's,^User-Agent: Notmuch/.* Emacs/.*,User-Agent: Notmuch/XXX Emacs/XXX,' OUTPUT
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
cat <<EOF >EXPECTED
From: Notmuch Test Suite <test_suite@notmuchmail.org>
test: Add test for reply functionality within emacs. The reply is primarily taken care of by "notmuch reply" which is already thoroughly tested. But a recent bug is inserting a duplicate From header in the emacs-based reply. So exercise that bug here.
2010-10-28 03:43:09 +02:00
To: user@example.com
Subject: Re: Testing message sent via SMTP
In-Reply-To: <XXX>
test: replace occurrences of $PWD with vars that are more stable Thanks to Dmitry Kurochkin <dmitry.kurochkin@gmail.com> for pointing this out: id:"87d39ymyb4.fsf@gmail.com"
2012-02-01 21:37:21 +01:00
Fcc: ${MAIL_DIR}/sent
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
References: <XXX>
User-Agent: Notmuch/XXX Emacs/XXX
test: Add test for reply functionality within emacs. The reply is primarily taken care of by "notmuch reply" which is already thoroughly tested. But a recent bug is inserting a duplicate From header in the emacs-based reply. So exercise that bug here.
2010-10-28 03:43:09 +02:00
--text follows this line--
emacs: Use the new JSON reply format and message-cite-original Use the new JSON reply format to create replies in emacs. Quote HTML parts nicely by using mm-display-part to turn them into displayable text, then quoting them with message-cite-original. This is very useful for users who regularly receive HTML-only email. Use message-mode's message-cite-original function to create the quoted body for reply messages. In order to make this act like the existing notmuch defaults, you will need to set the following in your emacs configuration: message-citation-line-format "On %a, %d %b %Y, %f wrote:" message-citation-line-function 'message-insert-formatted-citation-line The tests have been updated to reflect the (ugly) emacs default.
2012-03-18 17:32:42 +01:00
Notmuch Test Suite <test_suite@notmuchmail.org> writes:
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
> This is a test that messages are sent via SMTP
EOF
test_expect_equal_file OUTPUT EXPECTED
test: Add test for reply functionality within emacs. The reply is primarily taken care of by "notmuch reply" which is already thoroughly tested. But a recent bug is inserting a duplicate From header in the emacs-based reply. So exercise that bug here.
2010-10-28 03:43:09 +02:00
test: Tests for reply from alternate addresses in emacs Since the recent reply changes were pushed, there has been a bug that causes emacs to always reply from the primary address, even if the JSON or default CLI reply output uses an alternate address. This adds two tests to the emacs test library based on the two "Reply form..." tests in the reply test library. One is currently marked broken.
2012-04-01 17:24:20 +02:00
test_begin_subtest "Reply from alternate address within emacs"
add_message '[from]="Sender <sender@example.com>"' \
[to]=test_suite_other@notmuchmail.org
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
test_emacs "(let ((message-hidden-headers '()))
(notmuch-search \"id:\\\"${gen_msg_id}\\\"\")
test: Tests for reply from alternate addresses in emacs Since the recent reply changes were pushed, there has been a bug that causes emacs to always reply from the primary address, even if the JSON or default CLI reply output uses an alternate address. This adds two tests to the emacs test library based on the two "Reply form..." tests in the reply test library. One is currently marked broken.
2012-04-01 17:24:20 +02:00
(notmuch-test-wait)
(notmuch-search-reply-to-thread)
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
(test-output))"
sed -i -e 's,^User-Agent: Notmuch/.* Emacs/.*,User-Agent: Notmuch/XXX Emacs/XXX,' OUTPUT
test: Tests for reply from alternate addresses in emacs Since the recent reply changes were pushed, there has been a bug that causes emacs to always reply from the primary address, even if the JSON or default CLI reply output uses an alternate address. This adds two tests to the emacs test library based on the two "Reply form..." tests in the reply test library. One is currently marked broken.
2012-04-01 17:24:20 +02:00
cat <<EOF >EXPECTED
From: Notmuch Test Suite <test_suite_other@notmuchmail.org>
To: Sender <sender@example.com>
Subject: Re: ${test_subtest_name}
In-Reply-To: <${gen_msg_id}>
Fcc: ${MAIL_DIR}/sent
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
References: <${gen_msg_id}>
User-Agent: Notmuch/XXX Emacs/XXX
test: Tests for reply from alternate addresses in emacs Since the recent reply changes were pushed, there has been a bug that causes emacs to always reply from the primary address, even if the JSON or default CLI reply output uses an alternate address. This adds two tests to the emacs test library based on the two "Reply form..." tests in the reply test library. One is currently marked broken.
2012-04-01 17:24:20 +02:00
--text follows this line--
Sender <sender@example.com> writes:
> This is just a test message (#${gen_msg_cnt})
EOF
test_expect_equal_file OUTPUT EXPECTED
test_begin_subtest "Reply from address in named group list within emacs"
add_message '[from]="Sender <sender@example.com>"' \
'[to]=group:test_suite@notmuchmail.org,someone@example.com\;' \
[cc]=test_suite_other@notmuchmail.org
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
test_emacs "(let ((message-hidden-headers '()))
(notmuch-search \"id:\\\"${gen_msg_id}\\\"\")
test: Tests for reply from alternate addresses in emacs Since the recent reply changes were pushed, there has been a bug that causes emacs to always reply from the primary address, even if the JSON or default CLI reply output uses an alternate address. This adds two tests to the emacs test library based on the two "Reply form..." tests in the reply test library. One is currently marked broken.
2012-04-01 17:24:20 +02:00
(notmuch-test-wait)
(notmuch-search-reply-to-thread)
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
(test-output))"
sed -i -e 's,^User-Agent: Notmuch/.* Emacs/.*,User-Agent: Notmuch/XXX Emacs/XXX,' OUTPUT
test: Tests for reply from alternate addresses in emacs Since the recent reply changes were pushed, there has been a bug that causes emacs to always reply from the primary address, even if the JSON or default CLI reply output uses an alternate address. This adds two tests to the emacs test library based on the two "Reply form..." tests in the reply test library. One is currently marked broken.
2012-04-01 17:24:20 +02:00
cat <<EOF >EXPECTED
From: Notmuch Test Suite <test_suite@notmuchmail.org>
To: Sender <sender@example.com>, someone@example.com
Subject: Re: ${test_subtest_name}
In-Reply-To: <${gen_msg_id}>
Fcc: ${MAIL_DIR}/sent
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
References: <${gen_msg_id}>
User-Agent: Notmuch/XXX Emacs/XXX
test: Tests for reply from alternate addresses in emacs Since the recent reply changes were pushed, there has been a bug that causes emacs to always reply from the primary address, even if the JSON or default CLI reply output uses an alternate address. This adds two tests to the emacs test library based on the two "Reply form..." tests in the reply test library. One is currently marked broken.
2012-04-01 17:24:20 +02:00
--text follows this line--
Sender <sender@example.com> writes:
> This is just a test message (#${gen_msg_cnt})
EOF
test_expect_equal_file OUTPUT EXPECTED
test: Add broken tests for new emacs reply functionality Add tests for creating nice replies to multipart messages, including those with HTML parts. These tests are expected to fail for now.
2012-03-18 17:32:41 +01:00
test_begin_subtest "Reply within emacs to a multipart/mixed message"
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
test_emacs '(let ((message-hidden-headers ''()))
(notmuch-show "id:20091118002059.067214ed@hikari")
test: Add broken tests for new emacs reply functionality Add tests for creating nice replies to multipart messages, including those with HTML parts. These tests are expected to fail for now.
2012-03-18 17:32:41 +01:00
(notmuch-show-reply)
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
(test-output))'
sed -i -e 's,^User-Agent: Notmuch/.* Emacs/.*,User-Agent: Notmuch/XXX Emacs/XXX,' OUTPUT
test: Add broken tests for new emacs reply functionality Add tests for creating nice replies to multipart messages, including those with HTML parts. These tests are expected to fail for now.
2012-03-18 17:32:41 +01:00
cat <<EOF >EXPECTED
From: Notmuch Test Suite <test_suite@notmuchmail.org>
To: Adrian Perez de Castro <aperez@igalia.com>, notmuch@notmuchmail.org
Subject: Re: [notmuch] Introducing myself
In-Reply-To: <20091118002059.067214ed@hikari>
Fcc: ${MAIL_DIR}/sent
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
References: <20091118002059.067214ed@hikari>
User-Agent: Notmuch/XXX Emacs/XXX
test: Add broken tests for new emacs reply functionality Add tests for creating nice replies to multipart messages, including those with HTML parts. These tests are expected to fail for now.
2012-03-18 17:32:41 +01:00
--text follows this line--
Adrian Perez de Castro <aperez@igalia.com> writes:
> Hello to all,
>
> I have just heard about Not Much today in some random Linux-related news
> site (LWN?), my name is Adrian Perez and I work as systems administrator
> (although I can do some code as well :P). I have always thought that the
> ideas behind Sup were great, but after some time using it, I got tired of
> the oddities that it has. I also do not like doing things like having to
> install Ruby just for reading and sorting mails. Some time ago I thought
> about doing something like Not Much and in fact I played a bit with the
> Python+Xapian and the Python+Whoosh combinations, because I find relaxing
> to code things in Python when I am not working and also it is installed
> by default on most distribution. I got to have some mailboxes indexed and
> basic searching working a couple of months ago. Lately I have been very
> busy and had no time for coding, and them... boom! Not Much appears -- and
> it is almost exactly what I was trying to do, but faster. I have been
> playing a bit with Not Much today, and I think it has potential.
>
> Also, I would like to share one idea I had in mind, that you might find
> interesting: One thing I have found very annoying is having to re-tag my
> mail when the indexes get b0rked (it happened a couple of times to me while
> using Sup), so I was planning to mails as read/unread and adding the tags
> not just to the index, but to the mail text itself, e.g. by adding a
> "X-Tags" header field or by reusing the "Keywords" one. This way, the index
> could be totally recreated by re-reading the mail directories, and this
> would also allow to a tools like OfflineIMAP [1] to get the mails into a
> local maildir, tagging and indexing the mails with the e-mail reader and
> then syncing back the messages with the "X-Tags" header to the IMAP server.
> This would allow to use the mail reader from a different computer and still
> have everything tagged finely.
>
> Best regards,
>
>
> ---
> [1] http://software.complete.org/software/projects/show/offlineimap
>
> --
> Adrian Perez de Castro <aperez@igalia.com>
> Igalia - Free Software Engineering
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
EOF
test_expect_equal_file OUTPUT EXPECTED
test_begin_subtest "Reply within emacs to a multipart/alternative message"
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
test_emacs '(let ((message-hidden-headers ''()))
(notmuch-show "id:cf0c4d610911171136h1713aa59w9cf9aa31f052ad0a@mail.gmail.com")
test: Add broken tests for new emacs reply functionality Add tests for creating nice replies to multipart messages, including those with HTML parts. These tests are expected to fail for now.
2012-03-18 17:32:41 +01:00
(notmuch-show-reply)
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
(test-output))'
sed -i -e 's,^User-Agent: Notmuch/.* Emacs/.*,User-Agent: Notmuch/XXX Emacs/XXX,' OUTPUT
test: Add broken tests for new emacs reply functionality Add tests for creating nice replies to multipart messages, including those with HTML parts. These tests are expected to fail for now.
2012-03-18 17:32:41 +01:00
cat <<EOF >EXPECTED
From: Notmuch Test Suite <test_suite@notmuchmail.org>
To: Alex Botero-Lowry <alex.boterolowry@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [notmuch] preliminary FreeBSD support
In-Reply-To: <cf0c4d610911171136h1713aa59w9cf9aa31f052ad0a@mail.gmail.com>
Fcc: ${MAIL_DIR}/sent
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
References: <cf0c4d610911171136h1713aa59w9cf9aa31f052ad0a@mail.gmail.com>
User-Agent: Notmuch/XXX Emacs/XXX
test: Add broken tests for new emacs reply functionality Add tests for creating nice replies to multipart messages, including those with HTML parts. These tests are expected to fail for now.
2012-03-18 17:32:41 +01:00
--text follows this line--
Alex Botero-Lowry <alex.boterolowry@gmail.com> writes:
> I saw the announcement this morning, and was very excited, as I had been
> hoping sup would be turned into a library,
> since I like the concept more than the UI (I'd rather an emacs interface).
>
> I did a preliminary compile which worked out fine, but
> sysconf(_SC_SC_GETPW_R_SIZE_MAX) returns -1 on
> FreeBSD, so notmuch_config_open segfaulted.
>
> Attached is a patch that supplies a default buffer size of 64 in cases where
> -1 is returned.
>
> http://www.opengroup.org/austin/docs/austin_328.txt - seems to indicate this
> is acceptable behavior,
> and http://mail-index.netbsd.org/pkgsrc-bugs/2006/06/07/msg016808.htmlspecifically
> uses 64 as the
> buffer size.
emacs/mua: Generate improved cited text for replies Use the message display code to generate message text to cite in replies. For now we set insert-headers-p function to notmuch-show-reply-insert-header-p-never so that, as before, we don't insert part buttons. With that choice of insert-headers-p function there is only one failing test: this test has a text part (an email message) listed as application/octet-stream. Notmuch show displays this part, but the reply code omitted it as it had type application/octet-stream. The new code correctly includes it. Thus update the expected output to match.
2016-02-20 19:24:38 +01:00
> From e3bc4bbd7b9d0d086816ab5f8f2d6ffea1dd3ea4 Mon Sep 17 00:00:00 2001
> From: Alexander Botero-Lowry <alex.boterolowry@gmail.com>
> Date: Tue, 17 Nov 2009 11:30:39 -0800
> Subject: [PATCH] Deal with situation where sysconf(_SC_GETPW_R_SIZE_MAX) returns -1
>
> ---
> notmuch-config.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/notmuch-config.c b/notmuch-config.c
> index 248149c..e7220d8 100644
> --- a/notmuch-config.c
> +++ b/notmuch-config.c
> @@ -77,6 +77,7 @@ static char *
> get_name_from_passwd_file (void *ctx)
> {
> long pw_buf_size = sysconf(_SC_GETPW_R_SIZE_MAX);
> + if (pw_buf_size == -1) pw_buf_size = 64;
> char *pw_buf = talloc_zero_size (ctx, pw_buf_size);
> struct passwd passwd, *ignored;
> char *name;
> @@ -101,6 +102,7 @@ static char *
> get_username_from_passwd_file (void *ctx)
> {
> long pw_buf_size = sysconf(_SC_GETPW_R_SIZE_MAX);
> + if (pw_buf_size == -1) pw_buf_size = 64;
> char *pw_buf = talloc_zero_size (ctx, pw_buf_size);
> struct passwd passwd, *ignored;
> char *name;
> --
> 1.6.5.2
>
test: Add broken tests for new emacs reply functionality Add tests for creating nice replies to multipart messages, including those with HTML parts. These tests are expected to fail for now.
2012-03-18 17:32:41 +01:00
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
EOF
test_expect_equal_file OUTPUT EXPECTED
test: Replying to an HTML-only message in emacs With the latest reply infrastructure, we should be able to nicely quote HTML-only emails. But currently emacs quotes the raw HTML instead of parsing it first. This commit adds a test for this case. This test currently marked as broken.
2012-05-05 21:24:28 +02:00
test_begin_subtest "Reply within emacs to an html-only message"
add_message '[content-type]="text/html"' \
'[body]="Hi,<br />This is an <b>HTML</b> test message.<br /><br />OK?"'
test/emacs: globally force the html renderer to html2text Previously we did this for a single test, but some other proposed tests ( id:1398105468-14317-3-git-send-email-amdragon@mit.edu ) show similar breakage when switching renderers.
2014-09-20 07:41:35 +02:00
test_emacs "(let ((message-hidden-headers '()))
test: Replying to an HTML-only message in emacs With the latest reply infrastructure, we should be able to nicely quote HTML-only emails. But currently emacs quotes the raw HTML instead of parsing it first. This commit adds a test for this case. This test currently marked as broken.
2012-05-05 21:24:28 +02:00
(notmuch-show \"id:${gen_msg_id}\")
(notmuch-show-reply)
(test-output))"
sed -i -e 's,^User-Agent: Notmuch/.* Emacs/.*,User-Agent: Notmuch/XXX Emacs/XXX,' OUTPUT
cat <<EOF >EXPECTED
From: Notmuch Test Suite <test_suite@notmuchmail.org>
To:
Subject: Re: Reply within emacs to an html-only message
In-Reply-To: <${gen_msg_id}>
Fcc: ${MAIL_DIR}/sent
References: <${gen_msg_id}>
User-Agent: Notmuch/XXX Emacs/XXX
--text follows this line--
Notmuch Test Suite <test_suite@notmuchmail.org> writes:
test: Force reply to use html2text for consistency The output of the HTML reply test in the emacs suite can vary depending on which HTML renderers are installed on the machine running the tests. The renderer that is always available is emacs's builtin html2text function. In order to get consistency, force the test to use html2text even if other renderers are available.
2012-05-06 16:56:15 +02:00
> Hi,This is an HTML test message.OK?
test: Replying to an HTML-only message in emacs With the latest reply infrastructure, we should be able to nicely quote HTML-only emails. But currently emacs quotes the raw HTML instead of parsing it first. This commit adds a test for this case. This test currently marked as broken.
2012-05-05 21:24:28 +02:00
EOF
test_expect_equal_file OUTPUT EXPECTED
test: add tests for quoting of MML tags in replies The test is broken at this time; the next commit will introduce a fix. Edited-by: Pieter Praet <pieter@praet.org>: Rebased to release branch, moved expected output into the actual test, and fixed "Fcc:" line.
2012-02-03 11:24:07 +01:00
test_begin_subtest "Quote MML tags in reply"
message_id='test-emacs-mml-quoting@message.id'
add_message [id]="$message_id" \
"[subject]='$test_subtest_name'" \
'[body]="<#part disposition=inline>"'
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
test_emacs "(let ((message-hidden-headers '()))
(notmuch-show \"id:$message_id\")
test: add tests for quoting of MML tags in replies The test is broken at this time; the next commit will introduce a fix. Edited-by: Pieter Praet <pieter@praet.org>: Rebased to release branch, moved expected output into the actual test, and fixed "Fcc:" line.
2012-02-03 11:24:07 +01:00
(notmuch-show-reply)
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
(test-output))"
sed -i -e 's,^User-Agent: Notmuch/.* Emacs/.*,User-Agent: Notmuch/XXX Emacs/XXX,' OUTPUT
test: add tests for quoting of MML tags in replies The test is broken at this time; the next commit will introduce a fix. Edited-by: Pieter Praet <pieter@praet.org>: Rebased to release branch, moved expected output into the actual test, and fixed "Fcc:" line.
2012-02-03 11:24:07 +01:00
cat <<EOF >EXPECTED
From: Notmuch Test Suite <test_suite@notmuchmail.org>
To:
Subject: Re: Quote MML tags in reply
In-Reply-To: <test-emacs-mml-quoting@message.id>
Fcc: ${MAIL_DIR}/sent
test: Show all headers in emacs reply tests By default, emacs hides the User-Agent and References headers when composing mail. This is a good thing for users, but a bad thing for testing, since we can create ugly or invalid headers and not have it show up in the tests. By setting message-hidden-headers to an empty list, we force emacs to show all the headers, so we can check that they're correct. Users won't see this, but it will let us catch future bugs. As a side-effect, this breaks all the reply tests, since there is a bug with the References and User-Agent headers, fixed in the next commit.
2012-04-01 17:24:22 +02:00
References: <test-emacs-mml-quoting@message.id>
User-Agent: Notmuch/XXX Emacs/XXX
test: add tests for quoting of MML tags in replies The test is broken at this time; the next commit will introduce a fix. Edited-by: Pieter Praet <pieter@praet.org>: Rebased to release branch, moved expected output into the actual test, and fixed "Fcc:" line.
2012-02-03 11:24:07 +01:00
--text follows this line--
emacs: Use the new JSON reply format and message-cite-original Use the new JSON reply format to create replies in emacs. Quote HTML parts nicely by using mm-display-part to turn them into displayable text, then quoting them with message-cite-original. This is very useful for users who regularly receive HTML-only email. Use message-mode's message-cite-original function to create the quoted body for reply messages. In order to make this act like the existing notmuch defaults, you will need to set the following in your emacs configuration: message-citation-line-format "On %a, %d %b %Y, %f wrote:" message-citation-line-function 'message-insert-formatted-citation-line The tests have been updated to reflect the (ugly) emacs default.
2012-03-18 17:32:42 +01:00
Notmuch Test Suite <test_suite@notmuchmail.org> writes:
test: add tests for quoting of MML tags in replies The test is broken at this time; the next commit will introduce a fix. Edited-by: Pieter Praet <pieter@praet.org>: Rebased to release branch, moved expected output into the actual test, and fixed "Fcc:" line.
2012-02-03 11:24:07 +01:00
> <#!part disposition=inline>
EOF
test_expect_equal_file OUTPUT EXPECTED
test: Add test for reply functionality within emacs. The reply is primarily taken care of by "notmuch reply" which is already thoroughly tested. But a recent bug is inserting a duplicate From header in the emacs-based reply. So exercise that bug here.
2010-10-28 03:43:09 +02:00
test: add test for saving attachments using notmuch-show-save-part Use .gz filenames for saved attachments in the tests to check that Emacs does not re-compress the file. Use test_expect_equal_file instead of test_expect_equal to avoid binary output on the console.
2011-05-10 05:30:51 +02:00
test_begin_subtest "Save attachment from within emacs using notmuch-show-save-attachments"
# save as archive to test that Emacs does not re-compress .gz
test: use emacsclient(1) for Emacs tests Before the change, every Emacs test ran in a separate Emacs instance. Starting Emacs many times wastes considerable time and it gets worse as the test suite grows. The patch solves this by using a single Emacs server and emacsclient(1) to run multiple tests. Emacs server is started on the first test_emacs call and stopped when test_done is called. We take care not to leave orphan Emacs processes behind when test is terminated by whatever reason: Emacs server runs a watchdog that periodically checks that the test is still running. Some tests need to provide user input. Before the change, this was done using echo(1) to Emacs stdin. This no longer works and instead `standard-input' variable is set accordingly to make `read' return the appropriate string.
2011-06-28 06:56:17 +02:00
test_emacs '(let ((standard-input "\"attachment1.gz\""))
(notmuch-show "id:cf0c4d610911171136h1713aa59w9cf9aa31f052ad0a@mail.gmail.com")
test: do not hide test_emacs errors Do not redirect test_emacs stderr to /dev/null. Test_emacs uses emacsclient(1) now and it does not print unwanted messages (like those from `message') to stderr. But it does print useful errors, e.g. when emacs server connection fails, given expression is not valid or undefined function is called.
2011-07-01 04:23:48 +02:00
(notmuch-show-save-attachments))'
test: fix argument order of test_expect_equal_file in few tests Few Emacs tests had test_expect_equal_file arguments in the wrong order: the first argument should be the test output and the second one should be the expected.
2011-06-28 06:45:02 +02:00
test_expect_equal_file attachment1.gz "$EXPECTED/attachment"
test: add test for saving attachments using notmuch-show-save-part Use .gz filenames for saved attachments in the tests to check that Emacs does not re-compress the file. Use test_expect_equal_file instead of test_expect_equal to avoid binary output on the console.
2011-05-10 05:30:51 +02:00
test_begin_subtest "Save attachment from within emacs using notmuch-show-save-part"
# save as archive to test that Emacs does not re-compress .gz
test: use emacsclient(1) for Emacs tests Before the change, every Emacs test ran in a separate Emacs instance. Starting Emacs many times wastes considerable time and it gets worse as the test suite grows. The patch solves this by using a single Emacs server and emacsclient(1) to run multiple tests. Emacs server is started on the first test_emacs call and stopped when test_done is called. We take care not to leave orphan Emacs processes behind when test is terminated by whatever reason: Emacs server runs a watchdog that periodically checks that the test is still running. Some tests need to provide user input. Before the change, this was done using echo(1) to Emacs stdin. This no longer works and instead `standard-input' variable is set accordingly to make `read' return the appropriate string.
2011-06-28 06:56:17 +02:00
test_emacs '(let ((standard-input "\"attachment2.gz\""))
emacs: Simplify MIME part command implementation This unifies the part button actions and the underlying part action functions into single interactive command that simply applies to the part containing point using the just-added part p-list text property instead of button properties. Since all part actions can be performed by applying the appropriate mm function to an mm-handle, this patch abstracts out the creation of mm handles, making the implementations of the part commands trivial. This also eliminates our special handling for part save in favor of using the appropriate mm function. This necessarily modifies the way we handle the default part button action, but in a way that does not change the meaning of the notmuch-show-part-button-default-action defcustom. Since these commands are no longer specific to buttons, this patch eliminates the extra metadata stored with each button. This also eliminates one rather special-purpose macro for a collection of general purpose part handling utilities.
2013-05-30 03:13:46 +02:00
(notmuch-show "id:cf0c4d610911171136h1713aa59w9cf9aa31f052ad0a@mail.gmail.com")
(search-forward "0001-Deal-with")
(notmuch-show-save-part))'
test: fix argument order of test_expect_equal_file in few tests Few Emacs tests had test_expect_equal_file arguments in the wrong order: the first argument should be the test output and the second one should be the expected.
2011-06-28 06:45:02 +02:00
test_expect_equal_file attachment2.gz "$EXPECTED/attachment"
test: Add test for saving an attachment from emacs This tests the use of "notmuch cat" recently added to the emacs interface.
2010-11-06 19:25:56 +01:00
test/emacs: test saving of attachment containing 8bit octets This test catches the case 8bit octets in an attachment gets converted or lost when saving attachment to the file. This test is marked known broken.
2012-11-18 21:06:24 +01:00
test_begin_subtest "Save 8bit attachment from within emacs using notmuch-show-save-attachments"
add_message '[subject]="Attachment with 8bit chars"' \
'[header]="MIME-Version: 1.0"' \
'[content-type]="multipart/mixed; boundary=\"abcd\""' \
'[body]="--abcd
Content-Type: text/plain
Attachment follows:
--abcd
Content-Type: application/octet-stream; name=\"sample\"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename=\"sample\"
“¡ Hey ! It compiles ¡ Ship it !”
--abcd--
"'
test_emacs '(notmuch-show "id:'"${gen_msg_id}"'")
(delete-file "OUTPUT")
(let ((standard-input "\"OUTPUT\""))
(notmuch-show-save-attachments))'
test_expect_equal "$(cat OUTPUT)" '“¡ Hey ! It compiles ¡ Ship it !”'
test: Add test for viewing raw message within emacs. This provides further coverage for the recently added (and recently modified) use of "notmuch show --format=raw" within emacs.
2010-11-06 22:33:30 +01:00
test_begin_subtest "View raw message within emacs"
test: wrap and indent test_emacs calls Most test_emacs calls have long arguments that consist of many expressions. Putting them on a single line makes it hard to read and produces poor diff when they are changed. The patch puts every expression in test_emacs calls on a separate line.
2011-06-28 06:45:05 +02:00
test_emacs '(notmuch-show "id:cf0c4d610911171136h1713aa59w9cf9aa31f052ad0a@mail.gmail.com")
(notmuch-show-view-raw-message)
test: save buffer content to file instead of printing it in Emacs tests Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
2011-06-28 06:45:06 +02:00
(test-output)'
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
test_expect_equal_file OUTPUT $EXPECTED/raw-message-cf0c4d-52ad0a
test: Add test for viewing raw message within emacs. This provides further coverage for the recently added (and recently modified) use of "notmuch show --format=raw" within emacs.
2010-11-06 22:33:30 +01:00
test: add test for hiding/showing signature in notmuch-show view
2011-05-22 20:57:55 +02:00
test_begin_subtest "Hiding/showing signature in notmuch-show view"
maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
test_emacs "(notmuch-show \"$maildir_storage_thread\")
(search-forward \"Click/Enter to show.\")
(button-activate (button-at (point)))
(search-backward \"Click/Enter to hide.\")
(button-activate (button-at (point)))
test: save buffer content to file instead of printing it in Emacs tests Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
2011-06-28 06:45:06 +02:00
(test-output)"
test: update emacs test to use test_expect_equal_file This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actually in one of the original messages, so this was fixed.
2011-05-28 22:46:24 +02:00
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
test: add test for hiding/showing signature in notmuch-show view
2011-05-22 20:57:55 +02:00
test: Add test that emacs detects and hides top-post quotes of original messages This tests the recently-added detection/hiding of top-posted quotations and in the testing, it takes advantage of the less-recently-added visible-buffer-string function for emitting only the visible text from a buffer.
2011-06-11 01:28:26 +02:00
test_begin_subtest "Detection and hiding of top-post quoting of message"
add_message '[subject]="The problem with top-posting"' \
[id]=top-post-target \
'[body]="A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?"'
add_message '[from]="Top Poster <top@poster.com>"' \
[in-reply-to]=top-post-target \
[references]=top-post-target \
'[subject]="Re: The problem with top-posting"' \
'[body]="Thanks for the advice! I will be sure to put it to good use.
-Top Poster
----- Original Message -----
From: Notmuch Test Suite <test_suite@notmuchmail.org>
To: Notmuch Test Suite <test_suite@notmuchmai.org>
test: Make generated message date a real date January 5, 2001 was a Tuesday, not a Friday. Jameson fixed this exact problem for the multipart test in ec2b0a98cc, but not for generate_message itself. As Jameson pointed out in ec2b0a98cc, if we want to test date parsing, we should do it separately.
2011-12-29 03:34:43 +01:00
Sent: Fri, 05 Jan 2001 15:43:57 +0000
test: Add test that emacs detects and hides top-post quotes of original messages This tests the recently-added detection/hiding of top-posted quotations and in the testing, it takes advantage of the less-recently-added visible-buffer-string function for emitting only the visible text from a buffer.
2011-06-11 01:28:26 +02:00
Subject: The problem with top-posting
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?"'
test_emacs "(notmuch-show \"top-posting\")
test: sanitize dates in emacs, raw, and text output add a new function notmuch_date_sanitize for rfc822-ish things. Add date sanitization to notmuch_show_sanitize_all and use it more places. This is all in aid of a transition to unique timestamps on messages.
2013-12-08 15:52:41 +01:00
(test-visible-output \"OUTPUT.raw\")"
test: Add test that emacs detects and hides top-post quotes of original messages This tests the recently-added detection/hiding of top-posted quotations and in the testing, it takes advantage of the less-recently-added visible-buffer-string function for emitting only the visible text from a buffer.
2011-06-11 01:28:26 +02:00
echo "Notmuch Test Suite <test_suite@notmuchmail.org> (2001-01-05) (inbox)
Subject: The problem with top-posting
To: Notmuch Test Suite <test_suite@notmuchmail.org>
test: sanitize dates in emacs, raw, and text output add a new function notmuch_date_sanitize for rfc822-ish things. Add date sanitization to notmuch_show_sanitize_all and use it more places. This is all in aid of a transition to unique timestamps on messages.
2013-12-08 15:52:41 +01:00
Date: GENERATED_DATE
test: Add test that emacs detects and hides top-post quotes of original messages This tests the recently-added detection/hiding of top-posted quotations and in the testing, it takes advantage of the less-recently-added visible-buffer-string function for emitting only the visible text from a buffer.
2011-06-11 01:28:26 +02:00
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
Top Poster <top@poster.com> (2001-01-05) (inbox unread)
Subject: Re: The problem with top-posting
To: Notmuch Test Suite <test_suite@notmuchmail.org>
test: sanitize dates in emacs, raw, and text output add a new function notmuch_date_sanitize for rfc822-ish things. Add date sanitization to notmuch_show_sanitize_all and use it more places. This is all in aid of a transition to unique timestamps on messages.
2013-12-08 15:52:41 +01:00
Date: GENERATED_DATE
test: Add test that emacs detects and hides top-post quotes of original messages This tests the recently-added detection/hiding of top-posted quotations and in the testing, it takes advantage of the less-recently-added visible-buffer-string function for emitting only the visible text from a buffer.
2011-06-11 01:28:26 +02:00
Thanks for the advice! I will be sure to put it to good use.
-Top Poster
[ 9-line hidden original message. Click/Enter to show. ]" > EXPECTED
test: sanitize dates in emacs, raw, and text output add a new function notmuch_date_sanitize for rfc822-ish things. Add date sanitization to notmuch_show_sanitize_all and use it more places. This is all in aid of a transition to unique timestamps on messages.
2013-12-08 15:52:41 +01:00
notmuch_date_sanitize < OUTPUT.raw > OUTPUT
test: Add test that emacs detects and hides top-post quotes of original messages This tests the recently-added detection/hiding of top-posted quotations and in the testing, it takes advantage of the less-recently-added visible-buffer-string function for emitting only the visible text from a buffer.
2011-06-11 01:28:26 +02:00
test_expect_equal_file OUTPUT EXPECTED
test emacs: Add tests for hiding messages in notmuch-show view This test is expected to fail as it exposes a current bug, (which we hope to fix soon).
2011-05-26 23:38:34 +02:00
test_begin_subtest "Hiding message in notmuch-show view"
test: save buffer content to file instead of printing it in Emacs tests Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
2011-06-28 06:45:06 +02:00
test_emacs '(notmuch-show "id:f35dbb950911171438k5df6eb56k77b6c0944e2e79ae@mail.gmail.com")
(notmuch-show-toggle-message)
(test-visible-output)'
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-with-hidden-messages
test emacs: Add tests for hiding messages in notmuch-show view This test is expected to fail as it exposes a current bug, (which we hope to fix soon).
2011-05-26 23:38:34 +02:00
test_begin_subtest "Hiding message with visible citation in notmuch-show view"
test: save buffer content to file instead of printing it in Emacs tests Before the change, the common Emacs test scheme was to print buffer content to stdout and redirect it to a file or capture it in a shell variable. This does not work if we switch to using emacsclient(1) for running the tests, because you can not print to the stdout in this case. (Actually, you can print to stdout from Emacs server, but you can not capture the output on emacsclient(1)). The patch introduces new Emacs test auxiliary functions: `test-output' and `test-visible-output'. These functions are used to save buffer content to a file directly from Emacs. For most tests the changes are trivial, because Emacs stdout output was redirected to a file anyway. But some tests captured the output in a shell variable and compare it with the expected output using test_expect_equal. These tests are changed to use files and test_expect_equal_file instead. Note: even if we do not switch Emacs tests to emacsclient(1), the patch makes tests cleaner and is an improvement.
2011-06-28 06:45:06 +02:00
test_emacs '(notmuch-show "id:f35dbb950911171438k5df6eb56k77b6c0944e2e79ae@mail.gmail.com")
(search-forward "Click/Enter to show.")
(button-activate (button-at (point)))
(notmuch-show-toggle-message)
(test-visible-output)'
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-with-hidden-messages
test emacs: Add tests for hiding messages in notmuch-show view This test is expected to fail as it exposes a current bug, (which we hope to fix soon).
2011-05-26 23:38:34 +02:00
test: emacs: new tests "notmuch-show: {show, hide} message headers" * test/emacs: - New subtest "notmuch-show: show message headers": Setting `notmuch-message-headers-visible' to t causes all headers defined in `notmuch-message-headers' to be shown. - New subtest "notmuch-show: hide message headers": Setting `notmuch-message-headers-visible' to nil causes all headers defined in `notmuch-message-headers' to be hidden. ("Subject:" may be an exception; See the use of `headers-start' in `notmuch-show-insert-msg') - New subtest "notmuch-show: hide message headers (w/ notmuch-show-toggle-headers)": Setting `notmuch-message-headers-visible' to t causes all headers defined in `notmuch-message-headers' to be shown, but they can be hidden for the current message by running `notmuch-show-toggle-headers'.
2012-02-22 19:43:28 +01:00
test_begin_subtest "notmuch-show: show message headers"
test_emacs \
'(let ((notmuch-message-headers '\''("Subject" "To" "Cc" "Date"))
(notmuch-message-headers-visible t))
(notmuch-show "id:f35dbb950911171438k5df6eb56k77b6c0944e2e79ae@mail.gmail.com")
(test-visible-output))'
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-message-with-headers-visible
test_begin_subtest "notmuch-show: hide message headers"
test_emacs \
'(let ((notmuch-message-headers '\''("Subject" "To" "Cc" "Date"))
(notmuch-message-headers-visible nil))
(notmuch-show "id:f35dbb950911171438k5df6eb56k77b6c0944e2e79ae@mail.gmail.com")
(test-visible-output))'
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-message-with-headers-hidden
emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' * emacs/notmuch-show.el (notmuch-show-toggle-headers): Rename to `notmuch-show-toggle-visibility-headers'. (notmuch-show-mode-map): Update "h" binding wrt renamed `notmuch-show-toggle-headers'. (notmuch-message-headers): Update docstring wrt renamed `notmuch-show-toggle-headers'. (notmuch-message-headers-visible): Update docstring wrt renamed `notmuch-show-toggle-headers'. Also fixed a small typo. * test/emacs: Update subtest wrt renamed `notmuch-show-toggle-headers': - "notmuch-show: hide message headers (w/ notmuch-show-toggle-headers)"
2012-02-22 19:43:30 +01:00
test_begin_subtest "notmuch-show: hide message headers (w/ notmuch-show-toggle-visibility-headers)"
test: emacs: new tests "notmuch-show: {show, hide} message headers" * test/emacs: - New subtest "notmuch-show: show message headers": Setting `notmuch-message-headers-visible' to t causes all headers defined in `notmuch-message-headers' to be shown. - New subtest "notmuch-show: hide message headers": Setting `notmuch-message-headers-visible' to nil causes all headers defined in `notmuch-message-headers' to be hidden. ("Subject:" may be an exception; See the use of `headers-start' in `notmuch-show-insert-msg') - New subtest "notmuch-show: hide message headers (w/ notmuch-show-toggle-headers)": Setting `notmuch-message-headers-visible' to t causes all headers defined in `notmuch-message-headers' to be shown, but they can be hidden for the current message by running `notmuch-show-toggle-headers'.
2012-02-22 19:43:28 +01:00
test_emacs \
'(let ((notmuch-message-headers '\''("Subject" "To" "Cc" "Date"))
(notmuch-message-headers-visible t))
(notmuch-show "id:f35dbb950911171438k5df6eb56k77b6c0944e2e79ae@mail.gmail.com")
emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' * emacs/notmuch-show.el (notmuch-show-toggle-headers): Rename to `notmuch-show-toggle-visibility-headers'. (notmuch-show-mode-map): Update "h" binding wrt renamed `notmuch-show-toggle-headers'. (notmuch-message-headers): Update docstring wrt renamed `notmuch-show-toggle-headers'. (notmuch-message-headers-visible): Update docstring wrt renamed `notmuch-show-toggle-headers'. Also fixed a small typo. * test/emacs: Update subtest wrt renamed `notmuch-show-toggle-headers': - "notmuch-show: hide message headers (w/ notmuch-show-toggle-headers)"
2012-02-22 19:43:30 +01:00
(notmuch-show-toggle-visibility-headers)
test: emacs: new tests "notmuch-show: {show, hide} message headers" * test/emacs: - New subtest "notmuch-show: show message headers": Setting `notmuch-message-headers-visible' to t causes all headers defined in `notmuch-message-headers' to be shown. - New subtest "notmuch-show: hide message headers": Setting `notmuch-message-headers-visible' to nil causes all headers defined in `notmuch-message-headers' to be hidden. ("Subject:" may be an exception; See the use of `headers-start' in `notmuch-show-insert-msg') - New subtest "notmuch-show: hide message headers (w/ notmuch-show-toggle-headers)": Setting `notmuch-message-headers-visible' to t causes all headers defined in `notmuch-message-headers' to be shown, but they can be hidden for the current message by running `notmuch-show-toggle-headers'.
2012-02-22 19:43:28 +01:00
(test-visible-output))'
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-message-with-headers-hidden
test: emacs: new tests "notmuch-show: {, un}collapse all messages in thread" * test/emacs: - New subtest "notmuch-show: collapse all messages in thread": `notmuch-show-open-or-close-all' with prefix arg ("C-u M-RET") collapses all messages in thread. - New subtest "notmuch-show: uncollapse all messages in thread": `notmuch-show-open-or-close-all' without prefix arg ("M-RET") uncollapses all messages in thread.
2012-02-22 19:43:29 +01:00
test_begin_subtest "notmuch-show: collapse all messages in thread"
test_emacs '(notmuch-show "id:f35dbb950911171435ieecd458o853c873e35f4be95@mail.gmail.com")
(let ((current-prefix-arg t))
(notmuch-show-open-or-close-all)
(test-visible-output))'
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-with-all-messages-collapsed
test_begin_subtest "notmuch-show: uncollapse all messages in thread"
test_emacs '(notmuch-show "id:f35dbb950911171435ieecd458o853c873e35f4be95@mail.gmail.com")
(notmuch-show-open-or-close-all)
(test-visible-output)'
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-with-all-messages-uncollapsed
test: stashing in notmuch-{show,search} Should provide full test coverage of the stashing feature. Signed-off-by: Pieter Praet <pieter@praet.org>
2011-06-30 10:23:23 +02:00
test_begin_subtest "Stashing in notmuch-show"
add_message '[date]="Sat, 01 Jan 2000 12:00:00 -0000"' \
'[from]="Some One <someone@somewhere.org>"' \
'[to]="Some One Else <notsomeone@somewhere.org>"' \
'[cc]="Notmuch <notmuch@notmuchmail.org>"' \
'[subject]="Stash my stashables"' \
'[id]="bought"' \
'[body]="Unable to stash body. Where did you get it in the first place?!?"'
notmuch tag +stashtest id:${gen_msg_id}
test_emacs '(notmuch-show "id:\"bought\"")
test: whitespace-cleanup for most test/* files Used emacs (whitespace-cleanup) function to "cleanup blank problems" in test files where that could be done without breaking tests; test/emacs was partially, and test/multipart was fully reverted.
2012-01-11 17:53:59 +01:00
(notmuch-show-stash-date)
(notmuch-show-stash-from)
(notmuch-show-stash-to)
(notmuch-show-stash-cc)
(notmuch-show-stash-subject)
(notmuch-show-stash-message-id)
(notmuch-show-stash-message-id-stripped)
(notmuch-show-stash-tags)
(notmuch-show-stash-filename)
test: emacs: expand subtest "Stashing in notmuch-show" wrt stashing Mailing List Archive URIs `notmuch-show-stash-mlarchive-link' stashes a URI pointing to the current message at one of the MLAs configured in `notmuch-show-stash-mlarchive-link-alist'. Marked as "broken": fixed in next commit.
2012-02-19 21:50:26 +01:00
(notmuch-show-stash-mlarchive-link "Gmane")
(notmuch-show-stash-mlarchive-link "MARC")
(notmuch-show-stash-mlarchive-link "Mail Archive, The")
test: whitespace-cleanup for most test/* files Used emacs (whitespace-cleanup) function to "cleanup blank problems" in test files where that could be done without breaking tests; test/emacs was partially, and test/multipart was fully reverted.
2012-01-11 17:53:59 +01:00
(switch-to-buffer
(generate-new-buffer "*test-stashing*"))
test: emacs: expand subtest "Stashing in notmuch-show" wrt stashing Mailing List Archive URIs `notmuch-show-stash-mlarchive-link' stashes a URI pointing to the current message at one of the MLAs configured in `notmuch-show-stash-mlarchive-link-alist'. Marked as "broken": fixed in next commit.
2012-02-19 21:50:26 +01:00
(dotimes (i 12)
test: whitespace-cleanup for most test/* files Used emacs (whitespace-cleanup) function to "cleanup blank problems" in test files where that could be done without breaking tests; test/emacs was partially, and test/multipart was fully reverted.
2012-01-11 17:53:59 +01:00
(yank)
(insert "\n")
(rotate-yank-pointer 1))
(reverse-region (point-min) (point-max))
test: stashing in notmuch-{show,search} Should provide full test coverage of the stashing feature. Signed-off-by: Pieter Praet <pieter@praet.org>
2011-06-30 10:23:23 +02:00
(test-output)'
test: emacs: tidy up "Stashing in notmuch-show" test Merge expected output into the actual test, so we can verify the stashed filename using ${gen_msg_filename} instead of doing sed tricks.
2011-11-16 12:38:19 +01:00
cat <<EOF >EXPECTED
show: Unify JSON header output for messages and message parts This has three ramifications: - Blank To and Cc headers are no longer output for messages. - Dates are now canonicalized for messages, which means they always have a day of the week and GMT is printed +0000 (never -0000) - Invalid From message headers are handled slightly differently, since they get parsed by GMime now instead of notmuch.
2012-02-20 01:26:26 +01:00
Sat, 01 Jan 2000 12:00:00 +0000
test: emacs: tidy up "Stashing in notmuch-show" test Merge expected output into the actual test, so we can verify the stashed filename using ${gen_msg_filename} instead of doing sed tricks.
2011-11-16 12:38:19 +01:00
Some One <someone@somewhere.org>
Some One Else <notsomeone@somewhere.org>
Notmuch <notmuch@notmuchmail.org>
Stash my stashables
emacs: Introduce generic boolean term escaping function Currently, we only properly escape stashed id queries, but there are other places where the Emacs UI constructs queries for boolean terms. Since this escaping function is meant to be used in other places, it avoids escaping strings that don't need escaping.
2012-10-26 22:18:10 +02:00
id:bought
test: emacs: tidy up "Stashing in notmuch-show" test Merge expected output into the actual test, so we can verify the stashed filename using ${gen_msg_filename} instead of doing sed tricks.
2011-11-16 12:38:19 +01:00
bought
inbox,stashtest
${gen_msg_filename}
test: emacs: expand subtest "Stashing in notmuch-show" wrt stashing Mailing List Archive URIs `notmuch-show-stash-mlarchive-link' stashes a URI pointing to the current message at one of the MLAs configured in `notmuch-show-stash-mlarchive-link-alist'. Marked as "broken": fixed in next commit.
2012-02-19 21:50:26 +01:00
http://mid.gmane.org/bought
http://marc.info/?i=bought
emacs: update alist for mail-archive.com API change Searching by Message-Id no longer works via the old mail-archive.com API, though I have contacted them in hopes that they restore it to prevent dead links. Anyway, the new API is cleaner. Acked-by: Austin Clements <amdragon@MIT.EDU>
2014-02-13 16:04:22 +01:00
http://mid.mail-archive.com/bought
test: emacs: tidy up "Stashing in notmuch-show" test Merge expected output into the actual test, so we can verify the stashed filename using ${gen_msg_filename} instead of doing sed tricks.
2011-11-16 12:38:19 +01:00
EOF
test_expect_equal_file OUTPUT EXPECTED
test: stashing in notmuch-{show,search} Should provide full test coverage of the stashing feature. Signed-off-by: Pieter Praet <pieter@praet.org>
2011-06-30 10:23:23 +02:00
test_begin_subtest "Stashing in notmuch-search"
test_emacs '(notmuch-search "id:\"bought\"")
test: whitespace-cleanup for most test/* files Used emacs (whitespace-cleanup) function to "cleanup blank problems" in test files where that could be done without breaking tests; test/emacs was partially, and test/multipart was fully reverted.
2012-01-11 17:53:59 +01:00
(notmuch-test-wait)
(notmuch-search-stash-thread-id)
(switch-to-buffer
(generate-new-buffer "*test-stashing*"))
(yank)
test: stashing in notmuch-{show,search} Should provide full test coverage of the stashing feature. Signed-off-by: Pieter Praet <pieter@praet.org>
2011-06-30 10:23:23 +02:00
(test-output)'
sed -i -e 's/^thread:.*$/thread:XXX/' OUTPUT
test: fix "Stashing in notmuch-search" test when emacs is not available If emacs is not available, test_expect_equal would be called with only one argument. The patch fixes this by quoting the (possibly empty) $(cat OUTPUT) argument.
2011-11-27 19:36:19 +01:00
test_expect_equal "$(cat OUTPUT)" "thread:XXX"
test: stashing in notmuch-{show,search} Should provide full test coverage of the stashing feature. Signed-off-by: Pieter Praet <pieter@praet.org>
2011-06-30 10:23:23 +02:00
test: `notmuch-show-advance-and-archive' with invisible signature Add Emacs test to check that `notmuch-show-advance-and-archive' works for the last message in thread with invisible signature.
2011-11-06 10:03:58 +01:00
test_begin_subtest 'notmuch-show-advance-and-archive with invisible signature'
message1='id:20091118010116.GC25380@dottiness.seas.harvard.edu'
message2='id:1258491078-29658-1-git-send-email-dottedmag@dottedmag.net'
test: Clear test-output output file before running Emacs tests Most Emacs tests end with a call to (test-output), which saves the buffer to a filed called OUTPUT. Previously, if the test code failed with an exception before this call, the test framework would then compare against the OUTPUT file from the last Emacs test, resulting in confusing diffs. This requires one tweak to an emacs test that made two calls to test_emacs and expected an OUTPUT file from the first call. We simply reverse the order of the test_emacs calls.
2012-09-29 19:55:12 +02:00
test_emacs "(notmuch-show \"$message2\")
(test-output \"EXPECTED\")"
test: `notmuch-show-advance-and-archive' with invisible signature Add Emacs test to check that `notmuch-show-advance-and-archive' works for the last message in thread with invisible signature.
2011-11-06 10:03:58 +01:00
test_emacs "(notmuch-search \"$message1 or $message2\")
(notmuch-test-wait)
(notmuch-search-show-thread)
(goto-char (point-max))
(redisplay)
(notmuch-show-advance-and-archive)
(test-output)"
test_expect_equal_file OUTPUT EXPECTED
test: add two emacs tests for show mode refresh The first test tests that the notmuch-show-refresh-view function produces the exact same output for an unmodified show buffer. This test should pass since the relevant functionality has already been applied. The second test tests show refresh for a show buffer that has been modified by navigation and message visibility toggling. Ideally refresh-view should preserve this state of the notmuch-show buffer. Unfortunately it currently does not, so this test is know to be broken and is marked as such.
2011-10-09 05:21:26 +02:00
test_begin_subtest "Refresh show buffer"
test_emacs '(notmuch-show "id:f35dbb950911171438k5df6eb56k77b6c0944e2e79ae@mail.gmail.com")
(test-visible-output "EXPECTED")
(notmuch-show-refresh-view)
(test-visible-output)'
test_expect_equal_file OUTPUT EXPECTED
test_begin_subtest "Refresh modified show buffer"
test_emacs '(notmuch-show "id:f35dbb950911171438k5df6eb56k77b6c0944e2e79ae@mail.gmail.com")
test: whitespace-cleanup for most test/* files Used emacs (whitespace-cleanup) function to "cleanup blank problems" in test files where that could be done without breaking tests; test/emacs was partially, and test/multipart was fully reverted.
2012-01-11 17:53:59 +01:00
(notmuch-show-toggle-message)
(notmuch-show-next-message)
(notmuch-show-toggle-message)
test: add two emacs tests for show mode refresh The first test tests that the notmuch-show-refresh-view function produces the exact same output for an unmodified show buffer. This test should pass since the relevant functionality has already been applied. The second test tests show refresh for a show buffer that has been modified by navigation and message visibility toggling. Ideally refresh-view should preserve this state of the notmuch-show buffer. Unfortunately it currently does not, so this test is know to be broken and is marked as such.
2011-10-09 05:21:26 +02:00
(test-visible-output "EXPECTED")
(notmuch-show-refresh-view)
(test-visible-output)'
test_expect_equal_file OUTPUT EXPECTED
test: check that Emacs UI does not call notmuch for non-inlinable parts The patch adds two new test cases: * Do not call notmuch for non-inlinable application/mpeg parts * Do not call notmuch for non-inlinable audio/mpeg parts The application/mpeg test passes thanks to a workaround for application/* Content-Types. The audio/mpeg is currently broken.
2011-11-29 22:19:53 +01:00
test_begin_subtest "Do not call notmuch for non-inlinable application/mpeg parts"
id='message-with-application/mpeg-attachment@notmuchmail.org'
test: add emacs_fcc_message that does not use smtp-dummy Most of the tests previously using emacs_deliver_message do not use the actual transmitted message, so we replace it with a simpler (and presumably more reliable function) that only saves (and indexes) an fcc copy of the message.
2013-12-14 15:39:54 +01:00
emacs_fcc_message \
test: check that Emacs UI does not call notmuch for non-inlinable parts The patch adds two new test cases: * Do not call notmuch for non-inlinable application/mpeg parts * Do not call notmuch for non-inlinable audio/mpeg parts The application/mpeg test passes thanks to a workaround for application/* Content-Types. The audio/mpeg is currently broken.
2011-11-29 22:19:53 +01:00
'Message with application/mpeg attachment' \
'' \
"(message-goto-eoh)
(insert \"Message-ID: <$id>\n\")
(message-goto-body)
(mml-insert-part \"application/mpeg\")
(insert \"a fake mp3 file\")"
notmuch_counter_reset
test_emacs "(let ((notmuch-command \"$notmuch_counter_command\"))
(notmuch-show \"id:$id\"))"
test_expect_equal $(notmuch_counter_value) 1
test_begin_subtest "Do not call notmuch for non-inlinable audio/mpeg parts"
id='message-with-audio/mpeg-attachment@notmuchmail.org'
test: add emacs_fcc_message that does not use smtp-dummy Most of the tests previously using emacs_deliver_message do not use the actual transmitted message, so we replace it with a simpler (and presumably more reliable function) that only saves (and indexes) an fcc copy of the message.
2013-12-14 15:39:54 +01:00
emacs_fcc_message \
test: check that Emacs UI does not call notmuch for non-inlinable parts The patch adds two new test cases: * Do not call notmuch for non-inlinable application/mpeg parts * Do not call notmuch for non-inlinable audio/mpeg parts The application/mpeg test passes thanks to a workaround for application/* Content-Types. The audio/mpeg is currently broken.
2011-11-29 22:19:53 +01:00
'Message with audio/mpeg attachment' \
'' \
"(message-goto-eoh)
(insert \"Message-ID: <$id>\n\")
(message-goto-body)
(mml-insert-part \"audio/mpeg\")
(insert \"a fake mp3 file\")"
notmuch_counter_reset
test_emacs "(let ((notmuch-command \"$notmuch_counter_command\"))
(notmuch-show \"id:$id\"))"
test_expect_equal $(notmuch_counter_value) 1
test: add test for `notmuch-hello-mode-hook' Test that `notmuch-hello-mode-hook' is called once when `notmuch-hello' function is called.
2011-12-18 01:21:19 +01:00
test_begin_subtest "notmuch-hello-mode hook is called"
counter=$(test_emacs \
'(let ((notmuch-hello-mode-hook-counter 0))
(kill-buffer "*notmuch-hello*")
(notmuch-hello)
notmuch-hello-mode-hook-counter)'
)
test_expect_equal "$counter" 1
test: add broken test for `notmuch-hello-mode-hook' called during update Test that `notmuch-hello-mode-hook' is not called during `notmuch-hello' buffer updates. The test is currently broken.
2011-12-18 01:21:20 +01:00
test_begin_subtest "notmuch-hello-mode hook is not called on updates"
counter=$(test_emacs \
'(let ((notmuch-hello-mode-hook-counter 0))
(kill-buffer "*notmuch-hello*")
(notmuch-hello)
(notmuch-hello-update)
notmuch-hello-mode-hook-counter)'
)
test_expect_equal "$counter" 1
test: add test for `notmuch-hello-refresh-hook' Test that `notmuch-hello-refresh-hook' is called once when `notmuch-hello' is called and twice when calling `notmuch-hello-update' after that. The tests are very similar to tests for `notmuch-hello-mode-hook'.
2011-12-21 19:18:26 +01:00
test_begin_subtest "notmuch-hello-refresh hook is called"
counter=$(test_emacs \
'(let ((notmuch-hello-refresh-hook-counter 0))
(kill-buffer "*notmuch-hello*")
(notmuch-hello)
notmuch-hello-refresh-hook-counter)'
)
test_expect_equal "$counter" 1
test_begin_subtest "notmuch-hello-refresh hook is called on updates"
counter=$(test_emacs \
'(let ((notmuch-hello-refresh-hook-counter 0))
(kill-buffer "*notmuch-hello*")
(notmuch-hello)
(notmuch-hello-update)
notmuch-hello-refresh-hook-counter)'
)
test_expect_equal "$counter" 2
test: Add a test for HTML email with inline images Currently this test passes in Emacs 23 but fails in Emacs 24 (at least on some Linux distributions).
2012-09-29 19:55:13 +02:00
add_message '[subject]="HTML mail with images"' \
'[content-type]="multipart/related; boundary=abcd"' \
'[body]="--abcd
Content-Type: text/html
test: Fix HTML rendering test The test designed to exercise Emacs' rendering of HTML emails containing images inadvertently assumed w3m was available under Emacs 23. The real point of this test was to check that Emacs 24's shr renderer didn't crash when given img tags, so use shr if it's available, html2text otherwise (which is built in), and do only a simple sanity check of the result.
2012-11-12 02:12:07 +01:00
<img src="cid:330@goomoji.gmail"> smiley
test: Add a test for HTML email with inline images Currently this test passes in Emacs 23 but fails in Emacs 24 (at least on some Linux distributions).
2012-09-29 19:55:13 +02:00
--abcd
Content-Type: image/gif
Content-Transfer-Encoding: base64
Content-ID: <330@goomoji.gmail>
R0lGODlhDAAMAKIFAF5LAP/zxAAAANyuAP/gaP///wAAAAAAACH5BAEAAAUALAAAAAAMAAwAAAMl
WLPcGjDKFYi9lxKBOaGcF35DhWHamZUW0K4mAbiwWtuf0uxFAgA7
--abcd--"'
test: Fix HTML rendering test The test designed to exercise Emacs' rendering of HTML emails containing images inadvertently assumed w3m was available under Emacs 23. The real point of this test was to check that Emacs 24's shr renderer didn't crash when given img tags, so use shr if it's available, html2text otherwise (which is built in), and do only a simple sanity check of the result.
2012-11-12 02:12:07 +01:00
test_emacs "(let ((mm-text-html-renderer
(if (assq 'shr mm-text-html-renderer-alist)
'shr 'html2text)))
(notmuch-show \"id:${gen_msg_id}\"))
(test-output)" > /dev/null
# Different Emacs versions and renderers give very different results,
test: Produce useful output when the HTML with images test fails Previously, this would simply indicate that the grep failed without any indication of the Emacs output it failed on. Now we take advantage of the test framework's handling of stdout to display the incorrect Emacs output if the test fails.
2012-11-20 16:58:45 +01:00
# so just check that something reasonable showed up. We first cat the
# output so the test framework will print it if the test fails.
test: Fix HTML rendering test The test designed to exercise Emacs' rendering of HTML emails containing images inadvertently assumed w3m was available under Emacs 23. The real point of this test was to check that Emacs 24's shr renderer didn't crash when given img tags, so use shr if it's available, html2text otherwise (which is built in), and do only a simple sanity check of the result.
2012-11-12 02:12:07 +01:00
test_expect_success "Rendering HTML mail with images" \
test: Produce useful output when the HTML with images test fails Previously, this would simply indicate that the grep failed without any indication of the Emacs output it failed on. Now we take advantage of the test framework's handling of stdout to display the incorrect Emacs output if the test fails.
2012-11-20 16:58:45 +01:00
'cat OUTPUT && grep -q smiley OUTPUT'
test: Add a test for HTML email with inline images Currently this test passes in Emacs 23 but fails in Emacs 24 (at least on some Linux distributions).
2012-09-29 19:55:13 +02:00
emacs: Use async process helper for search Previously, search started the async notmuch process directly. Now, it uses `notmuch-start-notmuch'. This simplifies the process sentinel a bit and means that we no longer have to worry about errors interleaved with the JSON output. We also update the tests of Emacs error handling, since the error output is now separated from the search results buffer.
2013-06-01 02:40:05 +02:00
test_begin_subtest "Search handles subprocess error exit codes"
test: Test search's handling of subprocess errors
2012-12-15 21:04:20 +01:00
cat > notmuch_fail <<EOF
#!/bin/sh
emacs: Use streaming S-expr parser for search In addition to being the Right Thing to do, this noticeably improves the time taken to display the first page of search results, since it's roughly an order of magnitude faster than the JSON parser. Interestingly, it does *not* significantly improve the time to completely fill a large search buffer because for large search buffers, the cost of creating author invisibility overlays and inserting text (which slows down with more overlays) dominates. However, the time required to display the first page of results is generally more important to the user experience.
2013-06-01 02:40:07 +02:00
echo '()'
test: Test search's handling of subprocess errors
2012-12-15 21:04:20 +01:00
exit 1
EOF
chmod a+x notmuch_fail
test_emacs "(let ((notmuch-command \"$PWD/notmuch_fail\"))
test/emacs: force *Messages* buffer to be writable In emacs 24.4 the messages buffer starts being read-only, which kills these tests. This seems to be the point of the variable inihibit-read-only, which has existed at least since emacs 21.
2014-10-25 08:53:29 +02:00
(with-current-buffer \"*Messages*\"
(let ((inhibit-read-only t)) (erase-buffer)))
test: Fix missing erase-buffer in emacs test The first subprocess error exit code test assumed the *Notmuch errors* buffer would be empty. Rather than assuming, make it so.
2013-10-24 17:19:04 +02:00
(with-current-buffer (get-buffer-create \"*Notmuch errors*\")
(erase-buffer))
test: Test search's handling of subprocess errors
2012-12-15 21:04:20 +01:00
(notmuch-search \"tag:inbox\")
(notmuch-test-wait)
emacs: Use the minibuffer for CLI error reporting We recently switched to popping up a buffer to report CLI errors, but this was too intrusive, especially for transient errors and especially since we made fewer things ignore errors. This patch changes this to display a basic error message in the minibuffer (using Emacs' usual error handling path) and, if there are additional details, to log these to a separate error buffer and reference the error buffer from the minibuffer message. This is more in line with how Emacs typically handles errors, but makes the details available to the user without flooding them with the details. Given this split, we pare down the basic message and make it more user-friendly, and also make the verbose message even more detailed (and more debugging-oriented).
2013-01-03 22:47:49 +01:00
(with-current-buffer \"*Messages*\"
(test-output \"MESSAGES\"))
test: Test search's handling of subprocess errors
2012-12-15 21:04:20 +01:00
(with-current-buffer \"*Notmuch errors*\"
emacs: Use the minibuffer for CLI error reporting We recently switched to popping up a buffer to report CLI errors, but this was too intrusive, especially for transient errors and especially since we made fewer things ignore errors. This patch changes this to display a basic error message in the minibuffer (using Emacs' usual error handling path) and, if there are additional details, to log these to a separate error buffer and reference the error buffer from the minibuffer message. This is more in line with how Emacs typically handles errors, but makes the details available to the user without flooding them with the details. Given this split, we pare down the basic message and make it more user-friendly, and also make the verbose message even more detailed (and more debugging-oriented).
2013-01-03 22:47:49 +01:00
(test-output \"ERROR\"))
(test-output))"
test: replace $PWD with YYY in emacs & emacs-show tests When executed command line is written to *Notmuch errors* buffer, shell-quote-argument will backslash-escape any char that is not in "POSIX filename characters" (i.e. matching "[^-0-9a-zA-Z_./\n]"). Currently in two emacs tests shell has expanded $PWD as part of emacs variable, which will later be fed to #'shell-quote-argument and finally written to ERROR file. If $PWD contained non-POSIX filename characters, data in ERROR file will not match $PWD when later comparing in shell. Therefore, in these two particular cases the escaped $PWD is replaced with YYY in ERROR file and expected content is adjusted accordingly.
2013-11-23 12:01:16 +01:00
test_expect_equal "$(notmuch_emacs_error_sanitize notmuch_fail OUTPUT MESSAGES ERROR)" "\
=== OUTPUT ===
test: Test search's handling of subprocess errors
2012-12-15 21:04:20 +01:00
End of search results.
test: replace $PWD with YYY in emacs & emacs-show tests When executed command line is written to *Notmuch errors* buffer, shell-quote-argument will backslash-escape any char that is not in "POSIX filename characters" (i.e. matching "[^-0-9a-zA-Z_./\n]"). Currently in two emacs tests shell has expanded $PWD as part of emacs variable, which will later be fed to #'shell-quote-argument and finally written to ERROR file. If $PWD contained non-POSIX filename characters, data in ERROR file will not match $PWD when later comparing in shell. Therefore, in these two particular cases the escaped $PWD is replaced with YYY in ERROR file and expected content is adjusted accordingly.
2013-11-23 12:01:16 +01:00
=== MESSAGES ===
YYY/notmuch_fail exited with status 1 (see *Notmuch errors* for more details)
=== ERROR ===
emacs: Use the minibuffer for CLI error reporting We recently switched to popping up a buffer to report CLI errors, but this was too intrusive, especially for transient errors and especially since we made fewer things ignore errors. This patch changes this to display a basic error message in the minibuffer (using Emacs' usual error handling path) and, if there are additional details, to log these to a separate error buffer and reference the error buffer from the minibuffer message. This is more in line with how Emacs typically handles errors, but makes the details available to the user without flooding them with the details. Given this split, we pare down the basic message and make it more user-friendly, and also make the verbose message even more detailed (and more debugging-oriented).
2013-01-03 22:47:49 +01:00
[XXX]
test: replace $PWD with YYY in emacs & emacs-show tests When executed command line is written to *Notmuch errors* buffer, shell-quote-argument will backslash-escape any char that is not in "POSIX filename characters" (i.e. matching "[^-0-9a-zA-Z_./\n]"). Currently in two emacs tests shell has expanded $PWD as part of emacs variable, which will later be fed to #'shell-quote-argument and finally written to ERROR file. If $PWD contained non-POSIX filename characters, data in ERROR file will not match $PWD when later comparing in shell. Therefore, in these two particular cases the escaped $PWD is replaced with YYY in ERROR file and expected content is adjusted accordingly.
2013-11-23 12:01:16 +01:00
YYY/notmuch_fail exited with status 1
command: YYY/notmuch_fail search --format\=sexp --format-version\=2 --sort\=newest-first tag\:inbox
emacs: Use the minibuffer for CLI error reporting We recently switched to popping up a buffer to report CLI errors, but this was too intrusive, especially for transient errors and especially since we made fewer things ignore errors. This patch changes this to display a basic error message in the minibuffer (using Emacs' usual error handling path) and, if there are additional details, to log these to a separate error buffer and reference the error buffer from the minibuffer message. This is more in line with how Emacs typically handles errors, but makes the details available to the user without flooding them with the details. Given this split, we pare down the basic message and make it more user-friendly, and also make the verbose message even more detailed (and more debugging-oriented).
2013-01-03 22:47:49 +01:00
exit status: 1"
test: Test search's handling of subprocess errors
2012-12-15 21:04:20 +01:00
emacs: Use async process helper for search Previously, search started the async notmuch process directly. Now, it uses `notmuch-start-notmuch'. This simplifies the process sentinel a bit and means that we no longer have to worry about errors interleaved with the JSON output. We also update the tests of Emacs error handling, since the error output is now separated from the search results buffer.
2013-06-01 02:40:05 +02:00
test_begin_subtest "Search handles subprocess warnings"
cat > notmuch_fail <<EOF
#!/bin/sh
emacs: Use streaming S-expr parser for search In addition to being the Right Thing to do, this noticeably improves the time taken to display the first page of search results, since it's roughly an order of magnitude faster than the JSON parser. Interestingly, it does *not* significantly improve the time to completely fill a large search buffer because for large search buffers, the cost of creating author invisibility overlays and inserting text (which slows down with more overlays) dominates. However, the time required to display the first page of results is generally more important to the user experience.
2013-06-01 02:40:07 +02:00
echo '()'
emacs: Use async process helper for search Previously, search started the async notmuch process directly. Now, it uses `notmuch-start-notmuch'. This simplifies the process sentinel a bit and means that we no longer have to worry about errors interleaved with the JSON output. We also update the tests of Emacs error handling, since the error output is now separated from the search results buffer.
2013-06-01 02:40:05 +02:00
echo This is a warning >&2
echo This is another warning >&2
exit 0
EOF
chmod a+x notmuch_fail
test_emacs "(let ((notmuch-command \"$PWD/notmuch_fail\"))
test/emacs: force *Messages* buffer to be writable In emacs 24.4 the messages buffer starts being read-only, which kills these tests. This seems to be the point of the variable inihibit-read-only, which has existed at least since emacs 21.
2014-10-25 08:53:29 +02:00
(with-current-buffer \"*Messages*\"
(let ((inhibit-read-only t)) (erase-buffer)))
test: Fix missing erase-buffer in emacs test The first subprocess error exit code test assumed the *Notmuch errors* buffer would be empty. Rather than assuming, make it so.
2013-10-24 17:19:04 +02:00
(with-current-buffer (get-buffer-create \"*Notmuch errors*\")
(erase-buffer))
emacs: Use async process helper for search Previously, search started the async notmuch process directly. Now, it uses `notmuch-start-notmuch'. This simplifies the process sentinel a bit and means that we no longer have to worry about errors interleaved with the JSON output. We also update the tests of Emacs error handling, since the error output is now separated from the search results buffer.
2013-06-01 02:40:05 +02:00
(notmuch-search \"tag:inbox\")
(notmuch-test-wait)
(with-current-buffer \"*Messages*\"
(test-output \"MESSAGES\"))
(with-current-buffer \"*Notmuch errors*\"
(test-output \"ERROR\"))
(test-output))"
sed -i -e 's/^\[.*\]$/[XXX]/' ERROR
test_expect_equal "$(cat OUTPUT; echo ---; cat MESSAGES; echo ---; cat ERROR)" "\
End of search results.
---
This is a warning (see *Notmuch errors* for more details)
---
[XXX]
This is a warning
This is another warning"
emacs: Add known-broken tests for search tagging races These tests check that both thread-local and global search tagging operations are race-free. They are currently known-broken because they aren't race-free.
2013-10-24 17:19:10 +02:00
test_begin_subtest "Search thread tag operations are race-free"
add_message '[subject]="Search race test"'
gen_msg_id_1=$gen_msg_id
generate_message '[in-reply-to]="<'$gen_msg_id_1'>"' \
'[references]="<'$gen_msg_id_1'>"' \
'[subject]="Search race test two"'
test_emacs '(notmuch-search "subject:\"search race test\"")
(notmuch-test-wait)
(notmuch-poll)
(execute-kbd-macro "+search-thread-race-tag")'
output=$(notmuch search --output=messages 'tag:search-thread-race-tag')
test_expect_equal "$output" "id:$gen_msg_id_1"
test_begin_subtest "Search global tag operations are race-free"
generate_message '[in-reply-to]="<'$gen_msg_id_1'>"' \
'[references]="<'$gen_msg_id_1'>"' \
'[subject]="Re: Search race test"'
test_emacs '(notmuch-search "subject:\"search race test\" -subject:two")
(notmuch-test-wait)
(notmuch-poll)
(execute-kbd-macro "*+search-global-race-tag")'
output=$(notmuch search --output=messages 'tag:search-global-race-tag')
test_expect_equal "$output" "id:$gen_msg_id_1"
test: Add broken test for Emacs boolean term escaping The current term escaper gets most of these right, but fails to escape things containing Unicode "fancy quotes" or things containing non-whitespace control characters.
2014-03-11 23:19:53 +01:00
test_begin_subtest "Term escaping"
output=$(test_emacs "(mapcar 'notmuch-escape-boolean-term (list
\"\"
\"abc\`~\!@#\$%^&*-=_+123\"
\"(abc\"
\")abc\"
\"\\\"abc\"
\"\x01xyz\"
\"\\x201cxyz\\x201d\"))")
test_expect_equal "$output" '("\"\"" "abc`~!@#$%^&*-=_+123" "\"(abc\"" "\")abc\"" "\"\"\"abc\"" "\"'$'\x01''xyz\"" "\"“xyz”\"")'
test: Add the most rudimentary testing of the emacs interface. So far, this is doing nothing more than adding a corpus of email and ensuring that the `notmuch-hello' function produces the desired output.
2010-10-22 21:10:15 +02:00
test_done
Reference in a new issue Copy permalink