debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-28 05:34:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

notmuch show: Avoid segmentation for message with no subject.

Browse source 
It's safer to return an empty string rather than NULL for missing
header values.
This commit is contained in:
Carl Worth 2009-11-11 23:00:58 -08:00
parent 5d614048b4
commit 091d18c54c
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/message-file.c
View file

@ -238,7 +238,7 @@ notmuch_message_file_get_header (notmuch_message_file_t *message,
return decoded_value; return decoded_value;
if (message->parsing_finished) if (message->parsing_finished)
return NULL; return "";
#define NEXT_HEADER_LINE(closure) \ #define NEXT_HEADER_LINE(closure) \
while (1) { \ while (1) { \
@ -348,5 +348,5 @@ notmuch_message_file_get_header (notmuch_message_file_t *message,
header_desired); header_desired);
} }
return NULL; return "";
} }

4
lib/notmuch.h
View file

@ -618,8 +618,8 @@ notmuch_message_get_date (notmuch_message_t *message);
* modified or freed by the caller (nor should it be referenced after * modified or freed by the caller (nor should it be referenced after
* the message is destroyed). * the message is destroyed).
* *
* Returns NULL if the message does not contain a header line matching * Returns an empty string ("") if the message does not contain a
* 'header' of if any error occurs. * header line matching 'header'. Returns NULL if any error occurs.
*/ */
const char * const char *
notmuch_message_get_header (notmuch_message_t *message, const char *header); notmuch_message_get_header (notmuch_message_t *message, const char *header);