debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2025-01-03 15:21:41 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

add_message: Avoid a memory leak when user holds on to message return.

Browse source 
When this function was originally written, the 'message' object was
always destroyed locally, so I thought it would be good to use a NULL
talloc context to make it more obvious if there was any leak.

Since then, however, this function has been changed to optionally
return the added message, and in that case we *don't* free the message
locally, so let's let the database be the talloc context.
This commit is contained in:
Carl Worth 2009-11-17 08:50:14 -08:00
parent 6b135cae1e
commit 0dab6a2c1e
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/database.cc
View file

@ -911,8 +911,7 @@ notmuch_database_add_message (notmuch_database_t *notmuch,
* (which may or may not reference an existing document in the
* database). */
/* Use NULL for owner since we want to free this locally. */
message = _notmuch_message_create_for_message_id (NULL,
message = _notmuch_message_create_for_message_id (database,
notmuch,
message_id,
&private_status);