debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-25 04:18:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

lib: convert two "iterator copy strings" into references.

Browse source 
Apparently this is a supported and even idiomatic way of keeping a
temporary object (e.g. like that returned from an operator
dereference) alive.
This commit is contained in:
David Bremner 2015-01-02 17:18:42 +01:00
parent 3d978a0d61
commit 105537a809
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/message.cc
View file

@ -283,7 +283,7 @@ _notmuch_message_get_term (notmuch_message_t *message,
if (i == end) if (i == end)
return NULL; return NULL;
std::string term = *i; const std::string &term = *i;
if (strncmp (term.c_str(), prefix, prefix_len)) if (strncmp (term.c_str(), prefix, prefix_len))
return NULL; return NULL;
@ -641,7 +641,7 @@ _notmuch_message_add_directory_terms (void *ctx, notmuch_message_t *message)
unsigned int directory_id; unsigned int directory_id;
const char *direntry, *directory; const char *direntry, *directory;
char *colon; char *colon;
const std::string term = *i; const std::string &term = *i;
/* Terminate loop at first term without desired prefix. */ /* Terminate loop at first term without desired prefix. */
if (strncmp (term.c_str (), direntry_prefix, direntry_prefix_len)) if (strncmp (term.c_str (), direntry_prefix, direntry_prefix_len))