debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-22 02:48:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

emacs: Don't use nconc on quoted list

Browse source 
As pointed out by David Bremner, Elisp manual says "A common pitfall
is to use a quoted constant list as a non-last argument to ‘nconc’."
Since this was the case in recently added code, we fix it here.
This commit is contained in:
Michal Sojka 2016-01-06 22:28:45 +01:00 committed by David Bremner
parent 1de4d5bb0d
commit 10f4724a8d
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
emacs/notmuch-mua.el
View file

@ -322,8 +322,8 @@ modified. This function is notmuch addaptation of
(notmuch-mua-pop-to-buffer (message-buffer-name "mail" to) (notmuch-mua-pop-to-buffer (message-buffer-name "mail" to)
(or switch-function (notmuch-mua-get-switch-function))) (or switch-function (notmuch-mua-get-switch-function)))
(let ((headers (let ((headers
;; The following sexp is copied from `message-mail' (append
(nconc ;; The following is copied from `message-mail'
`((To . ,(or to "")) (Subject . ,(or subject ""))) `((To . ,(or to "")) (Subject . ,(or subject "")))
;; C-h f compose-mail says that headers should be specified as ;; C-h f compose-mail says that headers should be specified as
;; (string . value); however all the rest of message expects ;; (string . value); however all the rest of message expects