From 20b2150406e1f80af6417ac601ff366de7eb804b Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sat, 23 Oct 2021 14:05:24 -0300 Subject: [PATCH] emacs: don't add space to tag completion candidates. Apparently this messes up various third party completion frameworks. This change does mean that users will have to hit space after completing a tag change in order to enter another change. As a bonus, remove the call to #'delete, since completing-read-multiple already promises to remove empty strings. --- emacs/notmuch-tag.el | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el index 536315e9..145f309f 100644 --- a/emacs/notmuch-tag.el +++ b/emacs/notmuch-tag.el @@ -429,17 +429,9 @@ initial input in the minibuffer." (set-keymap-parent map crm-local-completion-map) (define-key map " " 'self-insert-command) map))) - (delete "" (completing-read-multiple - prompt - ;; Append the separator to each completion so when the - ;; user completes a tag they can immediately begin - ;; entering another. `completing-read-multiple' - ;; ultimately splits the input on crm-separator, so we - ;; don't need to strip this back off (we just need to - ;; delete "empty" entries caused by trailing spaces). - (mapcar (lambda (tag-op) (concat tag-op crm-separator)) tag-list) - nil nil initial-input - 'notmuch-read-tag-changes-history)))) + (completing-read-multiple prompt tag-list + nil nil initial-input + 'notmuch-read-tag-changes-history))) ;;; Tagging