mirror of
https://git.notmuchmail.org/git/notmuch
synced 2024-11-22 02:48:08 +01:00
emacs: notmuch-mua-prompt-for-sender: don't force Ido on users
We shouldn't force `ido-completion-read' on users who do not otherwise use Ido. Unfortunately simply turning on `ido-mode' does not change every `completing-read' into a `ido-completing-read', instead it only changes file and buffer completion. I do realize that existing Ido users will initially dislike this change, but I would like to encourage them to see this as an opportunity to learn about Fido. Unlike `ido-mode', build-in `fido-mode' confirms to the standard completion API, so turning it on causes every `completing-read' to use the Fido completion mechanism and which is similar to the Ido mechanism: > An enhanced `icomplete-mode' that emulates `ido-mode'. This global > minor mode makes minibuffer completion behave more like `ido-mode' > than regular `icomplete-mode'."
This commit is contained in:
parent
3f16dd7611
commit
37bb41a792
1 changed files with 6 additions and 6 deletions
|
@ -431,14 +431,14 @@ the From: header is already filled in by notmuch."
|
|||
(defun notmuch-mua-prompt-for-sender ()
|
||||
"Prompt for a sender from the user's configured identities."
|
||||
(if notmuch-identities
|
||||
(ido-completing-read "Send mail from: " notmuch-identities
|
||||
(completing-read "Send mail from: " notmuch-identities
|
||||
nil nil nil 'notmuch-mua-sender-history
|
||||
(car notmuch-identities))
|
||||
(let* ((name (notmuch-user-name))
|
||||
(addrs (cons (notmuch-user-primary-email)
|
||||
(notmuch-user-other-email)))
|
||||
(address
|
||||
(ido-completing-read (concat "Sender address for " name ": ") addrs
|
||||
(completing-read (concat "Sender address for " name ": ") addrs
|
||||
nil nil nil 'notmuch-mua-sender-history
|
||||
(car addrs))))
|
||||
(message-make-from name address))))
|
||||
|
|
Loading…
Reference in a new issue