From 399031c2e3ceffc4999110d7e9f221f49e191016 Mon Sep 17 00:00:00 2001 From: Jameson Rollins Date: Wed, 27 Oct 2010 17:15:42 -0700 Subject: [PATCH] Remove bcc header from notmuch reply. Notmuch reply should not be Bcc'ing the sender by default. This is not the appropriate way to save copies of sent mail (which should probably be handled by an Fcc header[*]) and it doesn't give the user the option to not be bcc'd. This is really something that should be handled by the reader UI. For instance, emacs message-mode can easily be configured to add Bcc's if the user wishes. [*] Carl Worth: The FCC header is now in place by default in the emacs user-interface (and tested in the test suite) so the Bcc is ready to be eliminated. --- notmuch-reply.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index fd1de3b9..aa581785 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -481,9 +481,6 @@ notmuch_reply_format_default(void *ctx, notmuch_config_t *config, notmuch_query_ g_mime_object_set_header (GMIME_OBJECT (reply), "From", from_addr); - g_mime_object_set_header (GMIME_OBJECT (reply), "Bcc", - notmuch_config_get_user_primary_email (config)); - in_reply_to = talloc_asprintf (ctx, "<%s>", notmuch_message_get_message_id (message)); @@ -558,9 +555,6 @@ notmuch_reply_format_headers_only(void *ctx, notmuch_config_t *config, notmuch_q (void)add_recipients_from_message (reply, config, message); - g_mime_object_set_header (GMIME_OBJECT (reply), "Bcc", - notmuch_config_get_user_primary_email (config)); - reply_headers = g_mime_object_to_string (GMIME_OBJECT (reply)); printf ("%s", reply_headers); free (reply_headers);