From 3c752b855f900f5251df9997514b4d27d9f38e83 Mon Sep 17 00:00:00 2001 From: Daniel Kahn Gillmor Date: Sat, 9 Feb 2019 12:34:37 -0500 Subject: [PATCH] emacs: Invoke gpg with --batch and --no-tty When invoking gpg as a backgrounded tool, it's important to let gpg know that it is backgrounded, to avoid spurious prompts or other breakage. In particular, https://bugs.debian.org/913614 was a regression in GnuPG which causes problems when importing keys without a terminal, but gpg expects one. Ensuring that notmuch-emacs always invokes gpg as a background process should avoid some of these unnecessary failure. Thanks to Justus Winter for finding this problem. Signed-off-by: Daniel Kahn Gillmor --- emacs/notmuch-crypto.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el index fc2b5301..353f721e 100644 --- a/emacs/notmuch-crypto.el +++ b/emacs/notmuch-crypto.el @@ -142,7 +142,7 @@ mode." (with-selected-window window (with-current-buffer buffer (goto-char (point-max)) - (call-process epg-gpg-program nil t t "--list-keys" fingerprint)) + (call-process epg-gpg-program nil t t "--batch" "--no-tty" "--list-keys" fingerprint)) (recenter -1)))) (defun notmuch-crypto-sigstatus-error-callback (button) @@ -153,9 +153,9 @@ mode." (with-selected-window window (with-current-buffer buffer (goto-char (point-max)) - (call-process epg-gpg-program nil t t "--recv-keys" keyid) + (call-process epg-gpg-program nil t t "--batch" "--no-tty" "--recv-keys" keyid) (insert "\n") - (call-process epg-gpg-program nil t t "--list-keys" keyid)) + (call-process epg-gpg-program nil t t "--batch" "--no-tty" "--list-keys" keyid)) (recenter -1)) (notmuch-show-refresh-view)))