debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-24 20:08:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

lib: Use email address instead of empty real name.

Browse source 
Currently, if a From-header is of the form:

    "" <address@example.com>

the empty string will be treated as a valid real-name, and the entry
in the search results will be empty.

The new behavior here is that we treat an empty real-name field as if
it were null, so that the email address will be used in the search
results instead.

Signed-off-by: Jesse Rosenthal <jrosenthal@jhu.edu>
This commit is contained in:
Jesse Rosenthal 2014-11-22 08:17:16 -05:00 committed by David Bremner
parent 6c1d626519
commit 4135a1f8da
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/thread.cc
View file

@ -277,7 +277,8 @@ _thread_add_message (notmuch_thread_t *thread,
address = internet_address_list_get_address (list, 0); address = internet_address_list_get_address (list, 0);
if (address) { if (address) {
author = internet_address_get_name (address); author = internet_address_get_name (address);
if (author == NULL) { /* We treat quoted empty names as if they were empty. */
if (author == NULL || author[0] == '\0') {
InternetAddressMailbox *mailbox; InternetAddressMailbox *mailbox;
mailbox = INTERNET_ADDRESS_MAILBOX (address); mailbox = INTERNET_ADDRESS_MAILBOX (address);
author = internet_address_mailbox_get_addr (mailbox); author = internet_address_mailbox_get_addr (mailbox);

1
test/T205-author-naming.sh
View file

@ -3,7 +3,6 @@ test_description="naming of authors with unusual addresses"
. ./test-lib.sh . ./test-lib.sh
test_begin_subtest "Add author with empty quoted real name" test_begin_subtest "Add author with empty quoted real name"
test_subtest_known_broken
add_message '[subject]="author-naming: Initial thread subject"' \ add_message '[subject]="author-naming: Initial thread subject"' \
'[date]="Fri, 05 Jan 2001 15:43:56 -0000"' \ '[date]="Fri, 05 Jan 2001 15:43:56 -0000"' \
'[from]="\"\" <address@example.com>"' '[from]="\"\" <address@example.com>"'