diff --git a/bindings/python/notmuch/version.py b/bindings/python/notmuch/version.py index 43071028..7aa101d3 100644 --- a/bindings/python/notmuch/version.py +++ b/bindings/python/notmuch/version.py @@ -1,3 +1,3 @@ # this file should be kept in sync with ../../../version -__VERSION__ = '0.24~rc0' +__VERSION__ = '0.24~rc1' SOVERSION = '4' diff --git a/debian/changelog b/debian/changelog index 3781acf5..b8a0bf9d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,11 @@ +notmuch (0.24~rc1-1) experimental; urgency=medium + + * New upstream release candidate + * upstream release notes + * One library internals fix/optimization for regexp processing. + + -- David Bremner Wed, 08 Mar 2017 08:08:34 -0400 + notmuch (0.24~rc0-1) experimental; urgency=medium * New upstream feature release (candidate). diff --git a/lib/regexp-fields.cc b/lib/regexp-fields.cc index b4174750..8e740a81 100644 --- a/lib/regexp-fields.cc +++ b/lib/regexp-fields.cc @@ -62,11 +62,6 @@ RegexpPostingSource::init (const Xapian::Database &db) it_ = db_.valuestream_begin (slot_); end_ = db.valuestream_end (slot_); started_ = false; - - /* make sure we start on a matching value */ - while (!at_end() && regexec (®exp_, (*it_).c_str (), 0, NULL, 0) != 0) { - ++it_; - } } Xapian::doccount @@ -113,6 +108,27 @@ RegexpPostingSource::next (unused (double min_wt)) } } +void +RegexpPostingSource::skip_to (Xapian::docid did, unused (double min_wt)) +{ + started_ = true; + it_.skip_to (did); + for (; ! at_end (); ++it_) { + std::string value = *it_; + if (regexec (®exp_, value.c_str (), 0, NULL, 0) == 0) + break; + } +} + +bool +RegexpPostingSource::check (Xapian::docid did, unused (double min_wt)) +{ + started_ = true; + if (!it_.check (did) || at_end ()) + return false; + return (regexec (®exp_, (*it_).c_str (), 0, NULL, 0) == 0); +} + static inline Xapian::valueno _find_slot (std::string prefix) { if (prefix == "from") diff --git a/lib/regexp-fields.h b/lib/regexp-fields.h index bac11999..a4ba7ad8 100644 --- a/lib/regexp-fields.h +++ b/lib/regexp-fields.h @@ -56,6 +56,8 @@ class RegexpPostingSource : public Xapian::PostingSource Xapian::docid get_docid () const; bool at_end () const; void next (unused (double min_wt)); + void skip_to (Xapian::docid did, unused (double min_wt)); + bool check (Xapian::docid did, unused (double min_wt)); }; diff --git a/version b/version index ab10aa0f..1a46dd0a 100644 --- a/version +++ b/version @@ -1 +1 @@ -0.24~rc0 +0.24~rc1